From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6829 invoked from network); 9 Feb 2021 21:03:55 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 9 Feb 2021 21:03:55 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1l9aAs-00Deqc-9k for ml@inbox.vuxu.org; Tue, 09 Feb 2021 15:03:54 -0600 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94) (envelope-from ) id 1l9aAr-00BcnP-PG for ml@inbox.vuxu.org; Tue, 09 Feb 2021 15:03:53 -0600 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1l8mZP-00BB5i-2j for ding@lists.math.uh.edu; Sun, 07 Feb 2021 10:05:55 -0600 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1l8mZM-00CHW7-8I for ding@lists.math.uh.edu; Sun, 07 Feb 2021 10:05:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:In-Reply-To:Date:References: Message-ID:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DoH629QQUmzxmZt7osK3FjI5fGgQqETETCshlLXhWic=; b=pmu8nHyzWL9cgqc2g9p8VP9xoF /MrW2JdRfhl4dOLUO5KWRhpyIlLN3cFB88eohX9wHv/qIJMAquJ0ebfP9YDYCf1R7qWbzdjzmWuq3 huUL6xFjvPsuFOiUM39UJ/Kap86X1cnqrfk+PWpLcLBctmA4cOszM935fE+j4iXKpwq8=; Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8mZC-000264-R1; Sun, 07 Feb 2021 17:05:46 +0100 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A43C100222; Sun, 7 Feb 2021 11:05:40 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EA66E10005D; Sun, 7 Feb 2021 11:05:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612713938; bh=ESOpTiR+JjUH54ndL21VCOvhSC6QRrGegmsQ/EIl4V4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eBefR1Owq3EBZnlNktjHXC4h+dNL0nXSe29gwEkSzgrEHF/TaZMNEyAbYtJOiXBon sK2DkoddWLitQiaXTIeP8U+ilfQrOtOcsM3kvE9wA8YS0icM/ynuPU8RkEOxM0n0Sy l9agWsU0xOqPbXYKA8xdUw5vGqgiMwKEMM92mxwluryicXTfnn6qoEvmyzdWD4Llo1 14f08vntiqvveVKsM1olr8d+PGUWLLV2vHtIqqNeH5fLlDG/xMOUucoAnKekcJgwz3 IxFN8mB+lMxDEMC/p9q/8CtRpRzzNXWeVDcOXOMe2QaGYCVpVskXmzbp0RLz/miGtp 9giE0OlFpJc9w== Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AFF2F12029C; Sun, 7 Feb 2021 11:05:38 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Cc: Eric S Fraga , ding@gnus.org, emacs-devel@gnu.org Subject: Re: gnus-article-view-part no longer seems to work (since commit 041b3904?) Message-ID: References: <87k0rlmm1d.fsf@ucl.ac.uk> <87czxc8528.fsf@gnus.org> Date: Sun, 07 Feb 2021 11:05:38 -0500 In-Reply-To: <87czxc8528.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 07 Feb 2021 12:56:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-ID: Precedence: bulk >> longer behaves as it used to. In particular, invoking >> gnus-article-view-part (typically by hitting "b" but I've tried the >> other bindings just in case) in the summary buffer does not change the >> view of the article as it used to (for articles that had, say, text and >> HTML parts). > > This comes from this patch: > > commit e1e9e4eefa41bacb6b412e57a569440a0847e4fa > Author: Stefan Monnier > AuthorDate: Fri Jan 29 23:58:58 2021 -0500 > > * lisp/gnus/gnus-art.el: Add `event` args and operate at its position. > > In particular, it's this bit: > > (defun gnus-article-press-button (&optional event) > "Check text at point for a callback function. > If the text at point has a `gnus-callback' property, > call it with the value of the `gnus-data' text property." > (interactive (list last-nonmenu-event)) > (save-excursion > (mouse-set-point event) > > `mouse-set-point' here changes the buffer to the summary buffer. I'm > not quite sure what the rationale here is... and there's no mouse > involved... > > Stefan? Hmm... indeed in the OP's case the function is not called interactively, but via some other function (`gnus-article-view-part`) which changes buffer. We could change the caller to provide some dummy `event` but it's easier to just replace the (mouse-set-point event) with (if event (mouse-set-point event)) -- Stefan