Gnus development mailing list
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: functionp bug
Date: Mon, 07 Apr 2008 15:23:34 -0400	[thread overview]
Message-ID: <jwvve2tpj2f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <v9skxx4ifd.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon, 07 Apr 2008 20:40:54 +0200")

> There are around 70 (functionp somevar) in Gnus.  I'd guess that many
> of these expect `functionp' to return non-nil for special forms (or,
> if, and, ...).

All the places that call `functionp' and expect it to return t for `or',
and `if', have a bug, because they should also accept `when' for which
`functionp' has been returning nil for a loooong time now.

> Maybe it is possible to fix them all, but is it really the right thing
> to make such an incompatible change?  What is the reason for
> this change?

That the strange definition of `functionp' was never what was really
needed: if special-forms should be accepted, than so should macros.


        Stefan




  reply	other threads:[~2008-04-07 19:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-07  1:20 Katsumi Yamaoka
2008-04-07 16:04 ` Stefan Monnier
2008-04-07 18:34   ` Romain Francoise
2008-04-07 19:26     ` Stefan Monnier
2008-04-07 21:27       ` Manoj Srivastava
2008-04-07 21:50         ` Reiner Steib
2008-04-07 18:40   ` Reiner Steib
2008-04-07 19:23     ` Stefan Monnier [this message]
2008-04-09  7:56       ` Katsumi Yamaoka
2008-04-09  8:54         ` Andreas Schwab
2008-04-09 10:34         ` Richard Stallman
2008-04-09 14:22           ` Stefan Monnier
2008-04-09 14:26         ` Stefan Monnier
2008-04-09 22:53           ` Katsumi Yamaoka
2008-04-10  1:36             ` Stefan Monnier
2008-04-10  2:02               ` Katsumi Yamaoka
2008-04-10 10:44                 ` Reiner Steib
2008-04-10 11:19                   ` Katsumi Yamaoka
2008-04-10 11:38                     ` Reiner Steib
2008-04-10 11:57                       ` Katsumi Yamaoka
2008-04-10 18:24                   ` Stefan Monnier
2008-04-10 19:12                     ` Reiner Steib
2008-04-10 21:17                       ` Stefan Monnier
2008-04-10 22:13                         ` Reiner Steib
2008-04-09 22:34       ` Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvve2tpj2f.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).