From: Hrvoje Niksic <hniksic@srce.hr>
Cc: ding@gnus.org
Subject: Re: *Group* buffer disaster fix
Date: 21 Oct 1998 18:40:29 +0200 [thread overview]
Message-ID: <kigu30xeuma.fsf@jagor.srce.hr> (raw)
In-Reply-To: Lloyd Zusman's message of "21 Oct 1998 12:25:55 -400"
Lloyd Zusman <ljz@asfast.com> writes:
> > --- mailcap.el.orig Wed Oct 21 16:27:16 1998
> > +++ mailcap.el Wed Oct 21 16:27:30 1998
> > @@ -272,11 +272,12 @@
> >
> > (defun mailcap-save-binary-file ()
> > (goto-char (point-min))
> > - (let ((file (read-file-name
> > - "Filename to save as: "
> > - (or mailcap-download-directory "~/")))
> > - (require-final-newline nil))
> > - (write-region (point-min) (point-max) file)
> > + (unwind-protect
> > + (let ((file (read-file-name
> > + "Filename to save as: "
> > + (or mailcap-download-directory "~/")))
> > + (require-final-newline nil))
> > + (write-region (point-min) (point-max) file))
> > (kill-buffer (current-buffer))))
> >
> > (defun mailcap-maybe-eval ()
>
> Why do we need to do a `kill-buffer' in this routine at all when
> `(mapcar 'mm-destroy-part gnus-article-mime-handles)' is already
> being done within `gnus-summary-exit' and `gnus-group-exit-hook'?
Because we want the "*mm*" buffer to go away as soon as we're done
with it. Also, the code killing the buffer was already there -- no
`+' before it. I only added the unwind-protect bit.
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Speak softly and carry a +6 two-handed sword.
next prev parent reply other threads:[~1998-10-21 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-10-21 14:30 Hrvoje Niksic
1998-10-21 16:25 ` Lloyd Zusman
1998-10-21 16:40 ` Hrvoje Niksic [this message]
1998-10-21 17:06 ` Lloyd Zusman
1998-10-21 17:49 ` Hrvoje Niksic
1998-10-22 1:59 ` Lars Magne Ingebrigtsen
1998-10-22 3:14 ` Lloyd Zusman
1998-10-24 4:32 ` Lars Magne Ingebrigtsen
1998-10-22 1:56 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kigu30xeuma.fsf@jagor.srce.hr \
--to=hniksic@srce.hr \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).