From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/18021
Path: main.gmane.org!not-for-mail
From: Hrvoje Niksic <hniksic@srce.hr>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: *Group* buffer disaster fix
Date: 21 Oct 1998 18:40:29 +0200
Sender: owner-ding@hpc.uh.edu
Message-ID: <kigu30xeuma.fsf@jagor.srce.hr>
References: <kign26qf0no.fsf@jagor.srce.hr> <ltiuhdlw4r.fsf@asfast.com>
NNTP-Posting-Host: coloc-standby.netfonds.no
X-Trace: main.gmane.org 1035156618 3975 80.91.224.250 (20 Oct 2002 23:30:18 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 20 Oct 2002 23:30:18 +0000 (UTC)
Cc: ding@gnus.org
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from fisher.math.uh.edu (fisher.math.uh.edu [129.7.128.35])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id MAA27394
	for <jason@mailhost.sclp.com>; Wed, 21 Oct 1998 12:41:36 -0400 (EDT)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by fisher.math.uh.edu (8.9.1/8.9.1) with ESMTP id LAB18239;
	Wed, 21 Oct 1998 11:41:21 -0500 (CDT)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 21 Oct 1998 11:41:21 -0500 (CDT)
Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [209.195.19.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id LAA26582 for <ding@hpc.uh.edu>; Wed, 21 Oct 1998 11:41:11 -0500 (CDT)
Original-Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id MAA27384
	for <ding@gnus.org>; Wed, 21 Oct 1998 12:40:55 -0400 (EDT)
Original-Received: (from hniksic@localhost)
	by jagor.srce.hr (8.9.0/8.9.0) id SAA19689;
	Wed, 21 Oct 1998 18:40:29 +0200 (MET DST)
Original-To: Lloyd Zusman <ljz@asfast.com>
X-Attribution: Hrvoje
X-Face: &{dT~)Pu6V<0y?>3p$;@vh\`C7xB~A0T-J%Og)J,@-1%q6Q+,
        gs<-9M#&`I8cJp2b1{vPE|~+JE+gx;a7%BG{}nY^ehK1"q#rG
        O,Rn1A_Cy%t]V=Brv7h<L@)<XGh#XroV6xQg$VA8K
In-Reply-To: Lloyd Zusman's message of "21 Oct 1998 12:25:55 -400"
Original-Lines: 35
User-Agent: Gnus/5.070036 (Pterodactyl Gnus v0.36) XEmacs/21.0 (Danish Landrace)
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:18021
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:18021

Lloyd Zusman <ljz@asfast.com> writes:

> > --- mailcap.el.orig	Wed Oct 21 16:27:16 1998
> > +++ mailcap.el	Wed Oct 21 16:27:30 1998
> > @@ -272,11 +272,12 @@
> >  
> >  (defun mailcap-save-binary-file ()
> >    (goto-char (point-min))
> > -  (let ((file (read-file-name
> > -	       "Filename to save as: "
> > -	       (or mailcap-download-directory "~/")))
> > -	(require-final-newline nil))
> > -    (write-region (point-min) (point-max) file)
> > +  (unwind-protect
> > +      (let ((file (read-file-name
> > +		   "Filename to save as: "
> > +		   (or mailcap-download-directory "~/")))
> > +	    (require-final-newline nil))
> > +	(write-region (point-min) (point-max) file))
> >      (kill-buffer (current-buffer))))
> >  
> >  (defun mailcap-maybe-eval ()
> 
> Why do we need to do a `kill-buffer' in this routine at all when
> `(mapcar 'mm-destroy-part gnus-article-mime-handles)' is already
> being done within `gnus-summary-exit' and `gnus-group-exit-hook'?

Because we want the "*mm*" buffer to go away as soon as we're done
with it.  Also, the code killing the buffer was already there -- no
`+' before it.  I only added the unwind-protect bit.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Speak softly and carry a +6 two-handed sword.