From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67942 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus shouldn't be making general-purpose variables buffer-local Date: Wed, 17 Dec 2008 14:38:26 +0100 Message-ID: References: <9aa0cfde0812112242o38d885a1h12d9e4ac490021@mail.gmail.com> <863agokpas.fsf@lifelogs.com> <87vdtj41ux.fsf@engster.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229521153 12933 80.91.229.12 (17 Dec 2008 13:39:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Dec 2008 13:39:13 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M16388@lists.math.uh.edu Wed Dec 17 14:40:18 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LCwdN-0003yd-Tw for ding-account@gmane.org; Wed, 17 Dec 2008 14:40:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LCwbh-0004wX-PJ; Wed, 17 Dec 2008 07:38:33 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LCwbg-0004wF-Dw for ding@lists.math.uh.edu; Wed, 17 Dec 2008 07:38:32 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LCwbd-0003pJ-FI for ding@lists.math.uh.edu; Wed, 17 Dec 2008 07:38:32 -0600 Original-Received: from m61s02.vlinux.de ([83.151.21.164]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LCwbq-0006EQ-00 for ; Wed, 17 Dec 2008 14:38:42 +0100 Original-Received: from kafka.physik3.gwdg.de ([134.76.92.48] helo=kafka) by m61s02.vlinux.de with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.63) (envelope-from ) id 1LCwbc-0000IN-IW for ding@gnus.org; Wed, 17 Dec 2008 14:38:28 +0100 Mail-Copies-To: never Mail-Followup-To: ding@gnus.org In-Reply-To: (Katsumi Yamaoka's message of "Wed, 17 Dec 2008 21:26:16 +0900") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67942 Archived-At: Katsumi Yamaoka writes: >>>>>> David Engster wrote: >> So maybe, we should change `gnus-summary-set-local-parameters' to only >> set those variables buffer-local that begin with a proper prefix, like >> "gnus-" and "mm-" ? > > But it will disable the existing features concerning the parameters > of which the names don't begin with "gnus-" and "mm-". That shouldn't happen, since those parameters are usually retrieved through `gnus-group-get-parameter', `gnus-group-fast-parameter', or `gnus-group-find-parameter' (see e.g. how nnimap uses the uidvalidity parameter). If an existing feature breaks because of that change, I would argue that it is broken, since it shouldn't depend on group parameters being buffer-local variables. In short: Making a group parameter buffer-local should only be done for overriding a global value. That gives me an idea: in `gnus-summary-set-local-parameters', instead of defining fixed prefixes like "gnus-" or "mm-", we could simply make only those parameters buffer-local which are globally bound? > The best way seems to be to add "gnus-" or "mm-" to all the > parameters. However, it will take time for coding and verifying. The main problem I see is that this is an incompatible change, i.e. parameters from existing groups would have to be updated. > Maybe, it should do after the Emacs 23.1 release. I agree in any case. Regards, David