Gnus development mailing list
 help / color / mirror / Atom feed
* scroll-margin woes
@ 2008-03-13 15:12 David
  2008-03-13 17:25 ` Ralf Angeli
  0 siblings, 1 reply; 5+ messages in thread
From: David @ 2008-03-13 15:12 UTC (permalink / raw)
  To: ding

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

I've recently set my scroll-margin value to >0 and immediately had
problems using Gnus. First, I would recommend to apply the patch that
sets the scroll-margin to zero in summary buffers:

http://article.gmane.org/gmane.emacs.devel/85300

Even if this patch may only cure the symptom of a bug in Emacs I'd still
think it should be applied since a) it does no harm and b) the summary
buffer is otherwise practically unusable if scroll-margin > 0 and
Emacs 22 or newer.

Additionally, I noticed that when I hit ENTER in the summary buffer to
scroll the currently displayed article by one line, it often scrolls by
nearly a full page. This frequently happens in shimbun groups, but not
always - I can't really say why. My guess is this is due to

(move-to-window-line -1) 

in gnus-article-next-page. I fixed this behavior by putting the cursor
in the middle of the article buffer before calling
gnus-article-next-page-1 (see attached patch). This works for me, but I
don't know if this is the correct thing to do. Scrolling in Emacs is a
deep mystery to me...

-David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-art-patch.diff --]
[-- Type: text/x-diff, Size: 376 bytes --]

--- gnus-art.el	2008-03-13 15:51:23.000000000 +0100
+++ gnus-art.el-patched	2008-03-13 15:52:31.000000000 +0100
@@ -6100,6 +6100,9 @@
 	(gnus-narrow-to-page 1)		;Go to next page.
 	nil)
     ;; More in this page.
+    (when (and (boundp 'scroll-margin)
+	       (not (zerop scroll-margin)))
+      (move-to-window-line nil))
     (gnus-article-next-page-1 lines)
     nil))
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: scroll-margin woes
  2008-03-13 15:12 scroll-margin woes David
@ 2008-03-13 17:25 ` Ralf Angeli
  2008-03-14  9:01   ` David
  0 siblings, 1 reply; 5+ messages in thread
From: Ralf Angeli @ 2008-03-13 17:25 UTC (permalink / raw)
  To: ding

* David (2008-03-13) writes:

> the summary
> buffer is otherwise practically unusable if scroll-margin > 0 and
> Emacs 22 or newer.

Get rid of your outdated Gnus installation and try again.

-- 
Ralf




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: scroll-margin woes
  2008-03-13 17:25 ` Ralf Angeli
@ 2008-03-14  9:01   ` David
  2008-03-14 18:28     ` Ralf Angeli
  0 siblings, 1 reply; 5+ messages in thread
From: David @ 2008-03-14  9:01 UTC (permalink / raw)
  To: ding

Ralf Angeli <angeli@caeruleus.net> writes:
> * David (2008-03-13) writes:
>
>> the summary
>> buffer is otherwise practically unusable if scroll-margin > 0 and
>> Emacs 22 or newer.
>
> Get rid of your outdated Gnus installation and try again.

I'm using Gnus from CVS.

-David




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: scroll-margin woes
  2008-03-14  9:01   ` David
@ 2008-03-14 18:28     ` Ralf Angeli
  2008-03-17 14:18       ` David
  0 siblings, 1 reply; 5+ messages in thread
From: Ralf Angeli @ 2008-03-14 18:28 UTC (permalink / raw)
  To: ding

* David (2008-03-14) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>> * David (2008-03-13) writes:
>>
>>> the summary
>>> buffer is otherwise practically unusable if scroll-margin > 0 and
>>> Emacs 22 or newer.
>>
>> Get rid of your outdated Gnus installation and try again.
>
> I'm using Gnus from CVS.

Hm, then I don't know what the problem is.  I've been using the CVS
version as well with Emacs 22 and I haven't encountered any problems
with `scroll-margin' set to 1.

-- 
Ralf




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: scroll-margin woes
  2008-03-14 18:28     ` Ralf Angeli
@ 2008-03-17 14:18       ` David
  0 siblings, 0 replies; 5+ messages in thread
From: David @ 2008-03-17 14:18 UTC (permalink / raw)
  To: ding

Ralf Angeli <angeli@caeruleus.net> writes:
>> I'm using Gnus from CVS.
>
> Hm, then I don't know what the problem is.  I've been using the CVS
> version as well with Emacs 22 and I haven't encountered any problems
> with `scroll-margin' set to 1.

My scroll-margin is set to 7. The problem is not that easy to reproduce
since it seems to depend on the size of the summary buffer and is worst
with a threaded display (though it also occurs with disabled
threads). See also this post:

http://article.gmane.org/gmane.emacs.gnus.general/66402

I made a little screencast which shows the bug:

http://m61s02.vlinux.de/vid/gnus-scroll-margin.ogg

I open the group and continuously hit 'd' to mark posts as read. As you
can see, the summary buffer doesn't update correctly; you can see in the
status line that articles are actually marked:

-David




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-03-17 14:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-13 15:12 scroll-margin woes David
2008-03-13 17:25 ` Ralf Angeli
2008-03-14  9:01   ` David
2008-03-14 18:28     ` Ralf Angeli
2008-03-17 14:18       ` David

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).