From: David Engster <deng@randomsample.de>
To: ding@gnus.org
Cc: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: [BUG] recent change in gnus-inews-do-gcc
Date: Wed, 07 Jan 2009 11:53:02 +0100 [thread overview]
Message-ID: <kzwsd7crqp.fsf@randomsample.de> (raw)
In-Reply-To: <b4mwsd7c32r.fsf_-_@jpl.org> (Katsumi Yamaoka's message of "Wed, 07 Jan 2009 10:33:32 +0900")
Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>>>>> In <E1LKDnx-0002ty-00@quimby.gnus.org> David Engster wrote:
>
>> Modified: ChangeLog gnus-msg.el
>
>> gnus-msg.el (gnus-inews-do-gcc): Reduce to short group name when on
>> primary select method (for gnus-group-mark-article-as-read).
>
> This change causes an error when sending messages containing
> the "Gcc: nnml:inbox" header as follows:
>
> Debugger entered--Lisp error: (wrong-type-argument listp "nnml:")
> gnus-native-method-p("nnml:")
> (if (gnus-native-method-p method) (progn (setq group ...)))
> I guess you use the mail method as `gnus-select-method'. Whereas
> I have nntp in it and the others in `gnus-secondary-select-methods'.
> So, the method for Gcc groups will never be native in my case.
> Is this patch satisfy you and friends? If so, please install.
>
> --- gnus-msg.el~ 2009-01-06 21:43:06 +0000
> +++ gnus-msg.el 2009-01-07 01:32:50 +0000
> @@ -1677,7 +1677,8 @@
> group method t t))))
> (gnus-message 1 "Couldn't store article in group %s: %s"
> group (gnus-status-message method)))
> - (when (gnus-native-method-p method)
> + (when (and (not (stringp method))
> + (gnus-native-method-p method))
> (setq group (gnus-group-short-name group)))
> (when (and group-art
> ;; FIXME: Should gcc-mark-as-read work when
I am sorry for the inconveniences caused by that commit.
I did test it with secondary methods, but I didn't notice
gnus-inews-group-method could return a simplified server definition from
the group-info, which is just a string like "nnml:" instead of the full
method which is e.g. returned by gnus-find-method-for-group. This didn't
happen on my setup, since the groups I tested with contained full server
definitions in their infos.
Since a string like "nnml:" could also denote the primary back end, I
checked in a fix which converts simplified server definitions before
using it in gnus-native-p.
> BTW, isn't adding of new features frozen now?
I checked this in to fix a bug: Though gnus-gcc-mark-as-read was set,
articles wouldn't be marked as read when the GCC goes to the primary
back end. Please see the thread "Automatically marking Gcc's as SEEN in
nnimap" for details.
Regards,
David
prev parent reply other threads:[~2009-01-07 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1LKDnx-0002ty-00@quimby.gnus.org>
2009-01-07 1:33 ` Katsumi Yamaoka
2009-01-07 10:53 ` David Engster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kzwsd7crqp.fsf@randomsample.de \
--to=deng@randomsample.de \
--cc=ding@gnus.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).