[BUG] recent change in gnus-inews-do-gcc

[BUG] recent change in gnus-inews-do-gcc

[Katsumi Yamaoka]

>>>>> In <E1LKDnx-0002ty-00@quimby.gnus.org> David Engster wrote:

> Modified: ChangeLog gnus-msg.el

> gnus-msg.el (gnus-inews-do-gcc): Reduce to short group name when on
> primary select method (for gnus-group-mark-article-as-read).

This change causes an error when sending messages containing
the "Gcc: nnml:inbox" header as follows:

Debugger entered--Lisp error: (wrong-type-argument listp "nnml:")
  gnus-native-method-p("nnml:")
  (if (gnus-native-method-p method) (progn (setq group ...)))
[...]
  gnus-inews-do-gcc()
  gnus-agent-possibly-do-gcc()
  run-hooks(message-sent-hook)
  message-send(nil)
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit nil nil)

> --- gnus-msg.el:7.69	Fri Aug  8 13:10:55 2008
> +++ gnus-msg.el	Tue Jan  6 16:25:17 2009
> @@ -1677,6 +1677,8 @@
>  				    group method t t))))
>  		(gnus-message 1 "Couldn't store article in group %s: %s"
>  			      group (gnus-status-message method)))
> +	      (when (gnus-native-method-p method)
> +		(setq group (gnus-group-short-name group)))
>  	      (when (and group-art
>  			 ;; FIXME: Should gcc-mark-as-read work when
>  			 ;; Gnus is not running?

I guess you use the mail method as `gnus-select-method'.  Whereas
I have nntp in it and the others in `gnus-secondary-select-methods'.
So, the method for Gcc groups will never be native in my case.
Is this patch satisfy you and friends?  If so, please install.

--8<---------------cut here---------------start------------->8---
--- gnus-msg.el~	2009-01-06 21:43:06 +0000
+++ gnus-msg.el	2009-01-07 01:32:50 +0000
@@ -1677,7 +1677,8 @@
 				    group method t t))))
 		(gnus-message 1 "Couldn't store article in group %s: %s"
 			      group (gnus-status-message method)))
-	      (when (gnus-native-method-p method)
+	      (when (and (not (stringp method))
+			 (gnus-native-method-p method))
 		(setq group (gnus-group-short-name group)))
 	      (when (and group-art
 			 ;; FIXME: Should gcc-mark-as-read work when
--8<---------------cut here---------------end--------------->8---

BTW, isn't adding of new features frozen now?

Re: [BUG] recent change in gnus-inews-do-gcc

[David Engster]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>>>>> In <E1LKDnx-0002ty-00@quimby.gnus.org> David Engster wrote:
>
>> Modified: ChangeLog gnus-msg.el
>
>> gnus-msg.el (gnus-inews-do-gcc): Reduce to short group name when on
>> primary select method (for gnus-group-mark-article-as-read).
>
> This change causes an error when sending messages containing
> the "Gcc: nnml:inbox" header as follows:
>
> Debugger entered--Lisp error: (wrong-type-argument listp "nnml:")
>   gnus-native-method-p("nnml:")
>   (if (gnus-native-method-p method) (progn (setq group ...)))

> I guess you use the mail method as `gnus-select-method'.  Whereas
> I have nntp in it and the others in `gnus-secondary-select-methods'.
> So, the method for Gcc groups will never be native in my case.
> Is this patch satisfy you and friends?  If so, please install.
>
> --- gnus-msg.el~	2009-01-06 21:43:06 +0000
> +++ gnus-msg.el	2009-01-07 01:32:50 +0000
> @@ -1677,7 +1677,8 @@
>  				    group method t t))))
>  		(gnus-message 1 "Couldn't store article in group %s: %s"
>  			      group (gnus-status-message method)))
> -	      (when (gnus-native-method-p method)
> +	      (when (and (not (stringp method))
> +			 (gnus-native-method-p method))
>  		(setq group (gnus-group-short-name group)))
>  	      (when (and group-art
>  			 ;; FIXME: Should gcc-mark-as-read work when

I am sorry for the inconveniences caused by that commit.

I did test it with secondary methods, but I didn't notice
gnus-inews-group-method could return a simplified server definition from
the group-info, which is just a string like "nnml:" instead of the full
method which is e.g. returned by gnus-find-method-for-group. This didn't
happen on my setup, since the groups I tested with contained full server
definitions in their infos.

Since a string like "nnml:" could also denote the primary back end, I
checked in a fix which converts simplified server definitions before
using it in gnus-native-p.

> BTW, isn't adding of new features frozen now?

I checked this in to fix a bug: Though gnus-gcc-mark-as-read was set,
articles wouldn't be marked as read when the GCC goes to the primary
back end. Please see the thread "Automatically marking Gcc's as SEEN in
nnimap" for details.

Regards,
David