From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68099 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.gnus.general Subject: Re: [BUG] recent change in gnus-inews-do-gcc Date: Wed, 07 Jan 2009 11:53:02 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231325624 27576 80.91.229.12 (7 Jan 2009 10:53:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Jan 2009 10:53:44 +0000 (UTC) Cc: Katsumi Yamaoka To: ding@gnus.org Original-X-From: ding-owner+M16544@lists.math.uh.edu Wed Jan 07 11:54:56 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LKW3q-0006i9-Df for ding-account@gmane.org; Wed, 07 Jan 2009 11:54:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LKW2C-0000Ey-0Q; Wed, 07 Jan 2009 04:53:12 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LKW29-0000EU-Ne for ding@lists.math.uh.edu; Wed, 07 Jan 2009 04:53:09 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LKW26-0007yk-MS for ding@lists.math.uh.edu; Wed, 07 Jan 2009 04:53:09 -0600 Original-Received: from m61s02.vlinux.de ([83.151.21.164]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LKW2M-0004LJ-00 for ; Wed, 07 Jan 2009 11:53:23 +0100 Original-Received: from kafka.physik3.gwdg.de ([134.76.92.48] helo=kafka) by m61s02.vlinux.de with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.63) (envelope-from ) id 1LKW24-0003FR-Dv; Wed, 07 Jan 2009 11:53:04 +0100 Mail-Copies-To: never Mail-Followup-To: ding@gnus.org, Katsumi Yamaoka In-Reply-To: (Katsumi Yamaoka's message of "Wed, 07 Jan 2009 10:33:32 +0900") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68099 Archived-At: Katsumi Yamaoka writes: >>>>>> In David Engster wrote: > >> Modified: ChangeLog gnus-msg.el > >> gnus-msg.el (gnus-inews-do-gcc): Reduce to short group name when on >> primary select method (for gnus-group-mark-article-as-read). > > This change causes an error when sending messages containing > the "Gcc: nnml:inbox" header as follows: > > Debugger entered--Lisp error: (wrong-type-argument listp "nnml:") > gnus-native-method-p("nnml:") > (if (gnus-native-method-p method) (progn (setq group ...))) > I guess you use the mail method as `gnus-select-method'. Whereas > I have nntp in it and the others in `gnus-secondary-select-methods'. > So, the method for Gcc groups will never be native in my case. > Is this patch satisfy you and friends? If so, please install. > > --- gnus-msg.el~ 2009-01-06 21:43:06 +0000 > +++ gnus-msg.el 2009-01-07 01:32:50 +0000 > @@ -1677,7 +1677,8 @@ > group method t t)))) > (gnus-message 1 "Couldn't store article in group %s: %s" > group (gnus-status-message method))) > - (when (gnus-native-method-p method) > + (when (and (not (stringp method)) > + (gnus-native-method-p method)) > (setq group (gnus-group-short-name group))) > (when (and group-art > ;; FIXME: Should gcc-mark-as-read work when I am sorry for the inconveniences caused by that commit. I did test it with secondary methods, but I didn't notice gnus-inews-group-method could return a simplified server definition from the group-info, which is just a string like "nnml:" instead of the full method which is e.g. returned by gnus-find-method-for-group. This didn't happen on my setup, since the groups I tested with contained full server definitions in their infos. Since a string like "nnml:" could also denote the primary back end, I checked in a fix which converts simplified server definitions before using it in gnus-native-p. > BTW, isn't adding of new features frozen now? I checked this in to fix a bug: Though gnus-gcc-mark-as-read was set, articles wouldn't be marked as read when the GCC goes to the primary back end. Please see the thread "Automatically marking Gcc's as SEEN in nnimap" for details. Regards, David