From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/50323 Path: main.gmane.org!not-for-mail From: Martin Thornquist Newsgroups: gmane.emacs.gnus.general Subject: *Group* last line behavior Date: Mon, 24 Feb 2003 01:07:02 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1046045508 1910 80.91.224.249 (24 Feb 2003 00:11:48 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 24 Feb 2003 00:11:48 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18n6Di-0000Ug-00 for ; Mon, 24 Feb 2003 01:11:46 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18n6Cm-0004rF-00; Sun, 23 Feb 2003 18:10:48 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 23 Feb 2003 18:11:48 -0600 (CST) Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id SAA03470 for ; Sun, 23 Feb 2003 18:11:36 -0600 (CST) Original-Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18n6CJ-0000R2-00 for ; Mon, 24 Feb 2003 01:10:19 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@hpc.uh.edu Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18n68x-0000H8-00 for ; Mon, 24 Feb 2003 01:06:51 +0100 Original-Lines: 56 Original-X-Complaints-To: usenet@main.gmane.org X-Face: *F7Hd7p3}A$V&*+$yikQb~';$]%NCmb'VY Mail-Copies-To: nobody User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.2 ( Cancel-Lock: sha1:dAdrBEiUrgn81qWTc11+YPA8bZU= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:50323 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:50323 Something that has bugged me for a while is that RET on the last (empty) line in *Group* signals an error, while the same in *Summary* selects the last article. So I fixed it. The following patches gives *Group* (what I think is) consistent behavior with *Summary*, both in topic and non-topic view. I have been using these patches for about a week now without discovering any unforeseen consequences, but there could of course always be some. This is little enough not to require paperwork if included in Gnus, right? Index: lisp/gnus-group.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-group.el,v retrieving revision 6.101 diff -u -r6.101 gnus-group.el --- lisp/gnus-group.el 14 Feb 2003 20:28:13 -0000 6.101 +++ lisp/gnus-group.el 24 Feb 2003 00:20:51 -0000 @@ -1876,6 +1876,9 @@ If ALL is non-nil, already read articles become readable. If ALL is a number, fetch this number of articles." (interactive "P") + (when (and (= (point) (point-max)) + (not (gnus-group-group-name))) + (forward-line -1)) (gnus-group-read-group all t)) (defun gnus-group-quick-select-group (&optional all) Index: lisp/gnus-topic.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-topic.el,v retrieving revision 6.36 diff -u -r6.36 gnus-topic.el --- lisp/gnus-topic.el 19 Feb 2003 23:45:34 -0000 6.36 +++ lisp/gnus-topic.el 24 Feb 2003 00:21:17 -0000 @@ -1180,7 +1180,10 @@ If performed over a topic line, toggle folding the topic." (interactive "P") - (if (gnus-group-topic-p) + (when (and (= (point) (point-max)) + (not (gnus-group-group-name))) + (forward-line -1)) + (if (gnus-group-topic-p) (let ((gnus-group-list-mode (if all (cons (if (numberp all) all 7) t) gnus-group-list-mode))) (gnus-topic-fold all) Martin -- "An ideal world is left as an exercise to the reader." -Paul Graham, On Lisp