Gnus development mailing list
 help / color / mirror / Atom feed
From: letters@hotpop.com (Jari Aalto+mail.linux)
Subject: Re: [patch] gnus.el::gnus-invalid-group-regexp - Support IMAP
Date: Tue, 19 Aug 2003 21:17:56 +0300	[thread overview]
Message-ID: <lltpbjfv.fsf@blue.sea.net> (raw)

  Simon Josefsson <jas <at> extundo.com>
  > I happened to read thread and the default indeed seemed a little twirst.
  > Please review,

  A potential problem may be if you create, e.g., a nnml or nnfolder
  group with the name containing '/'.  Does it work?  With Agent/Caching
  too?  Does it do what users expect?  With all
  nnmail-use-long-file-names settings?  No problems with having two
  groups 'foo' and 'foo/bar'?  Many questions.

Hm. Okay, what about letting user decide? Like this:

2003-08-19 Tue  Jari Aalto  <jari.aalto@poboxes.com>

        * gnus.el (gnus-read-group): 6.194 Added check to ask confirmation
	if Group name contains invalid character. You can use '/' in IMAP,
	but not in filenames. G m cannot know what the user is creating,
	so let user decide. See thread
	http://groups.google.com/groups?oi=djq&as_umsgid=%3Cm2oeysiev3.fsf@naima.lensflare.org
	also available at GOOGLE: "Creating IMAP group"
	group:gnu.emacs.gnus

Prereq: 6.194

Index: gnus.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus.el,v
retrieving revision 6.194
diff -u -IId: -u -b -w -r6.194 gnus.el
--- gnus.el	7 Aug 2003 00:34:56 -0000	6.194
+++ gnus.el	19 Aug 2003 18:12:13 -0000
@@ -3714,8 +3714,13 @@
 	     (setq group (read-string (concat prefix prompt)
 				      (cons (or default "") 0)
 				      'gnus-group-history)))
+        (let ((match (match-string 0 group)))
+          (unless (y-or-n-p
+                   (format
+                    "Warning, group \"%s\" contains \"%s\"; Are you SURE? "
+                    group match))
 	(setq prefix (format "Invalid group name: \"%s\".  " group)
-	      group nil)))
+                  group nil)))))
     group))
 
 (defun gnus-read-method (prompt)


-- 
http://tiny-tools.sourceforge.net/
Swatch @time   http://www.mir.com.my/iTime/itime.htm
               http://www.ryanthiessen.com/swatch/resources.htm
Use Licenses!  http://www.linuxjournal.com/article.php?sid=6225
Which Licence? http://www.linuxjournal.com/article.php?sid=4825
OSI Licences   http://www.opensource.org/licenses/




             reply	other threads:[~2003-08-19 18:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-19 18:17 Jari Aalto+mail.linux [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-08-19 16:16 Jari Aalto+mail.linux
2003-08-19 17:21 ` Simon Josefsson
2003-08-20 17:14   ` Reiner Steib
2003-08-20 22:46     ` Simon Josefsson
2003-08-21 14:23       ` Reiner Steib
2003-08-22  0:50         ` Simon Josefsson
2003-08-22 16:07           ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lltpbjfv.fsf@blue.sea.net \
    --to=letters@hotpop.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).