From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/28350 Path: main.gmane.org!not-for-mail From: Lloyd Zusman Newsgroups: gmane.emacs.gnus.general Subject: Must filladapt be disabled? (Was: Filladapt's "fill-paragraph" during "W w") Date: 20 Dec 1999 20:15:19 -0500 Organization: Linux Hippopotamus Preserve Sender: owner-ding@hpc.uh.edu Message-ID: References: <9t9d7s3zzil.fsf@mraz.iskon.hr> <9t9902rzw91.fsf@mraz.iskon.hr> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035165215 29426 80.91.224.250 (21 Oct 2002 01:53:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:53:35 +0000 (UTC) Return-Path: Original-Received: from spinoza.math.uh.edu (spinoza.math.uh.edu [129.7.128.18]) by mailhost.sclp.com (Postfix) with ESMTP id 7867CD051F for ; Mon, 20 Dec 1999 20:20:04 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by spinoza.math.uh.edu (8.9.1/8.9.1) with ESMTP id TAB12983; Mon, 20 Dec 1999 19:15:46 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Mon, 20 Dec 1999 19:15:55 -0600 (CST) Original-Received: from mailhost.sclp.com (postfix@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id TAA01131 for ; Mon, 20 Dec 1999 19:15:42 -0600 (CST) Original-Received: from ljz.net (ljz.net [205.230.65.138]) by mailhost.sclp.com (Postfix) with ESMTP id CF872D051E for ; Mon, 20 Dec 1999 20:15:21 -0500 (EST) Original-Received: (from gnus@localhost) by ljz.net (8.8.7/8.8.7) id UAA00162; Mon, 20 Dec 1999 20:15:19 -0500 Original-To: ding@gnus.org X-Face: "!ga1s|?LNLE3MeeeEYs(%LIl9q[xV9!j4#xf4!**BFW_ihlOb;:Slb>)vy>CJM writes: > Hrvoje Niksic writes: > > > Lloyd Zusman writes: > > > > > [ ... ] what's the canonical method for causing filladapt's > > > `fill-paragraph' function to be the one to run for each > > > paragraph during the standard `W w' article washing procedure > > > (`gnus-article-fill-cited-article')? > > > > I'm not sure you can do that at all. AFAIK gnus-cite implements its > > own algorithms for filling articles. Ones that work quite well, so > > I've never tried to replace them with filladapt. > > [ ... at this point, I originally said that > `gnus-article-fill-cited-article' in `gnus-cite.el' was > handling this correctly when `filladapt' was loaded, but I was > mistaken ... ] It turns out after all that `gnus-article-fill-cited-article' does indeed disable `filladapt' processing. Look at the line with the `***HERE***' comment in this excerpt of the function: (defun gnus-article-fill-cited-article (&optional force width) "Do word wrapping in the current article. If WIDTH (the numerical prefix), use that text width when filling." (interactive (list t current-prefix-arg)) (save-excursion (set-buffer gnus-article-buffer) (let ((buffer-read-only nil) (inhibit-point-motion-hooks t) (marks (gnus-dissect-cited-text)) (adaptive-fill-mode nil) (filladapt-mode nil) ;; ***HERE*** (fill-column (if width (prefix-numeric-value width) fill-column))) (save-restriction ;;; etc. ... By turning `filladapt-mode' off, the standard `fill-region' gets called and not the one that would have been overridden by the `filladapt' version. Is there any compelling reason for `filladapt-mode' to be turned off here? If not, could this line just get removed (and possibly the line above with `adaptive-fill-mode' also)? Or if it's important to usually turn this off, could this then be controlled by some special variable, maybe sort of like this??? ... (filladapt-mode (if gnus-cite-use-filladapt filladapt-mode)) ... where `gnus-cite-use-filladapt' is a variable whose default value is `nil' but which could be optionally customized to be `t'. This way, people like me could force `filladapt' filling during article washing. Any thoughts? Thanks in advance. -- Lloyd Zusman ljz@asfast.com