Gnus development mailing list
 help / color / mirror / Atom feed
From: Lloyd Zusman <ljz@asfast.com>
Subject: Pgnus-0.33: bug in "mailcap-possible-viewers"
Date: 08 Oct 1998 22:56:37 -400	[thread overview]
Message-ID: <lt67duxx22.fsf@asfast.com> (raw)

I found a small bug in the `mailcap-possible-viewers' routine in the
`mailcap.el' file in pgnus-0.33.  The `minor' parameter sometimes gets
passed in as `nil', and this causes `string-match' to fail.  I'm not
sure under what conditions this parameter gets set to `nil' ... this
might have to do with badly formed MIME headers in the message being
parsed ... ???

But whatever the case, the enclosed patch seems to fix the problem.
Use the `-b' option with `patch', since my `diff' program might have
have messed with the leading white space.

By the way, today is the first day that I tried anything from the
pgnus series.  My congratulations to you, Lars ... your MIME-handling
code works great!

*** mailcap.el.orig	Thu Oct  8 22:41:00 1998
--- mailcap.el	Thu Oct  8 22:41:07 1998
***************
*** 469,475 ****
        (cond
         ((equal (car (car major)) minor)
  	(setq exact (cons (cdr (car major)) exact)))
!        ((string-match (car (car major)) minor)
  	(setq wildcard (cons (cdr (car major)) wildcard))))
        (setq major (cdr major)))
      (nconc (nreverse exact) (nreverse wildcard))))
--- 469,475 ----
        (cond
         ((equal (car (car major)) minor)
  	(setq exact (cons (cdr (car major)) exact)))
!        ((and minor (string-match (car (car major)) minor))
  	(setq wildcard (cons (cdr (car major)) wildcard))))
        (setq major (cdr major)))
      (nconc (nreverse exact) (nreverse wildcard))))

-- 
 Lloyd Zusman
 ljz@asfast.com


             reply	other threads:[~1998-10-09  2:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-10-09  2:56 Lloyd Zusman [this message]
1998-10-09  3:08 ` Correction! (Re: Pgnus-0.33: bug in "mailcap-possible-viewers") Lloyd Zusman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lt67duxx22.fsf@asfast.com \
    --to=ljz@asfast.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).