* PATCH: error (v5.8.0) in mail-source-set-common-1
@ 1999-12-02 1:52 Lloyd Zusman
1999-12-02 4:05 ` Shenghuo ZHU
0 siblings, 1 reply; 3+ messages in thread
From: Lloyd Zusman @ 1999-12-02 1:52 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
There's a problem I noticed in the (?nearly-)latest cvs patches to v5.8.0.
The error occurs for me upon Gnus startup in the
`mail-source-set-common-1' function in `mail-source.el'. Attached are
my patch and also the backtrace of the error.
Those of you who understand the guts of the `mail-source' processing
could probably determine if this is a true fix or simply a band-aid to
cover up a more fundamental problem ... but it at least got Gnus
running for me again.
Because I'm not sure if this is a real fix or just a band-aid, I'm not
attempting to apply this patch to cvs (and so far no having tried to
apply anything else to cvs, I'm not even sure if I'd be authorized to
do so). Therefore, if someone who can apply cvs patches determines
that this indeed is a bona-fide fix, then it would still have to be
applied to the archive.
In case this matters, these are my `nnmail-*' and `mail-source-*' variables
from my `.gnus.el' file:
(setq nnmail-spool-file
'((directory :path "/home/me/Mail/instuff/"
:suffix ".in"))
nnmail-use-long-file-names t
nnmail-cache-accepted-message-ids t
nnmail-crosspost nil
mail-source-directory "~/Mail/Incoming/"
mail-source-delete-incoming nil
mail-source-movemail-program "/usr/bin/movemail"
)
I hope this helps ...
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 955 bytes --]
*** mail-source.el.orig Wed Dec 1 20:32:17 1999
--- mail-source.el Wed Dec 1 20:34:16 1999
***************
*** 192,200 ****
default value keyword)
(while (setq default (pop defaults))
(set (mail-source-strip-keyword (setq keyword (car default)))
! (if (setq value (plist-get source keyword))
(mail-source-value value)
! (if (setq value (plist-get defaults-1 keyword))
(mail-source-value value)
(mail-source-value (cadr default))))))))
--- 192,202 ----
default value keyword)
(while (setq default (pop defaults))
(set (mail-source-strip-keyword (setq keyword (car default)))
! (if (and (valid-plist-p keyword)
! (setq value (plist-get source keyword)))
(mail-source-value value)
! (if (and (valid-plist-p keyword)
! (setq value (plist-get defaults-1 keyword)))
(mail-source-value value)
(mail-source-value (cadr default))))))))
[-- Attachment #3: Backtrace --]
[-- Type: text/plain, Size: 1638 bytes --]
Signaling: (malformed-property-list ((:path) (:suffix ".spool") (:predicate identity)) ((:predicate identity)))
plist-get(((:path) (:suffix ".spool") (:predicate identity)) :plugged)
mail-source-set-common-1((directory :path "/home/gnus/Mail/Groups/" :suffix ".in"))
mail-source-fetch((directory :path "/home/gnus/Mail/Groups/" :suffix ".in") (lambda (file orig-file) (nnmail-split-incoming file (quote nnml-save-mail) (quote nil) (nnmail-get-split-group orig-file source) (quote nnml-active-number))))
nnmail-get-new-mail(nnml nnml-save-nov "~/Mail/" nil)
nnml-request-scan(nil "email")
gnus-request-scan(nil (nnml "email" (nnml-directory "~/Mail/") (nnml-active-file "~/Mail/active") (nnml-newsgroups-file "~/Mail/newsgroups") (nnml-get-new-mail t)))
gnus-read-active-file-1((nnml "email" (nnml-directory "~/Mail/") (nnml-active-file "~/Mail/active") (nnml-newsgroups-file "~/Mail/newsgroups") (nnml-get-new-mail t)) nil)
gnus-read-active-file(nil nil)
gnus-setup-news(nil nil nil)
byte-code("..." [dont-connect did-connect gnus-group-quit gnus-run-hooks gnus-startup-hook gnus-make-newsrc-file gnus-startup-file gnus-current-startup-file gnus-slave gnus-use-dribble-file gnus-dribble-read-file gnus-use-grouplens bbb-login add-hook gnus-summary-mode-hook gnus-grouplens-mode gnus-setup-news nil level gnus-setup-news-hook gnus-start-draft-setup gnus-group-list-groups gnus-group-first-unread-group gnus-configure-windows group gnus-group-set-mode-line gnus-started-hook] 4)
gnus-1(nil nil nil)
gnus()
ljz-gnus-startup()
command-line-do-funcall("-f")
command-line-1()
command-line()
normal-top-level()
[-- Attachment #4: Type: text/plain, Size: 36 bytes --]
--
Lloyd Zusman
ljz@asfast.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: error (v5.8.0) in mail-source-set-common-1
1999-12-02 1:52 PATCH: error (v5.8.0) in mail-source-set-common-1 Lloyd Zusman
@ 1999-12-02 4:05 ` Shenghuo ZHU
1999-12-02 5:38 ` Lloyd Zusman
0 siblings, 1 reply; 3+ messages in thread
From: Shenghuo ZHU @ 1999-12-02 4:05 UTC (permalink / raw)
>>>>> "Lloyd" == Lloyd Zusman <ljz@asfast.com> writes:
Lloyd> There's a problem I noticed in the (?nearly-)latest cvs patches
Lloyd> to v5.8.0. The error occurs for me upon Gnus startup in the
Lloyd> `mail-source-set-common-1' function in `mail-source.el'.
Lloyd> Attached are my patch and also the backtrace of the error.
Lloyd> Those of you who understand the guts of the `mail-source'
Lloyd> processing could probably determine if this is a true fix or
Lloyd> simply a band-aid to cover up a more fundamental problem
Lloyd> ... but it at least got Gnus running for me again.
Lloyd> Because I'm not sure if this is a real fix or just a band-aid,
Lloyd> I'm not attempting to apply this patch to cvs (and so far no
Lloyd> having tried to apply anything else to cvs, I'm not even sure
Lloyd> if I'd be authorized to do so). Therefore, if someone who can
Lloyd> apply cvs patches determines that this indeed is a bona-fide
Lloyd> fix, then it would still have to be applied to the archive.
Thank you for your patch. But your patch just disabled getting the
default values. I fix it in latest CVS patch. Please test it.
[...]
--
Shenghuo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: error (v5.8.0) in mail-source-set-common-1
1999-12-02 4:05 ` Shenghuo ZHU
@ 1999-12-02 5:38 ` Lloyd Zusman
0 siblings, 0 replies; 3+ messages in thread
From: Lloyd Zusman @ 1999-12-02 5:38 UTC (permalink / raw)
Cc: zsh
Shenghuo ZHU <zsh@cs.rochester.edu> writes:
> >>>>> "Lloyd" == Lloyd Zusman <ljz@asfast.com> writes:
>
> Lloyd> There's a problem I noticed in the (?nearly-)latest cvs patches
> Lloyd> to v5.8.0. The error occurs for me upon Gnus startup in the
> Lloyd> `mail-source-set-common-1' function in `mail-source.el'.
> Lloyd> Attached are my patch and also the backtrace of the error.
>
> Lloyd> [ ... ]
>
> Thank you for your patch. But your patch just disabled getting the
> default values. I fix it in latest CVS patch. Please test it.
>
> [...]
Yes, your fix that's now in the CVS archive works perfectly for me. I
see my error, and thank you for correcting it, as well as for putting
this fix so quickly into CVS.
--
Lloyd Zusman
ljz@asfast.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1999-12-02 5:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-12-02 1:52 PATCH: error (v5.8.0) in mail-source-set-common-1 Lloyd Zusman
1999-12-02 4:05 ` Shenghuo ZHU
1999-12-02 5:38 ` Lloyd Zusman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).