From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/27487
Path: main.gmane.org!not-for-mail
From: Lloyd Zusman <ljz@asfast.com>
Newsgroups: gmane.emacs.gnus.general
Subject: PATCH: error (v5.8.0) in mail-source-set-common-1
Date: 01 Dec 1999 20:52:16 -0500
Organization: Linux Hippopotamus Preserve
Sender: owner-ding@hpc.uh.edu
Message-ID: <ltbt8ap0rz.fsf@asfast.com>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Trace: main.gmane.org 1035164507 24856 80.91.224.250 (21 Oct 2002 01:41:47 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 01:41:47 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from bart.math.uh.edu (bart.math.uh.edu [129.7.128.48])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id UAA08514
	for <jason@mailhost.sclp.com>; Wed, 1 Dec 1999 20:53:15 -0500 (EST)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by bart.math.uh.edu (8.9.1/8.9.1) with ESMTP id TAB04411;
	Wed, 1 Dec 1999 19:53:02 -0600 (CST)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 01 Dec 1999 19:53:14 -0600 (CST)
Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id TAA01016
	for <ding@hpc.uh.edu>; Wed, 1 Dec 1999 19:53:00 -0600 (CST)
Original-Received: from ljz.net (gnus@ljz.net [205.230.65.138])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id UAA08505
	for <ding@gnus.org>; Wed, 1 Dec 1999 20:52:25 -0500 (EST)
Original-Received: (from gnus@localhost)
	by ljz.net (8.8.7/8.8.7) id UAA23297;
	Wed, 1 Dec 1999 20:52:16 -0500
Original-To: ding@gnus.org
X-Face: "!ga1s|?LNLE3MeeeEYs(%LIl9q[xV9!<nimJxd1qyQRquvu5XTnZ:_5VE-G&4*EAuW"7oJLIXj'DWrJ0z@,FlwvD2PA@qhQ2R#zgsc14Klk;OSE'*;+l8p?0^nK7*X#0zg5wd^!M^2pg,M4Qd^{1viG;fa{}b.s[?g(x$45c]]=@'ZQ&]sPXl!u:hxBAv>j4#xf4!**BFW_ihlOb;:Slb>)vy>CJM<qjGM,/6C6\|{))YWm6}Q#?3om%n8
Original-Lines: 45
User-Agent: Gnus/5.08 (Gnus v5.8.0) XEmacs/21.1 (20 Minutes to Nikko)
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:27487
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:27487

--=-=-=

There's a problem I noticed in the (?nearly-)latest cvs patches to v5.8.0.

The error occurs for me upon Gnus startup in the
`mail-source-set-common-1' function in `mail-source.el'.  Attached are
my patch and also the backtrace of the error.

Those of you who understand the guts of the `mail-source' processing
could probably determine if this is a true fix or simply a band-aid to
cover up a more fundamental problem ... but it at least got Gnus
running for me again.

Because I'm not sure if this is a real fix or just a band-aid, I'm not
attempting to apply this patch to cvs (and so far no having tried to
apply anything else to cvs, I'm not even sure if I'd be authorized to
do so).  Therefore, if someone who can apply cvs patches determines
that this indeed is a bona-fide fix, then it would still have to be
applied to the archive.

In case this matters, these are my `nnmail-*' and `mail-source-*' variables
from my `.gnus.el' file:

  (setq nnmail-spool-file
         '((directory :path "/home/me/Mail/instuff/"
		      :suffix ".in"))
      nnmail-use-long-file-names t
      nnmail-cache-accepted-message-ids t
      nnmail-crosspost nil
      mail-source-directory "~/Mail/Incoming/"
      mail-source-delete-incoming nil
      mail-source-movemail-program "/usr/bin/movemail"
  )


I hope this helps ...



--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=mail-source.patch
Content-Description: Patch

*** mail-source.el.orig	Wed Dec  1 20:32:17 1999
--- mail-source.el	Wed Dec  1 20:34:16 1999
***************
*** 192,200 ****
  	 default value keyword)
      (while (setq default (pop defaults))
        (set (mail-source-strip-keyword (setq keyword (car default)))
! 	   (if (setq value (plist-get source keyword))
  	       (mail-source-value value)
! 	     (if (setq value (plist-get defaults-1 keyword))
  		 (mail-source-value value)
  	       (mail-source-value (cadr default))))))))
  
--- 192,202 ----
  	 default value keyword)
      (while (setq default (pop defaults))
        (set (mail-source-strip-keyword (setq keyword (car default)))
! 	   (if (and (valid-plist-p keyword)
! 		    (setq value (plist-get source keyword)))
  	       (mail-source-value value)
! 	     (if (and (valid-plist-p keyword)
! 		      (setq value (plist-get defaults-1 keyword)))
  		 (mail-source-value value)
  	       (mail-source-value (cadr default))))))))
  

--=-=-=
Content-Disposition: attachment; filename=backtrace.txt
Content-Description: Backtrace

Signaling: (malformed-property-list ((:path) (:suffix ".spool") (:predicate identity)) ((:predicate identity)))
  plist-get(((:path) (:suffix ".spool") (:predicate identity)) :plugged)
  mail-source-set-common-1((directory :path "/home/gnus/Mail/Groups/" :suffix ".in"))
  mail-source-fetch((directory :path "/home/gnus/Mail/Groups/" :suffix ".in") (lambda (file orig-file) (nnmail-split-incoming file (quote nnml-save-mail) (quote nil) (nnmail-get-split-group orig-file source) (quote nnml-active-number))))
  nnmail-get-new-mail(nnml nnml-save-nov "~/Mail/" nil)
  nnml-request-scan(nil "email")
  gnus-request-scan(nil (nnml "email" (nnml-directory "~/Mail/") (nnml-active-file "~/Mail/active") (nnml-newsgroups-file "~/Mail/newsgroups") (nnml-get-new-mail t)))
  gnus-read-active-file-1((nnml "email" (nnml-directory "~/Mail/") (nnml-active-file "~/Mail/active") (nnml-newsgroups-file "~/Mail/newsgroups") (nnml-get-new-mail t)) nil)
  gnus-read-active-file(nil nil)
  gnus-setup-news(nil nil nil)
  byte-code("..." [dont-connect did-connect gnus-group-quit gnus-run-hooks gnus-startup-hook gnus-make-newsrc-file gnus-startup-file gnus-current-startup-file gnus-slave gnus-use-dribble-file gnus-dribble-read-file gnus-use-grouplens bbb-login add-hook gnus-summary-mode-hook gnus-grouplens-mode gnus-setup-news nil level gnus-setup-news-hook gnus-start-draft-setup gnus-group-list-groups gnus-group-first-unread-group gnus-configure-windows group gnus-group-set-mode-line gnus-started-hook] 4)
  gnus-1(nil nil nil)
  gnus()
  ljz-gnus-startup()
  command-line-do-funcall("-f")
  command-line-1()
  command-line()
  normal-top-level()

--=-=-=



-- 
 Lloyd Zusman
 ljz@asfast.com

--=-=-=--