[PATCH for 0.91] (Was: Still having mail problems with version 0.88)

[Lloyd Zusman <ljz@asfast.com>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Lloyd Zusman <ljz@asfast.com> writes:
> 
> > In versions 0.8{6,7,8}, whenever new mail arrives I get this prompt
> > (followed by "Continue? "):
> > 
> >   Mail source error ((wrong-type-argument number-char-or-marker-p nil)). 
> > 
> > Here are all my `nnmail-*' and `mail-source-*' settings from my
> > `.gnus.el' file:
> 
> [...]
> 
> I didn't see anything in particular that looked wrong there, but could 
> you try removing some of the stuff to find out what setting triggers
> the bug?

Well, I actually had some time this weekend, so I ended up doing more
than that: I traced through the code in version 0.91 and finally
found what was causing the problem.  The following patch to pgnus-0.91
shows what I did to fix this.

As to why this problem occurred in the first place, I have no idea.
Perhaps it has something to do with the fact that I'm running XEmacs
version 21.1 under RedHat Linux 5.0.  The problem was absent in
pgnus-0.85 and it is present in all versions of pgnus I've tried from
version 0.86 through 0.91.

My patch could very well be a "band-aid" which covers up a more
fundamental problem ... ???

Any thoughts or ideas?



*** mail-source.el.orig	Sun Jul  4 15:49:34 1999
--- mail-source.el	Sun Jul  4 16:08:18 1999
***************
*** 344,356 ****
    "Fetcher for directory sources."
    (mail-source-bind (directory source)
      (let ((found 0)
! 	  (mail-source-string (format "directory:%s" path)))
        (dolist (file (directory-files
  		     path t (concat (regexp-quote suffix) "$")))
  	(when (and (file-regular-p file)
  		   (funcall predicate file)
  		   (mail-source-movemail file mail-source-crash-box))
! 	  (incf found (mail-source-callback callback file))))
        found)))
  
  (defun mail-source-fetch-pop (source callback)
--- 344,361 ----
    "Fetcher for directory sources."
    (mail-source-bind (directory source)
      (let ((found 0)
! 	  (mail-source-string (format "directory:%s" path))
! 	  result)
        (dolist (file (directory-files
  		     path t (concat (regexp-quote suffix) "$")))
  	(when (and (file-regular-p file)
  		   (funcall predicate file)
  		   (mail-source-movemail file mail-source-crash-box))
! 	  (setq result (mail-source-callback callback file))
! 	  ;;; Maybe this is some sort of XEmacs-ism???
! 	  (if result
! 	      (incf found result)
! 	    (incf found))))
        found)))
  
  (defun mail-source-fetch-pop (source callback)
***************
*** 412,422 ****
    "Fetcher for maildir sources."
    (mail-source-bind (maildir source)
      (let ((found 0)
! 	  (mail-source-string (format "maildir:%s" path)))
        (dolist (file (directory-files path t))
  	(when (and (file-regular-p file)
  		   (not (rename-file file mail-source-crash-box)))
! 	  (incf found (mail-source-callback callback file))))
        found)))
  
  (provide 'mail-source)
--- 417,432 ----
    "Fetcher for maildir sources."
    (mail-source-bind (maildir source)
      (let ((found 0)
! 	  (mail-source-string (format "maildir:%s" path))
! 	  result)
        (dolist (file (directory-files path t))
  	(when (and (file-regular-p file)
  		   (not (rename-file file mail-source-crash-box)))
! 	  (setq result (mail-source-callback callback file))
! 	  ;;; Maybe this is some sort of XEmacs-ism???
! 	  (if result
! 	      (incf found result)
! 	    (incf found))))
        found)))
  
  (provide 'mail-source)


-- 
 Lloyd Zusman
 ljz@asfast.com