Re: *Group* buffer disaster fix

[Lloyd Zusman <ljz@asfast.com>]

Hrvoje Niksic <hniksic@srce.hr> writes:

> This patch should work.  Lloyd, Lars, please comment.

OOPS ... I spoke too soon in my previous message.  With this
`mailcap-save-binary-file' patch you answered my question while I was
still typing it. :)

I have no further comments on the `mm-decode.el' patch, which seems
fine to me.  However, I do have a question about the `mailcap.el'
patch:

> --- mailcap.el.orig	Wed Oct 21 16:27:16 1998
> +++ mailcap.el	Wed Oct 21 16:27:30 1998
> @@ -272,11 +272,12 @@
>  
>  (defun mailcap-save-binary-file ()
>    (goto-char (point-min))
> -  (let ((file (read-file-name
> -	       "Filename to save as: "
> -	       (or mailcap-download-directory "~/")))
> -	(require-final-newline nil))
> -    (write-region (point-min) (point-max) file)
> +  (unwind-protect
> +      (let ((file (read-file-name
> +		   "Filename to save as: "
> +		   (or mailcap-download-directory "~/")))
> +	    (require-final-newline nil))
> +	(write-region (point-min) (point-max) file))
>      (kill-buffer (current-buffer))))
>  
>  (defun mailcap-maybe-eval ()

Why do we need to do a `kill-buffer' in this routine at all when
`(mapcar 'mm-destroy-part gnus-article-mime-handles)' is already
being done within `gnus-summary-exit' and `gnus-group-exit-hook'?

Furthermore, by doing the `kill-buffer' here, would we be breaking
something (perhaps in a subtle manner) when the `mapcar' stuff gets
done later on?  

On the other hand, if it's best keep the `kill-buffer' call here, then
if this routine fails or is aborted, perhaps we would need to catch
this case and explicitly remove the offending `* mm*' buffer reference
from `gnus-article-mime-handles' *before* the `mapcar' ever gets
called ... ???

-- 
 Lloyd Zusman
 ljz@asfast.com