From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/18020
Path: main.gmane.org!not-for-mail
From: Lloyd Zusman <ljz@asfast.com>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: *Group* buffer disaster fix
Date: 21 Oct 1998 12:25:55 -400
Sender: owner-ding@hpc.uh.edu
Message-ID: <ltiuhdlw4r.fsf@asfast.com>
References: <kign26qf0no.fsf@jagor.srce.hr>
NNTP-Posting-Host: coloc-standby.netfonds.no
X-Trace: main.gmane.org 1035156618 3971 80.91.224.250 (20 Oct 2002 23:30:18 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 20 Oct 2002 23:30:18 +0000 (UTC)
Cc: Hrvoje Niksic <hniksic@srce.hr>
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from fisher.math.uh.edu (fisher.math.uh.edu [129.7.128.35])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id MAA27047
	for <jason@mailhost.sclp.com>; Wed, 21 Oct 1998 12:26:47 -0400 (EDT)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by fisher.math.uh.edu (8.9.1/8.9.1) with ESMTP id LAB18012;
	Wed, 21 Oct 1998 11:26:34 -0500 (CDT)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 21 Oct 1998 11:26:32 -0500 (CDT)
Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [209.195.19.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id LAA26307 for <ding@hpc.uh.edu>; Wed, 21 Oct 1998 11:26:21 -0500 (CDT)
Original-Received: from ljz.asfast.net (gnus@ljz.asfast.net [205.230.75.82])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id MAA27022
	for <ding@gnus.org>; Wed, 21 Oct 1998 12:26:03 -0400 (EDT)
Original-Received: (from gnus@localhost)
	by ljz.asfast.net (8.8.7/8.8.7) id MAA14471;
	Wed, 21 Oct 1998 12:25:56 -0400
Original-To: ding@gnus.org
X-Face: "!ga1s|?LNLE3MeeeEYs(%LIl9q[xV9!<nimJxd1qyQRquvu5XTnZ:_5VE-G&4*
        EAuW"7oJLIXj'DWrJ0z@,FlwvD2PA@qhQ2R#zgsc14Klk;OSE'*;+l8p?0^nK7*
        X#0zg5wd^!M^2pg,M4Qd^{1viG;fa{}b.s[?g(x$45c]]=@'ZQ&]sPXl!u:hxBA
        v>j4#xf4!**BFW_ihlOb;:Slb>)vy>CJM<qjGM,/6C6\|{))YWm6}Q#?3om%n8
In-Reply-To: Hrvoje Niksic's message of "21 Oct 1998 16:30:03 +0200"
Original-Lines: 50
User-Agent: Gnus/5.070036 (Pterodactyl Gnus v0.36) XEmacs/20.4 (Emerald)
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:18020
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:18020

Hrvoje Niksic <hniksic@srce.hr> writes:

> This patch should work.  Lloyd, Lars, please comment.

OOPS ... I spoke too soon in my previous message.  With this
`mailcap-save-binary-file' patch you answered my question while I was
still typing it. :)

I have no further comments on the `mm-decode.el' patch, which seems
fine to me.  However, I do have a question about the `mailcap.el'
patch:

> --- mailcap.el.orig	Wed Oct 21 16:27:16 1998
> +++ mailcap.el	Wed Oct 21 16:27:30 1998
> @@ -272,11 +272,12 @@
>  
>  (defun mailcap-save-binary-file ()
>    (goto-char (point-min))
> -  (let ((file (read-file-name
> -	       "Filename to save as: "
> -	       (or mailcap-download-directory "~/")))
> -	(require-final-newline nil))
> -    (write-region (point-min) (point-max) file)
> +  (unwind-protect
> +      (let ((file (read-file-name
> +		   "Filename to save as: "
> +		   (or mailcap-download-directory "~/")))
> +	    (require-final-newline nil))
> +	(write-region (point-min) (point-max) file))
>      (kill-buffer (current-buffer))))
>  
>  (defun mailcap-maybe-eval ()

Why do we need to do a `kill-buffer' in this routine at all when
`(mapcar 'mm-destroy-part gnus-article-mime-handles)' is already
being done within `gnus-summary-exit' and `gnus-group-exit-hook'?

Furthermore, by doing the `kill-buffer' here, would we be breaking
something (perhaps in a subtle manner) when the `mapcar' stuff gets
done later on?  

On the other hand, if it's best keep the `kill-buffer' call here, then
if this routine fails or is aborted, perhaps we would need to catch
this case and explicitly remove the offending `* mm*' buffer reference
from `gnus-article-mime-handles' *before* the `mapcar' ever gets
called ... ???

-- 
 Lloyd Zusman
 ljz@asfast.com