Gnus development mailing list
 help / color / mirror / Atom feed
From: Lloyd Zusman <ljz@asfast.com>
Subject: Re: Procmail functionality
Date: 25 Jan 1999 01:01:23 -0500	[thread overview]
Message-ID: <ltlnirj3gs.fsf_-_@asfast.com> (raw)
In-Reply-To: Lars Magne Ingebrigtsen's message of "25 Jan 1999 06:00:39 +0100"

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> No, we don't want to regexp-quote the "$".  Or do you have files that
> are actually called "file.spool$"?

Well, of course you're right.  I had misunderstood the problem, but
there really *is* still an error in the call to `regexp-quote' that's
in `nnmail.el'.  I get an abort message that says that there are two
many arguments supplied to that function.  I believe that the patch
below is more correct and actually fixes this properly this time.

> > And even after applying these fixes, your suggestion still doesn't
> > quite work for me ... the email found the specified directory in files
> > with the specified suffix all goes into the crash box instead of the
> > appropriate mailboxes.
> 
> The mail is moved to the crash box, and then it's split from there
> into the groups.

Yes ... now I understand this better ... and once I fixed this
`regexp-quote' problem in the proper manner instead of how I did it
before, my mail is now correctly going to the intended email
newsgroups.  What was happening before was that everything in the
specified directory was ending up in the default `mail.misc'
newsgroup.  I erroneously thought that this had to do with the crash
box instead of its real cause (my incorrect patch).


Here's the patch fixing the incorrect call to `regexp-quote'.  Note in
the original that "$" is erroneously being passed as the second
argument to `regexp-quote' ...


*** nnmail.el.orig      Mon Jan 25 00:39:16 1999
--- nnmail.el   Mon Jan 25 00:40:06 1999
***************
*** 508,514 ****
    (if (eq (car source) 'directory)
        (let ((file (file-name-nondirectory file)))
        (mail-source-bind directory source
!         (if (string-match (concat (regexp-quote suffix "$") file))
              (substring file 0 (match-beginning 0))
            nil)))
      nil))
--- 508,514 ----
    (if (eq (car source) 'directory)
        (let ((file (file-name-nondirectory file)))
        (mail-source-bind directory source
!         (if (string-match (concat (regexp-quote suffix) "$") file)
              (substring file 0 (match-beginning 0))
            nil)))
      nil))

-- 
 Lloyd Zusman
 ljz@asfast.com


  reply	other threads:[~1999-01-25  6:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-01-23 14:28 Pterodactyl Gnus v0.73 is released Lars Magne Ingebrigtsen
1999-01-23 15:56 ` Kai Haberzettl
1999-01-23 16:01   ` Lars Magne Ingebrigtsen
1999-01-25  0:02 ` Lloyd Zusman
1999-01-25  0:09   ` Lloyd Zusman
1999-01-25  2:53   ` Lars Magne Ingebrigtsen
1999-01-25  4:41     ` Procmail functionality (Was: Pterodactyl Gnus v0.73 is released) Lloyd Zusman
1999-01-25  5:00       ` Lars Magne Ingebrigtsen
1999-01-25  6:01         ` Lloyd Zusman [this message]
1999-01-25 11:07           ` Procmail functionality Lars Magne Ingebrigtsen
1999-01-27 13:47     ` Pterodactyl Gnus v0.73 is released Michael Harnois
1999-01-27 14:16       ` Lars Magne Ingebrigtsen
1999-01-27 21:06         ` Michael Harnois
1999-01-28  7:22           ` Lars Magne Ingebrigtsen
1999-01-28 14:21             ` Michael Harnois
1999-01-28 18:05               ` Hrvoje Niksic
1999-01-28 23:54                 ` Michael Harnois
1999-02-01 21:02                   ` Lars Magne Ingebrigtsen
1999-02-02 14:35                     ` Michael Harnois
1999-02-02 15:34                       ` Michael Harnois
1999-02-02 21:37                       ` Lars Magne Ingebrigtsen
1999-02-03  0:22                         ` Michael Harnois
1999-02-03  1:29                           ` Lars Magne Ingebrigtsen
1999-02-03  3:52                             ` Michael Harnois
1999-02-03 15:06                               ` Lars Magne Ingebrigtsen
1999-02-06 19:37                                 ` Michael Harnois
1999-01-25 14:43 ` Michael Welsh Duggan
1999-01-26  4:24   ` Lars Magne Ingebrigtsen
1999-01-26 14:59     ` Michael Welsh Duggan
1999-01-27  4:49       ` Lars Magne Ingebrigtsen
1999-01-27 18:16         ` Michael Welsh Duggan
1999-01-27 21:06           ` Michael Welsh Duggan
1999-01-28  7:17             ` Lars Magne Ingebrigtsen
1999-01-28 18:06               ` Hrvoje Niksic
1999-01-28 19:55                 ` Lars Magne Ingebrigtsen
1999-01-28 23:06                   ` Hrvoje Niksic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ltlnirj3gs.fsf_-_@asfast.com \
    --to=ljz@asfast.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).