Re: I fixed it, but I need Lars ... (Was: *Group* buffer disappearance)

[Lloyd Zusman <ljz@asfast.com>]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Lloyd Zusman <ljz@asfast.com> writes:
> 
> > Note that the problem had to do with the `(current-buffer)' call
> > immediately following `(funcall method)'.  When the method is
> > `mailcap-save-binary-file', this method causes the current buffer to
> > change (see below for a listing of `mailcap-save-binary-file').
> > Therefore, we need to use `cur' here instead of `(current-buffer)',
> > just like in the rest of this routine (`mm-display-external').
> 
> Killing `cur' doesn't look right.  The buffer you really want to kill
> is the "*mm*" buffer, not the current buffer before that.

Yes.  This seems correct, and it works under my test scenario.

> [ ... correct patch that appears elsewhere snipped ... ]

> I used `unwind-protect' so that if a signal occurs during the method,
> the undisplayer still gets set.
> 
> (What I don't understand is why the undisplayer method still doesn't
> get *called* when I press C-g.)

`unwind-protect' alone doesn't trap `C-g' signals.  I believe that you
have to make use of `condition-case' if you want to trap `C-g'.

I have to run to a meeting in a few minutes.  When I come back, I'll
redo your patch using `condition-case' and post it here.

> > Note that the final line of this routine kills the current buffer,
> > However, when this routine is being called from within
> > `mm-display-external', the current buffer is one of the ` *mm*'
> > buffers.  Do we really want this ` *mm*' buffer to be killed as part
> > of the routine which saves the binary file?
> 
> Yes.  The *mm* buffer is temporary stuff used for decoding MIME.  We
> don't want buffers with random binary contents to stick around, I
> think.

But by storing the name of the ` *mm*' buffer in the data structure
managed by `mm-handle-set-undisplayer', we're assuring that this
` *mm*' buffer gets deleted later.  Prior to this, should the buffer get
killed within the `mailcap-save-binary-file' method?  Would this
somehow cause problems later?

-- 
 Lloyd Zusman
 ljz@asfast.com