Re: [PATCH for 0.91] (Was: Still having mail problems with version 0.88)

[Lloyd Zusman <ljz@asfast.com>]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Lloyd Zusman <ljz@asfast.com> writes:
> 
> > Well, I actually had some time this weekend, so I ended up doing
> > more than that: I traced through the code in version 0.91 and
> > finally found what was causing the problem.  The following patch to
> > pgnus-0.91 shows what I did to fix this.
> 
> Judging your patch, it appears that `mail-source-callback' can return
> nil, right?

The fact that it returned nil is indeed what broke my code, but I'm
wondering if this is proper.  I'm wondering if perhaps the fact that
it returned nil is actually a symptom of a deeper problem.

What do any of you folks think?


> Then I guess you could modify the code like this:
> 
> - 	  (incf found (mail-source-callback callback file))))
> + 	  (incf found (or (mail-source-callback callback file) 0))))

Well, the final line would probably have to be this, instead ...

> + 	  (incf found (or (mail-source-callback callback file) 1))))

... since `incf' defaults to treating its final argument as a `1' if
it's missing.

But otherwise, I agree with your suggestion.

> [ ... ]


-- 
 Lloyd Zusman
 ljz@asfast.com