Re: hackernews & gnus-summary-browse-url

[Sam Steingold <sds@gnu.org>]

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2022-03-09 13:04:29 +0100]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> If you use it yourself, would you mind if I apply this patch?
>
> [...]
>
>> +  "v" #'gnus-summary-browse-all-urls
>
> I'm not sure that's generally useful enough to have as its own
> command -- people will want to open different subsets of URLs in these
> cases, and you kinda have to write some code for that.

Right, but sometimes you want to open _all_ URLs, and this is a simple
way.
I can add bells and whistles (e.g., open _matching_ URLs), but that's an
overkill for now.

>> -(defun gnus-summary-browse-url (&optional external)
>> +(defun gnus-summary-browse-url (&optional _external)
>>    "Scan the current article body for links, and offer to browse them.
>>
>>  Links are opened using `browse-url' unless a prefix argument is
>> -given: Then `browse-url-secondary-browser-function' is used instead.
>> +given: then `browse-url-secondary-browser-function' is used instead.
>
> And why are you removing the EXTERNAL logic?

I am NOT!
I am merely moving this logic to browse-url-button-open-url where it has
been since it has been introduced!

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://jij.org https://memri.org https://www.dhimmitude.org
There are two ways to win an argument with a woman.  Neither works.