From: Stephen Zander <srz@mckesson.com>
Cc: ding@gnus.org
Subject: Re: (Missed) threaded mail entries
Date: Thu, 18 Dec 1997 14:01:43 -0800 [thread overview]
Message-ID: <m0xio0l-00000PC@debian> (raw)
In-Reply-To: Your message of "Thu, 18 Dec 1997 16:38:35 EST." <199712182138.QAA27520@alderaan.gsfc.nasa.gov>
"Edward J. Sabol" wrote:
> Please post this patch!
Sure, here you go. This patch just makes 'gnus-get-newsgroup-headers' use
the same rules regardless of the field being a References or an In-Reply-To.
Specifically, this fixes a problem with mailers that use In-Reply-To lines
like the following:
In-reply-to: Message from Ben Pfaff <pfaffben@pilot.msu.edu>
of 13 Dec 1997 10:15:57 EST. <87oh2lclzm.fsf@pfaffben.user.msu.edu>
The current code would incorrectly assume the reference was
<pfaffben@pilot.msu.edu>.
--- gnus-sum.el.orig Mon Dec 15 23:26:41 1997
+++ gnus-sum.el Thu Dec 18 13:48:45 1997
@@ -4113,7 +4113,7 @@
(subst-char-in-region (point-min) (point-max) ?\t ? t)
(run-hooks 'gnus-parse-headers-hook)
(let ((case-fold-search t)
- in-reply-to header p lines)
+ header p lines)
(goto-char (point-min))
;; Search to the beginning of the next header. Error messages
;; do not begin with 2 or 3.
@@ -4166,7 +4166,11 @@
;; References.
(progn
(goto-char p)
- (if (search-forward "\nreferences: " nil t)
+ ;; Get the references from the in-reply-to header if there
+ ;; were no references and the in-reply-to header looks
+ ;; promising.
+ (if (or (search-forward "\nreferences: " nil t)
+ (search-forward "\nin-reply-to: " nil t))
(progn
(setq end (point))
(prog1
@@ -4180,15 +4184,7 @@
(progn
(search-backward "<" end t)
(point))))))
- ;; Get the references from the in-reply-to header if there
- ;; were no references and the in-reply-to header looks
- ;; promising.
- (if (and (search-forward "\nin-reply-to: " nil t)
- (setq in-reply-to (nnheader-header-value))
- (string-match "<[^>]+>" in-reply-to))
- (setq ref (substring in-reply-to (match-beginning 0)
- (match-end 0)))
- (setq ref nil))))
+ (setq ref nil)))
;; Chars.
0
;; Lines.
Stephen
---
"Normality is a statistical illusion." -- me
next parent reply other threads:[~1997-12-18 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <199712182138.QAA27520@alderaan.gsfc.nasa.gov>
1997-12-18 22:01 ` Stephen Zander [this message]
1997-12-19 20:43 ` Lars Magne Ingebrigtsen
1997-12-23 19:01 ` Stephen Zander
1997-12-17 7:45 Stephen Zander
1997-12-17 10:12 ` Kai Grossjohann
1997-12-18 21:24 ` Stephen Zander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0xio0l-00000PC@debian \
--to=srz@mckesson.com \
--cc=ding@gnus.org \
--cc=stephen.zander@interlock.mckesson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).