From: dsg@mitre.org (David S. Goldberg)
Subject: Re: PATCH: Browse URLs in new window
Date: 02 Dec 1999 16:12:11 -0500 [thread overview]
Message-ID: <m1bso1l11zo.fsf@blackbird.mitre.org> (raw)
In-Reply-To: Lars Magne Ingebrigtsen's message of "01 Dec 1999 21:51:33 +0100"
> Daniel Pittman <daniel@danann.net> writes:
>> The problem is, at least with XEmacs 21.[12], that pGnus calls the
>> value of 'browse-url-browser-function' directly rather than through
>> the 'browse-url' function. For some reason, unbeknownst to me.
> This has now been fixed.
It still doesn't work for me. I wonder if it's a problem with the
browse-url distributed with XEmacs 21.1.7? Near as I can tell I've
got the latest mail-lib package which includes browse-url. Also,
based on the CVS update I did a little while ago, there's one thing
you missed fixing:
in gnus-art.el I still see:
(defun gnus-button-embedded-url (address)
"Browse ADDRESS."
;; In Emacs 20, `browse-url-browser-function' may be an alist.
(if (listp browse-url-browser-function)
(browse-url (gnus-strip-whitespace address))
(funcall browse-url-browser-function (gnus-strip-whitespace address))))
Anyway, my personal fix for this remains:
(defadvice browse-url (around always-do-new-window (url &optional nw) activate)
(ad-set-arg 1 t)
ad-do-it)
--
Dave Goldberg
Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730
Phone: 781-271-3887
Email: dsg@mitre.org
next prev parent reply other threads:[~1999-12-02 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-24 20:46 Peter von der Ahé
1999-11-25 0:33 ` Daniel Neri
1999-11-25 1:51 ` Daniel Pittman
1999-12-01 20:51 ` Lars Magne Ingebrigtsen
1999-12-02 21:12 ` David S. Goldberg [this message]
1999-12-03 0:27 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bso1l11zo.fsf@blackbird.mitre.org \
--to=dsg@mitre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).