From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/27570 Path: main.gmane.org!not-for-mail From: dsg@mitre.org (David S. Goldberg) Newsgroups: gmane.emacs.gnus.general Subject: Re: PATCH: Browse URLs in new window Date: 02 Dec 1999 16:12:11 -0500 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87puwz5s1o.fsf@nowhere.mayonnaise.net> <874sebxrrf.fsf@inanna.danann.net> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035164573 25241 80.91.224.250 (21 Oct 2002 01:42:53 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:42:53 +0000 (UTC) Return-Path: Original-Received: from bart.math.uh.edu (bart.math.uh.edu [129.7.128.48]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id QAA14310 for ; Thu, 2 Dec 1999 16:13:44 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by bart.math.uh.edu (8.9.1/8.9.1) with ESMTP id PAB06942; Thu, 2 Dec 1999 15:12:46 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 02 Dec 1999 15:12:56 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id PAA15274 for ; Thu, 2 Dec 1999 15:12:45 -0600 (CST) Original-Received: from linus.mitre.org (linus.mitre.org [129.83.10.1]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id QAA14288 for ; Thu, 2 Dec 1999 16:12:14 -0500 (EST) Original-Received: from blackbird.mitre.org (blackbird [129.83.65.14]) by linus.mitre.org (8.8.7/8.8.7) with ESMTP id QAA04389 for ; Thu, 2 Dec 1999 16:12:13 -0500 (EST) Original-Received: (from dsg@localhost) by blackbird.mitre.org (8.8.7/8.8.7) id QAA09544; Thu, 2 Dec 1999 16:12:12 -0500 (EST) Mail-Copies-To: never Original-To: The Gnus Mailing List X-Face: GUaHTH@nS>[7,ME@-gYZ4#Wl{z"99k@[[Y8AcP0x1paqu.,z9,XSV1WI>{q3f6^e5(zrit <4fV&VHhmE`uidRqtmG27;si9&r;#KSF~E#$%W8w(xdp)H4tW=\2XOk~3=@oGqqpj;m4xf Ow;y26396&,34@9#~4;@*S;E0cq"LM9N(us4P%F(Nxis'Vvfm9?KufH;:Q$dMa-QWGLR&K d0`LJZE8xb*>^yN>b]_NcU:E=Zn\1=#/(OS2 In-Reply-To: Lars Magne Ingebrigtsen's message of "01 Dec 1999 21:51:33 +0100" Original-Lines: 33 User-Agent: Gnus/5.08 (Gnus v5.8.0) XEmacs/21.1 (Biscayne) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:27570 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:27570 > Daniel Pittman writes: >> The problem is, at least with XEmacs 21.[12], that pGnus calls the >> value of 'browse-url-browser-function' directly rather than through >> the 'browse-url' function. For some reason, unbeknownst to me. > This has now been fixed. It still doesn't work for me. I wonder if it's a problem with the browse-url distributed with XEmacs 21.1.7? Near as I can tell I've got the latest mail-lib package which includes browse-url. Also, based on the CVS update I did a little while ago, there's one thing you missed fixing: in gnus-art.el I still see: (defun gnus-button-embedded-url (address) "Browse ADDRESS." ;; In Emacs 20, `browse-url-browser-function' may be an alist. (if (listp browse-url-browser-function) (browse-url (gnus-strip-whitespace address)) (funcall browse-url-browser-function (gnus-strip-whitespace address)))) Anyway, my personal fix for this remains: (defadvice browse-url (around always-do-new-window (url &optional nw) activate) (ad-set-arg 1 t) ad-do-it) -- Dave Goldberg Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730 Phone: 781-271-3887 Email: dsg@mitre.org