nnml still tries to find a mail-source for every group

nnml still tries to find a mail-source for every group

[David S. Goldberg]

OK, since everyone else seems to think this is now fixed (and it is
for me for nnimap), why is it that if I run gnus-no-server, or do a
<Number> g in the *Group* buffer after running gnus that all my level
2 groups get one of the 

nnml: Reading incoming mail from directory...
nnml: Reading incoming mail (no new mail)...done

pairs of lines.  I've tried changing the select method for each group
in .newsrc.eld from (nnml "") to "nnml:" but no luck.  I'm running the
latest (well, as of sometime this morning EST) CVS snapshot.  Any
clues as to what I'm doing wrong, or how I could help debug it, would
be greatly appreciated.
-- 
Dave Goldberg
Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730
Phone: 781-271-3887
Email: dsg@mitre.org

Re: nnml still tries to find a mail-source for every group

[David S. Goldberg]

For now this bit of advice lets me operate the way I want.  I can
press 2 l and only level 1 and 2 (e.g. mail) groups and subsequent l's
will keep the default listing at level 2.  Since g is now fast and 2 g
(and permanent levels and gnus-no-server) are now slow for me I just
use g and everything is happy.  I'd still like to figure out how to
debug why my nnml groups are all treated like separate servers,
though.  The server buffer only shows one server for them all.

(defadvice gnus-group-list-groups (around set-default-list-level activate)
  ad-do-it
  (if (ad-get-arg 0) (setq gnus-group-default-list-level (ad-get-arg 0))))

-- 
Dave Goldberg (G022)
dsg@mitre.org
MS B325
Bedford x3887

Re: nnml still tries to find a mail-source for every group

[Simon Josefsson]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

David S. Goldberg <dsg@mitre.org> writes:

> OK, since everyone else seems to think this is now fixed (and it is
> for me for nnimap), why is it that if I run gnus-no-server, or do a
> <Number> g in the *Group* buffer after running gnus that all my level
> 2 groups get one of the 
> 
> nnml: Reading incoming mail from directory...
> nnml: Reading incoming mail (no new mail)...done
> 
> pairs of lines.

This is because `nnml' doesn't support `nnml-retrieve-groups' so the
code I added which make partial mail checking fast for nnimap isn't
used for nnml. Gnus will then scan the backend of each of your nnml
groups on level 2 or lower.

This patch try to make sure methods are only scanned once. I haven't
tested it, please try it and tell us if it works.

1999-11-20  Simon Josefsson  <jas@pdc.kth.se>

	* gnus-start.el (gnus-get-unread-articles): Scan each method only
	once.


[-- Attachment #2: Type: text/plain, Size: 993 bytes --]

Index: gnus-start.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-start.el,v
retrieving revision 5.40
diff -w -u -u -w -r5.40 gnus-start.el
--- gnus-start.el	1999/11/17 00:30:44	5.40
+++ gnus-start.el	1999/11/19 23:32:36
@@ -1498,7 +1498,7 @@
 		  gnus-activate-foreign-newsgroups)
 		 (t 0))
 	   level))
-	 info group active method retrievegroups)
+	 scanned-methods info group active method retrievegroups)
     (gnus-message 5 "Checking new news...")
 
     (while newsrc
@@ -1542,7 +1542,10 @@
 		  (setcdr (assoc method retrievegroups)
 			  (cons group (cdr (assoc method retrievegroups))))
 		(push (list method group) retrievegroups))
+	    (if (member method scanned-methods)
+		(setq active (gnus-activate-group group))
 	  (setq active (gnus-activate-group group 'scan))
+	      (push method scanned-methods))
 	    (inline (gnus-close-group group))))))
 
       ;; Get the number of unread articles in the group.

Re: nnml still tries to find a mail-source for every group

[David S. Goldberg]

This morning (22 Nov 1999 approximately 0914 EST) I did a CVS update,
then read Simon's message, and applied his patch.  It works!  I set
gnus-group-use-permanent-levels to 3 (initially) and then 2 g, 1 g et
al to read nnml groups no longer results in a scan for each group.

Thanks Simon!
-- 
Dave Goldberg
Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730
Phone: 781-271-3887
Email: dsg@mitre.org

Re: nnml still tries to find a mail-source for every group

[David S. Goldberg]

Well, it looks like I was a bit too enthusiastic.  It works at startup
(I suppose the fact that the mods were only to gnus-start.el should
have been a clue :-) but subsequent calls to 1 g and/or 2 g, while
fast, don't actually incorporate mail.  I have to jump to the groups
in question and M-g on them.  I suppose this is a side effect of my
using procmail and each group having it's own mail-source file within
the incoming directory.
-- 
Dave Goldberg (G022)
dsg@mitre.org
MS B325
Bedford x3887

Re: nnml still tries to find a mail-source for every group

[David S. Goldberg]

Yet another followup (sorry): if I get rid of permanent levels, g
works as desired though <number> g still doesn't incorporate new mail.
-- 
Dave Goldberg (G022)
dsg@mitre.org
MS B325
Bedford x3887

Re: nnml still tries to find a mail-source for every group

[Randal L. Schwartz]

>>>>> "David" == David S Goldberg <dsg@mitre.org> writes:

David> Yet another followup (sorry): if I get rid of permanent levels, g
David> works as desired though <number> g still doesn't incorporate new mail.

Have you tried "gnus-no-server" and then g?  That was giving me a
zillion messages with 0.97 as well.

My experience:

gnus then g, correct behavior
gnus then 1g, bad messages
gnus-no-server then g, bad messages
gnus-no-server then 1g, bad messages

which of those are still broken?

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

Re: nnml still tries to find a mail-source for every group

[David S. Goldberg]

> Have you tried "gnus-no-server" and then g?  That was giving me a
> zillion messages with 0.97 as well.

I have now :-) I thought that all gnus-no-server does is set
gnus-group-use-permanent-levels, but apparently it's just a bit more
complicated.  It sets it local to the group buffer instead of
globally.  I'm not sure if that's why <number> g wasn't working for me
(e.g. no more zillions of messages, but no mail either :-) but things
work exactly as I want if I do gnus-no-server.  There is one
difference between current behavior and what I had before, though.  In
particular 2 g only gets mail for level 2 groups.  It used to get mail
for both 1 and 2.  So I have to do a 1 g for level 1 stuff and 2 g for
level 2 stuff.  But that's not much of an issue for the way I operate
anyway.

So, with the latest CVS and Simon's patch, gnus-no-server is working
the "right" way with regard to nnml groups.
-- 
Dave Goldberg
Post: The Mitre Corporation\MS B325\202 Burlington Rd.\Bedford, MA 01730
Phone: 781-271-3887
Email: dsg@mitre.org

Re: nnml still tries to find a mail-source for every group

[Simon Josefsson]

David S. Goldberg <dsg@mitre.org> writes:

> There is one difference between current behavior and what I had
> before, though.  In particular 2 g only gets mail for level 2
> groups.  It used to get mail for both 1 and 2.  So I have to do a 1
> g for level 1 stuff and 2 g for level 2 stuff.

I believe the first is the expected behaviour, and I can't see how my
patch could change that. You do have nnml groups on both level 1 and
2? Are you sure it's my patch that causes this change?

> So, with the latest CVS and Simon's patch, gnus-no-server is working
> the "right" way with regard to nnml groups.

Lars, should I commit it?

diff -w -u -r5.41 gnus-start.el
--- gnus-start.el	1999/11/20 03:55:47	5.41
+++ gnus-start.el	1999/11/22 18:12:29
@@ -1498,7 +1498,7 @@
 		  gnus-activate-foreign-newsgroups)
 		 (t 0))
 	   level))
-	 info group active method retrievegroups)
+	 scanned-methods info group active method retrievegroups)
     (gnus-message 5 "Checking new news...")
 
     (while newsrc
@@ -1542,7 +1542,10 @@
 		  (setcdr (assoc method retrievegroups)
 			  (cons group (cdr (assoc method retrievegroups))))
 		(push (list method group) retrievegroups))
+	    (if (member method scanned-methods)
+		(setq active (gnus-activate-group group))
 	  (setq active (gnus-activate-group group 'scan))
+	      (push method scanned-methods))
 	    (inline (gnus-close-group group))))))
 
       ;; Get the number of unread articles in the group.

Re: nnml still tries to find a mail-source for every group

[Lars Magne Ingebrigtsen]

Simon Josefsson <jas@pdc.kth.se> writes:

> > So, with the latest CVS and Simon's patch, gnus-no-server is working
> > the "right" way with regard to nnml groups.
> 
> Lars, should I commit it?

Please do.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen