Gnus development mailing list
 help / color / mirror / Atom feed
From: david.goldberg6@verizon.net (David S. Goldberg)
Subject: gnus-summary-limit-to-author
Date: Wed, 28 Nov 2001 11:08:43 -0500	[thread overview]
Message-ID: <m1bzo5627zo.fsf@blackbird.mitre.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Did a cvs update about four hours ago and found the subject function
to throw an error on incorrect number of arguments.  Looks like it
happened in the most recent change to gnus-sum.el based on a cvs diff.
The interactive function was changed to allow for both include and
exclude by means of the prefix arg, but the resulting call tries to
set up three arguments, but gnus-summary-limit-to-author only has one.
The attached patch fixes the incorrect argument backtrace and I think
provides the intended previous behavior of / a including the ability
to exclude if current-prefix-arg.
-- 
Dave Goldberg
david.goldberg6@verizon.net

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1113 bytes --]

Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 6.123
diff -u -r6.123 gnus-sum.el
--- lisp/gnus-sum.el    2001/11/25 14:57:22     6.123
+++ lisp/gnus-sum.el    2001/11/28 16:06:22
@@ -6860,7 +6860,7 @@
          (gnus-summary-limit articles))
       (gnus-summary-position-point))))
 
-(defun gnus-summary-limit-to-author (from)
+(defun gnus-summary-limit-to-author (from &optional header not-matching)
   "Limit the summary buffer to articles that have authors that match a regexp.
 If NOT-MATCHING, excluding articles that have authors that match a regexp."
   (interactive 
@@ -6868,7 +6868,7 @@
                          "Exclude author (regexp): "
                        "Limit to author (regexp): ")) 
         nil current-prefix-arg))
-  (gnus-summary-limit-to-subject from "from"))
+  (gnus-summary-limit-to-subject from "from" not-matching))
 
 (defun gnus-summary-limit-to-age (age &optional younger-p)
   "Limit the summary buffer to articles that are older than (or equal) AGE days.

             reply	other threads:[~2001-11-28 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-28 16:08 David S. Goldberg [this message]
2001-11-28 16:32 ` gnus-summary-limit-to-author ShengHuo ZHU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1bzo5627zo.fsf@blackbird.mitre.org \
    --to=david.goldberg6@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).