Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs

[Dave Goldberg <david.goldberg6@verizon.net>]

>>>>> On Wed, 14 Feb 2007 09:29:10 +0900, Katsumi Yamaoka <yamaoka@jpl.org> said:

>>>>> In <m1ps8dg7ne.fsf@davestoy.homelinux.org> Dave Goldberg wrote:

>>>>>>> On Tue, 13 Feb 2007 21:46:09 +0900, Katsumi Yamaoka <yamaoka@jpl.org> said:

>>> I seem to have solved this problem.  Could you try it?

>> It's odd.  When working on my linux machine at home I get the same messages:

>> Fontifying *wide reply to Katsumi Yamaoka on ding@gnus.org*...
>> Fontifying *wide reply to Katsumi Yamaoka on ding@gnus.org*... done.

> Those were issued when you typed `S W' (or similar) to start a
> reply to me, and the fontification was successful (because of
> the last `done').  The next ones were issued when you started
> another mail, but fontification was not successful.  Am I right?

Nope, all of them come when I run `F' or `S W'.  I'm not doing another
mail.

>> Fontifying mail to ding@gnus.org...
>> Fontifying mail to ding@gnus.org... (regexps)....
>> Fontifying mail to ding@gnus.org... (regexps)........
>> Fontifying mail to ding@gnus.org... (regexps)........
>> Fontifying mail to ding@gnus.org... (regexps).........
>> Fontifying mail to ding@gnus.org... (regexps)..........
>> Fontifying mail to ding@gnus.org... (regexps).............
>> Fontifying mail to ding@gnus.org... (regexps)..............
>> Fontifying mail to ding@gnus.org... (regexps)...............
>> Fontifying mail to ding@gnus.org... (regexps)...............
>> Fontifying mail to ding@gnus.org... (regexps)...............
>> Fontifying mail to ding@gnus.org... (regexps)...............
>> Fontifying mail to ding@gnus.org... (regexps)...............
>> Fontifying mail to ding@gnus.org... (regexps)................

> `font-lock-fontify-keywords-region' issued those messages using:

>   (progress-feedback-with-label 'font-lock
>                                 "Fontifying %s... (regexps)"
>                                 progress bufname))

> But, in message.el there seems to be no function to make the
> buffer name which is not surrounded with "*...*".  How do you
> start a "mail to ding@gnus.org"?  All those questions might be
> fruitless, though.

No idea.  I don't think I'm doing anything odd.

>> Fontifying mail to ding@gnus.org... aborted.aborted.

> Well, I might have misunderstood this message.  The reason the
> fontification was aborted was not because you typed `C-g', was
> it?  If so, it was terminated by an error and we can use the
> debugger.  To do that, copy lisp/font-lock.el to the tmp
> directory, apply the patch attached in this message, load the
> patched font-lock.el, set `debug-on-error' to t, and start a
> reply.

Nope, not a C-g.  So I ran the patched font-lock.el and here's the
resulting backtrace (from this very reply, in fact):

Debugger entered--Lisp error: (void-function line-beginning-position)
  line-beginning-position()
  gnus-message-search-citation-line(4031)
  funcall(gnus-message-search-citation-line 4031)
  (if (stringp matcher) (re-search-forward matcher end t) (funcall matcher end))
  (and (< (point) end) (if (stringp matcher) (re-search-forward matcher end t) (funcall matcher end)))
  (while (and (< ... end) (if ... ... ...)) (setq progress (+ ... ... 5)) (when (and loudly ...) (progress-feedback-with-label ... "Fontifying %s... (regexps)" progress bufname)) (setq old-progress progress) (setq highlights (cdr keyword)) (while highlights (if ... ... ...) (setq highlights ...)))
  (while keywords (setq keyword (car keywords) matcher (car keyword)) (goto-char start) (while (and ... ...) (setq progress ...) (when ... ...) (setq old-progress progress) (setq highlights ...) (while highlights ... ...)) (setq iter (1+ iter)) (setq keywords (cdr keywords)))
  (let* ((case-fold-search font-lock-keywords-case-fold-search) (keywords ...) (bufname ...) (progress 5) (old-progress 5) (iter 0) (nkeywords ...) keyword matcher highlights) (while keywords (setq keyword ... matcher ...) (goto-char start) (while ... ... ... ... ... ...) (setq iter ...) (setq keywords ...)))
  (let ((loudly ...)) (unless (eq ... t) (setq font-lock-keywords ...)) (let* (... ... ... ... ... ... ... keyword matcher highlights) (while keywords ... ... ... ... ...)) (if loudly (progress-feedback-with-label ... "Fontifying %s... " 100 ...)))
  font-lock-fontify-keywords-region(1 4031 nil)
  (progn (if font-lock-syntax-table (set-syntax-table font-lock-syntax-table)) (font-lock-unfontify-region beg end) (when font-lock-syntactic-keywords (font-lock-fontify-syntactic-keywords-region beg end)) (unless font-lock-keywords-only (font-lock-fontify-syntactically-region beg end loudly)) (font-lock-fontify-keywords-region beg end loudly))
  (unwind-protect (progn (if font-lock-syntax-table ...) (font-lock-unfontify-region beg end) (when font-lock-syntactic-keywords ...) (unless font-lock-keywords-only ...) (font-lock-fontify-keywords-region beg end loudly)) (set-syntax-table old-syntax-table) (and (not modified) (buffer-modified-p) (set-buffer-modified-p nil)))
  (let ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (old-syntax-table ...) buffer-file-name buffer-file-truename) (unwind-protect (progn ... ... ... ... ...) (set-syntax-table old-syntax-table) (and ... ... ...)))
  font-lock-default-fontify-region(1 4031 nil)
  funcall(font-lock-default-fontify-region 1 4031 nil)
  font-lock-fontify-region(1 4031)
  (save-excursion (font-lock-fontify-region (point-min) (point-max)))
  (let ((was-on font-lock-mode) (font-lock-verbose ...) (font-lock-message-threshold 0) (aborted nil)) (or was-on (font-lock-mode 1)) (font-lock-unfontify-region (point-min) (point-max) t) (save-excursion (font-lock-fontify-region ... ...)) (or was-on (let ... ...)) (set (make-local-variable ...) t) (when (and aborted font-lock-verbose) (progress-feedback-with-label ... "Fontifying %s... aborted." ... ...)))
  (save-restriction (widen) (let (... ... ... ...) (or was-on ...) (font-lock-unfontify-region ... ... t) (save-excursion ...) (or was-on ...) (set ... t) (when ... ...)) (run-hooks (quote font-lock-after-fontify-buffer-hook)))
  font-lock-default-fontify-buffer()
  funcall(font-lock-default-fontify-buffer)
  (let ((font-lock-verbose ...)) (funcall font-lock-fontify-buffer-function))
  font-lock-fontify-buffer()
  gnus-message-citation-mode(1)
  byte-code("..." [gnus-setup-message-winconf mbl mbl1 gnus-setup-message-group gnus-setup-message-article mml-buffer-list gnus-inews-add-send-actions reply-yank reply make-local-variable gnus-message-group-art gnus-newsgroup-name gnus-message-citation-mode 1 gnus-run-hooks gnus-message-setup-hook message-mode gnus-make-local-hook kill-buffer-hook change-major-mode-hook add-hook mml-destroy-buffers nil t gnus-setup-message-buffer yank gnus-setup-yanked-articles gnus-message-buffer gnus-message-highlight-citation major-mode] 6)
  gnus-summary-reply((3557) t)
  gnus-summary-reply-with-original(nil t)
  gnus-summary-wide-reply-with-original(nil)
  call-interactively(gnus-summary-wide-reply-with-original)

Thanks,
-- 
Dave Goldberg
david.goldberg6@verizon.net