From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64358 Path: news.gmane.org!not-for-mail From: Dave Goldberg Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs Date: Wed, 28 Feb 2007 16:14:06 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1172697323 10665 80.91.229.12 (28 Feb 2007 21:15:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2007 21:15:23 +0000 (UTC) Cc: ding@gnus.org To: Katsumi Yamaoka Original-X-From: ding-owner+M12882@lists.math.uh.edu Wed Feb 28 22:15:13 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1HMW8l-0003RC-Kd for ding-account@gmane.org; Wed, 28 Feb 2007 22:15:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1HMW8K-0002C6-4u; Wed, 28 Feb 2007 15:14:44 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1HMW8I-0002Bp-4g for ding@lists.math.uh.edu; Wed, 28 Feb 2007 15:14:42 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1HMW8B-0002QL-UQ for ding@lists.math.uh.edu; Wed, 28 Feb 2007 15:14:42 -0600 Original-Received: from vms046pub.verizon.net ([206.46.252.46]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1HMW89-0007nu-00 for ; Wed, 28 Feb 2007 22:14:34 +0100 Original-Received: from davestoy.homelinux.org.verizon.net ([71.174.120.12]) by vms046.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JE600GTOYZIWXCM@vms046.mailsrvcs.net> for ding@gnus.org; Wed, 28 Feb 2007 15:14:29 -0600 (CST) X-Face: GUaHTH@nS>[7,ME@-gYZ4#Wl{z"99k@[[Y8AcP0x1paqu.,z9,XSV1WI>{q3f6^e5(zrit <4fV&VHhmE`uidRqtmG27;si9&r;#KSF~E#$%W8w(xdp)H4tW=\2XOk~3=@oGqqpj;m4xf Ow;y26396&,34@9#~4;@*S;E0cq"LM9N(us4P%F(Nxis'Vvfm9?KufH;:Q$dMa-QWGLR&K d0`LJZE8xb*>^yN>b]_NcU:E=Zn\1=#/(OS2 In-reply-to: (Katsumi Yamaoka's message of "Wed\, 14 Feb 2007 09\:29\:10 +0900") User-Agent: Gnus/5.110006 (No Gnus v0.6) XEmacs/21.4.19 (linux) X-Spam-Score: -0.7 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64358 Archived-At: >>>>> On Wed, 14 Feb 2007 09:29:10 +0900, Katsumi Yamaoka said: >>>>> In Dave Goldberg wrote: >>>>>>> On Tue, 13 Feb 2007 21:46:09 +0900, Katsumi Yamaoka said: >>> I seem to have solved this problem. Could you try it? >> It's odd. When working on my linux machine at home I get the same messages: >> Fontifying *wide reply to Katsumi Yamaoka on ding@gnus.org*... >> Fontifying *wide reply to Katsumi Yamaoka on ding@gnus.org*... done. > Those were issued when you typed `S W' (or similar) to start a > reply to me, and the fontification was successful (because of > the last `done'). The next ones were issued when you started > another mail, but fontification was not successful. Am I right? Nope, all of them come when I run `F' or `S W'. I'm not doing another mail. >> Fontifying mail to ding@gnus.org... >> Fontifying mail to ding@gnus.org... (regexps).... >> Fontifying mail to ding@gnus.org... (regexps)........ >> Fontifying mail to ding@gnus.org... (regexps)........ >> Fontifying mail to ding@gnus.org... (regexps)......... >> Fontifying mail to ding@gnus.org... (regexps).......... >> Fontifying mail to ding@gnus.org... (regexps)............. >> Fontifying mail to ding@gnus.org... (regexps).............. >> Fontifying mail to ding@gnus.org... (regexps)............... >> Fontifying mail to ding@gnus.org... (regexps)............... >> Fontifying mail to ding@gnus.org... (regexps)............... >> Fontifying mail to ding@gnus.org... (regexps)............... >> Fontifying mail to ding@gnus.org... (regexps)............... >> Fontifying mail to ding@gnus.org... (regexps)................ > `font-lock-fontify-keywords-region' issued those messages using: > (progress-feedback-with-label 'font-lock > "Fontifying %s... (regexps)" > progress bufname)) > But, in message.el there seems to be no function to make the > buffer name which is not surrounded with "*...*". How do you > start a "mail to ding@gnus.org"? All those questions might be > fruitless, though. No idea. I don't think I'm doing anything odd. >> Fontifying mail to ding@gnus.org... aborted.aborted. > Well, I might have misunderstood this message. The reason the > fontification was aborted was not because you typed `C-g', was > it? If so, it was terminated by an error and we can use the > debugger. To do that, copy lisp/font-lock.el to the tmp > directory, apply the patch attached in this message, load the > patched font-lock.el, set `debug-on-error' to t, and start a > reply. Nope, not a C-g. So I ran the patched font-lock.el and here's the resulting backtrace (from this very reply, in fact): Debugger entered--Lisp error: (void-function line-beginning-position) line-beginning-position() gnus-message-search-citation-line(4031) funcall(gnus-message-search-citation-line 4031) (if (stringp matcher) (re-search-forward matcher end t) (funcall matcher end)) (and (< (point) end) (if (stringp matcher) (re-search-forward matcher end t) (funcall matcher end))) (while (and (< ... end) (if ... ... ...)) (setq progress (+ ... ... 5)) (when (and loudly ...) (progress-feedback-with-label ... "Fontifying %s... (regexps)" progress bufname)) (setq old-progress progress) (setq highlights (cdr keyword)) (while highlights (if ... ... ...) (setq highlights ...))) (while keywords (setq keyword (car keywords) matcher (car keyword)) (goto-char start) (while (and ... ...) (setq progress ...) (when ... ...) (setq old-progress progress) (setq highlights ...) (while highlights ... ...)) (setq iter (1+ iter)) (setq keywords (cdr keywords))) (let* ((case-fold-search font-lock-keywords-case-fold-search) (keywords ...) (bufname ...) (progress 5) (old-progress 5) (iter 0) (nkeywords ...) keyword matcher highlights) (while keywords (setq keyword ... matcher ...) (goto-char start) (while ... ... ... ... ... ...) (setq iter ...) (setq keywords ...))) (let ((loudly ...)) (unless (eq ... t) (setq font-lock-keywords ...)) (let* (... ... ... ... ... ... ... keyword matcher highlights) (while keywords ... ... ... ... ...)) (if loudly (progress-feedback-with-label ... "Fontifying %s... " 100 ...))) font-lock-fontify-keywords-region(1 4031 nil) (progn (if font-lock-syntax-table (set-syntax-table font-lock-syntax-table)) (font-lock-unfontify-region beg end) (when font-lock-syntactic-keywords (font-lock-fontify-syntactic-keywords-region beg end)) (unless font-lock-keywords-only (font-lock-fontify-syntactically-region beg end loudly)) (font-lock-fontify-keywords-region beg end loudly)) (unwind-protect (progn (if font-lock-syntax-table ...) (font-lock-unfontify-region beg end) (when font-lock-syntactic-keywords ...) (unless font-lock-keywords-only ...) (font-lock-fontify-keywords-region beg end loudly)) (set-syntax-table old-syntax-table) (and (not modified) (buffer-modified-p) (set-buffer-modified-p nil))) (let ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (old-syntax-table ...) buffer-file-name buffer-file-truename) (unwind-protect (progn ... ... ... ... ...) (set-syntax-table old-syntax-table) (and ... ... ...))) font-lock-default-fontify-region(1 4031 nil) funcall(font-lock-default-fontify-region 1 4031 nil) font-lock-fontify-region(1 4031) (save-excursion (font-lock-fontify-region (point-min) (point-max))) (let ((was-on font-lock-mode) (font-lock-verbose ...) (font-lock-message-threshold 0) (aborted nil)) (or was-on (font-lock-mode 1)) (font-lock-unfontify-region (point-min) (point-max) t) (save-excursion (font-lock-fontify-region ... ...)) (or was-on (let ... ...)) (set (make-local-variable ...) t) (when (and aborted font-lock-verbose) (progress-feedback-with-label ... "Fontifying %s... aborted." ... ...))) (save-restriction (widen) (let (... ... ... ...) (or was-on ...) (font-lock-unfontify-region ... ... t) (save-excursion ...) (or was-on ...) (set ... t) (when ... ...)) (run-hooks (quote font-lock-after-fontify-buffer-hook))) font-lock-default-fontify-buffer() funcall(font-lock-default-fontify-buffer) (let ((font-lock-verbose ...)) (funcall font-lock-fontify-buffer-function)) font-lock-fontify-buffer() gnus-message-citation-mode(1) byte-code("..." [gnus-setup-message-winconf mbl mbl1 gnus-setup-message-group gnus-setup-message-article mml-buffer-list gnus-inews-add-send-actions reply-yank reply make-local-variable gnus-message-group-art gnus-newsgroup-name gnus-message-citation-mode 1 gnus-run-hooks gnus-message-setup-hook message-mode gnus-make-local-hook kill-buffer-hook change-major-mode-hook add-hook mml-destroy-buffers nil t gnus-setup-message-buffer yank gnus-setup-yanked-articles gnus-message-buffer gnus-message-highlight-citation major-mode] 6) gnus-summary-reply((3557) t) gnus-summary-reply-with-original(nil t) gnus-summary-wide-reply-with-original(nil) call-interactively(gnus-summary-wide-reply-with-original) Thanks, -- Dave Goldberg david.goldberg6@verizon.net