From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64293 Path: news.gmane.org!not-for-mail From: Dave Goldberg Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs Date: Thu, 08 Feb 2007 12:48:22 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170957028 29759 80.91.229.12 (8 Feb 2007 17:50:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Feb 2007 17:50:28 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M12817@lists.math.uh.edu Thu Feb 08 18:50:17 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1HFDPT-0007n5-TJ for ding-account@gmane.org; Thu, 08 Feb 2007 18:50:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1HFDOP-0001os-2l; Thu, 08 Feb 2007 11:49:09 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1HFDON-0001oY-2K for ding@lists.math.uh.edu; Thu, 08 Feb 2007 11:49:07 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1HFDOF-0006i1-4m for ding@lists.math.uh.edu; Thu, 08 Feb 2007 11:49:06 -0600 Original-Received: from vms048pub.verizon.net ([206.46.252.48]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1HFDOE-0000Cu-00 for ; Thu, 08 Feb 2007 18:48:58 +0100 Original-Received: from davestoy.homelinux.org.verizon.net ([72.74.234.218]) by vms048.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JD50015BO4N9OPD@vms048.mailsrvcs.net> for ding@gnus.org; Thu, 08 Feb 2007 11:48:29 -0600 (CST) X-Face: GUaHTH@nS>[7,ME@-gYZ4#Wl{z"99k@[[Y8AcP0x1paqu.,z9,XSV1WI>{q3f6^e5(zrit <4fV&VHhmE`uidRqtmG27;si9&r;#KSF~E#$%W8w(xdp)H4tW=\2XOk~3=@oGqqpj;m4xf Ow;y26396&,34@9#~4;@*S;E0cq"LM9N(us4P%F(Nxis'Vvfm9?KufH;:Q$dMa-QWGLR&K d0`LJZE8xb*>^yN>b]_NcU:E=Zn\1=#/(OS2 In-reply-to: (Katsumi Yamaoka's message of "Thu\, 08 Feb 2007 13\:42\:02 +0900") User-Agent: Gnus/5.110006 (No Gnus v0.6) XEmacs/21.4.19 (linux) X-Spam-Score: -0.7 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64293 Archived-At: >>>>> On Thu, 08 Feb 2007 13:42:02 +0900, Katsumi Yamaoka said: >>>>> In Dave Goldberg wrote: >>>>>>> On Wed, 07 Feb 2007 18:25:02 +0900, Katsumi Yamaoka said: >>> I've made changes in the trunk so that this feature may work >>> even with XEmacs 21.4/5 and SXEmacs (it cannot have worked with >>> XEmacs 21.5 even if `font-lock-add-keywords' is available). Now >>> `gnus-message-highlight-citation' always defaults to t. >> Unfortunately with this change (I'm assuming) I lost all highlighting >> in message mode unless I specifically set g-m-h-c to nil. >> XEmacs 21.4 (patch 19) "Constant Variable" [Lucid] (i686-pc-linux, Mule) of Mon Mar 20 2006 on davestoy.homelinux.org > I don't know why I saw it having worked with XEmacs yesterday > (it might have been due to `lazy-shot'). But it should not have > worked because of a bug. Sorry. > Emacs uses the `(t KEYWORDS COMPILED...)' form for compiled > font-lock keywords while XEmacs uses the `(t COMPILED...)' form. > However, in XEmacs 21.5, `font-lock-add-keywords' and > `font-lock-remove-keywords' assume the form of the Emacs style > for compiled keywords mistakenly. Because those function > definitions are now the same as the ones in Emacs 22. And I > partially copied them for XEmacs 21.4 and SXEmacs from XEmacs > 21.5 into gnus-cite.el. > I've added the test checking `f-l-add-k' and `f-l-remove-k' that > XEmacs provide work correctly. I've also fixed the emulating > version of them. Currently not only 21.4 but also XEmacs 21.5 > uses them. Could you try the latest CVS? > Regards, Things seem to work better now. At least, they work the way they did before. When I do a reply with citation included I see this: Fontifying mail to ding@gnus.org... Fontifying mail to ding@gnus.org... (regexps).... Fontifying mail to ding@gnus.org... (regexps)........ Fontifying mail to ding@gnus.org... (regexps)........ Fontifying mail to ding@gnus.org... (regexps)......... Fontifying mail to ding@gnus.org... (regexps).......... Fontifying mail to ding@gnus.org... (regexps)............ Fontifying mail to ding@gnus.org... (regexps).............. Fontifying mail to ding@gnus.org... (regexps)............... Fontifying mail to ding@gnus.org... (regexps)............... Fontifying mail to ding@gnus.org... (regexps)............... Fontifying mail to ding@gnus.org... (regexps)............... Fontifying mail to ding@gnus.org... (regexps)............... Fontifying mail to ding@gnus.org... (regexps)................ Fontifying mail to ding@gnus.org... aborted.aborted. In the minibuffer, but I do appear to be getting at least the same fontification I had before this update. Thanks, -- Dave Goldberg david.goldberg6@verizon.net