Re: [PATCH] Use `url' rather than curl

[Leo <sdl.web@gmail.com>]

On 2010-09-18 19:22 +0100, Julien Danjou wrote:
> +(defun gnus-html-image-fetched (status buffer images)
> +  (let ((spec (pop images)))
> +    (when (and (buffer-live-p buffer)
> +               ;; If the position of the marker is 1, then that
> +               ;; means that the text it was in has been deleted;
> +               ;; i.e., that the user has selected a different
> +               ;; article before the image arrived.
> +               (not (= (marker-position (cadr spec)) (point-min))))
> +      (let ((file (gnus-html-image-id (car spec))))
> +        ;; Search the start of the image data
> +        (search-forward "\n\n")
> +        ;; Write region (image) silently
> +        (write-region (point) (point-max) file nil 1)
> +        (kill-buffer)
> +        (with-current-buffer buffer
> +          (let ((inhibit-read-only t)
> +                (string (buffer-substring (cadr spec) (caddr spec))))
> +            (delete-region (cadr spec) (caddr spec))
> +            (gnus-html-put-image file (cadr spec) string))))
>        (when images
> -	(gnus-html-schedule-image-fetching buffer images)))))
> +        (gnus-html-schedule-image-fetching buffer images)))))
>  
>  (defun gnus-html-put-image (file point string &optional url alt-text)
>    (when (gnus-graphic-display-p)

Another comment. May not be relevant since I am still using Gnus from
emacs-23.

Looks like we are doing a round trip here. Retrieve an image into a
buffer, save it to a file and then have it read back and displayed.
Would it be better in the image spec to use :data with value from
(string-to-unibyte (buffer-substring....)) and :type from
image-type-from-data?

Leo