* [PATCH] Make group entering work in XEmacs again
@ 2012-06-18 13:08 Nelson Ferreira
2012-06-18 23:11 ` Katsumi Yamaoka
0 siblings, 1 reply; 4+ messages in thread
From: Nelson Ferreira @ 2012-06-18 13:08 UTC (permalink / raw)
To: ding
In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
add it, since it would be the default value in GNU Emacs anyway!
diff --git a/lisp/gnus-win.el b/lisp/gnus-win.el
index efe2a31..4261c3d 100644
--- a/lisp/gnus-win.el
+++ b/lisp/gnus-win.el
@@ -273,7 +273,7 @@ See the Gnus manual for an explanation of the syntax used.")
(cond
((eq buf (window-buffer (selected-window)))
(set-buffer buf))
- ((eq t (window-dedicated-p))
+ ((eq t (window-dedicated-p (selected-window)))
;; If the window is hard-dedicated, we have a problem because
;; we just can't do what we're asked. But signaling an error,
;; like `switch-to-buffer' would do, is not an option because
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Make group entering work in XEmacs again
2012-06-18 13:08 [PATCH] Make group entering work in XEmacs again Nelson Ferreira
@ 2012-06-18 23:11 ` Katsumi Yamaoka
2012-06-18 23:21 ` Nelson Ferreira
0 siblings, 1 reply; 4+ messages in thread
From: Katsumi Yamaoka @ 2012-06-18 23:11 UTC (permalink / raw)
To: nelson.ferreira; +Cc: ding
nelson.ferreira@ieee.org wrote:
> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
> add it, since it would be the default value in GNU Emacs anyway!
Applied. Thanks. I wonder why the buildbot didn't complain to
it, though.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make group entering work in XEmacs again
2012-06-18 23:11 ` Katsumi Yamaoka
@ 2012-06-18 23:21 ` Nelson Ferreira
2012-06-19 7:56 ` David Engster
0 siblings, 1 reply; 4+ messages in thread
From: Nelson Ferreira @ 2012-06-18 23:21 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> nelson.ferreira@ieee.org wrote:
>
>> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
>> add it, since it would be the default value in GNU Emacs anyway!
>
> Applied. Thanks. I wonder why the buildbot didn't complain to
> it, though.
Buildbot probably did not complain because it only surfaces at runtime.
My local build also succeeded. Only when attempting to enter a group I
got a traceback.
--Nelson
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make group entering work in XEmacs again
2012-06-18 23:21 ` Nelson Ferreira
@ 2012-06-19 7:56 ` David Engster
0 siblings, 0 replies; 4+ messages in thread
From: David Engster @ 2012-06-19 7:56 UTC (permalink / raw)
To: Nelson Ferreira; +Cc: ding
Nelson Ferreira writes:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> nelson.ferreira@ieee.org wrote:
>>
>>> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
>>> add it, since it would be the default value in GNU Emacs anyway!
>>
>> Applied. Thanks. I wonder why the buildbot didn't complain to
>> it, though.
>
> Buildbot probably did not complain because it only surfaces at runtime.
> My local build also succeeded. Only when attempting to enter a group I
> got a traceback.
xemacs should issue a warning during byte compilation (the Buildbot uses
'make fail-on-warning'), but for some reason it doesn't.
-David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-19 7:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-18 13:08 [PATCH] Make group entering work in XEmacs again Nelson Ferreira
2012-06-18 23:11 ` Katsumi Yamaoka
2012-06-18 23:21 ` Nelson Ferreira
2012-06-19 7:56 ` David Engster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).