gnus-summary-refer-parent-article bug

gnus-summary-refer-parent-article bug

[Dave Abrahams]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]


When gnus-summary-refer-parent-article is invoked on some articles, I
keep getting this backtrace:


[-- Attachment #2: BOOM --]
[-- Type: application/emacs-lisp, Size: 15526 bytes --]

[-- Attachment #3: Type: text/plain, Size: 45 bytes --]


Does anyone know what's up here?

TIA,
Dave

Re: gnus-summary-refer-parent-article bug

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

On 2016-01-17 23:26, Dave Abrahams <dave@boostpro.com> writes:

> When gnus-summary-refer-parent-article is invoked on some articles, I
> keep getting this backtrace:
>
> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>   =(nil 32)

I think this is the same bug I reported a couple weeks ago:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353
http://thread.gmane.org/gmane.emacs.gnus.general/86583

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 17, 2016, Mauna Loa Obs.): 402.86 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: gnus-summary-refer-parent-article bug

[Dave Abrahams]

on Mon Jan 18 2016, Alan Schmitt <alan.schmitt-AT-polytechnique.org> wrote:

> On 2016-01-17 23:26, Dave Abrahams <dave@boostpro.com> writes:
>
>> When gnus-summary-refer-parent-article is invoked on some articles, I
>> keep getting this backtrace:
>>
>> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>>   =(nil 32)
>
> I think this is the same bug I reported a couple weeks ago:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353
> http://thread.gmane.org/gmane.emacs.gnus.general/86583

You're quite right; thanks for working out the fix, too!

-Dave

Re: gnus-summary-refer-parent-article bug

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Mon, 18 Jan 2016 07:47:46 -0800, Dave Abrahams wrote:
> on Mon Jan 18 2016, Alan Schmitt <alan.schmitt-AT-polytechnique.org> wrote:
>> I think this is the same bug I reported a couple weeks ago:
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353
>> http://thread.gmane.org/gmane.emacs.gnus.general/86583

> You're quite right; thanks for working out the fix, too!

Could you try the patch below?  Probably this is the right fix
because:

,---- (info "(gnus)Optional Back End Functions")
|‘(nnchoke-request-update-mark GROUP ARTICLE MARK)’
|
|     If the user tries to set a mark that the back end doesn’t like,
|     this function may change the mark.  Gnus will use whatever this
|     function returns as the mark for ARTICLE instead of the original
|     MARK.
|     If the back end doesn’t care, it must return the original MARK,
|     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|     and not ‘nil’ or any other type of garbage.
|     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|     The only use for this I can see is what ‘nnvirtual’ does with it—if
|     a component group is auto-expirable, marking an article as read in
|     the virtual group should result in the article being marked as
|     expirable.
|
|     There should be no result data from this function.
`----


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 584 bytes --]

--- nnir.el~	2016-01-04 22:05:27.318335700 +0000
+++ nnir.el	2016-01-19 00:24:05.129707800 +0000
@@ -822,8 +822,10 @@
 (deffoo nnir-request-update-mark (group article mark)
   (let ((artgroup (nnir-article-group article))
 	(artnumber (nnir-article-number article)))
-    (when (and artgroup artnumber)
-      (gnus-request-update-mark artgroup artnumber mark))))
+    (or (and artgroup
+	     artnumber
+	     (gnus-request-update-mark artgroup artnumber mark))
+	mark)))
 
 (deffoo nnir-request-set-mark (group actions &optional server)
   (nnir-possibly-change-group group server)

Re: gnus-summary-refer-parent-article bug

[Dave Abrahams]

on Mon Jan 18 2016, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:

> On Mon, 18 Jan 2016 07:47:46 -0800, Dave Abrahams wrote:
>> on Mon Jan 18 2016, Alan Schmitt <alan.schmitt-AT-polytechnique.org> wrote:
>>> I think this is the same bug I reported a couple weeks ago:
>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353
>>> http://thread.gmane.org/gmane.emacs.gnus.general/86583
>
>> You're quite right; thanks for working out the fix, too!
>
> Could you try the patch below?  Probably this is the right fix
> because:
>
> ,---- (info "(gnus)Optional Back End Functions")
> |‘(nnchoke-request-update-mark GROUP ARTICLE MARK)’
> |
> |     If the user tries to set a mark that the back end doesn’t like,
> |     this function may change the mark.  Gnus will use whatever this
> |     function returns as the mark for ARTICLE instead of the original
> |     MARK.
> |     If the back end doesn’t care, it must return the original MARK,
> |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |     and not ‘nil’ or any other type of garbage.
> |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |     The only use for this I can see is what ‘nnvirtual’ does with it—if
> |     a component group is auto-expirable, marking an article as read in
> |     the virtual group should result in the article being marked as
> |     expirable.
> |
> |     There should be no result data from this function.
> `----
>
> --- nnir.el~	2016-01-04 22:05:27.318335700 +0000
> +++ nnir.el	2016-01-19 00:24:05.129707800 +0000
> @@ -822,8 +822,10 @@
>  (deffoo nnir-request-update-mark (group article mark)
>    (let ((artgroup (nnir-article-group article))
>  	(artnumber (nnir-article-number article)))
> -    (when (and artgroup artnumber)
> -      (gnus-request-update-mark artgroup artnumber mark))))
> +    (or (and artgroup
> +	     artnumber
> +	     (gnus-request-update-mark artgroup artnumber mark))
> +	mark)))
>
>  (deffoo nnir-request-set-mark (group actions &optional server)
>    (nnir-possibly-change-group group server)

Seems to work OK, thanks

-Dave

Re: gnus-summary-refer-parent-article bug

[Katsumi Yamaoka]

On Tue, 19 Jan 2016 07:59:21 -0800, Dave Abrahams <dave@boostpro.com> wrote:
> Seems to work OK, thanks

Thanks for verifying.  Committed to the emacs-25 branch.

Re: gnus-summary-refer-parent-article bug

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hello,

On 2016-01-20 07:10, Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Tue, 19 Jan 2016 07:59:21 -0800, Dave Abrahams <dave@boostpro.com> wrote:
>> Seems to work OK, thanks
>
> Thanks for verifying.  Committed to the emacs-25 branch.

Thanks a lot for this patch. Did you push the branch? I cannot see it
here http://git.gnus.org/cgit/gnus.git/log/, and I would like to use it.

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 18, 2016, Mauna Loa Obs.): 402.66 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: gnus-summary-refer-parent-article bug

[Katsumi Yamaoka]

On Wed, 20 Jan 2016 12:04:37 +0100, Alan Schmitt wrote:
> Thanks a lot for this patch. Did you push the branch? I cannot see it
> here http://git.gnus.org/cgit/gnus.git/log/, and I would like to use it.

Sorry, I'll never modify the Gnus git repo any more (except for
an irregular case) honoring Lars' message:

<http://thread.gmane.org/gmane.emacs.devel/197168>

The latest Gnus is in the emacs-25 branch of the Emacs git repo
now; it will be merged to the Emacs trunk sooner or later.

Regards,

Re: gnus-summary-refer-parent-article bug

[Katsumi Yamaoka]

On Thu, 21 Jan 2016 08:04:35 +0900, Katsumi Yamaoka wrote:
> The latest Gnus is in the emacs-25 branch of the Emacs git repo
> now; it will be merged to the Emacs trunk sooner or later.

FYI.  Things that have not yet been merged from the emacs-25
branch to the trunk at this time are in:

http://www.jpl.org/ftp/pub/tmp/MaGnus-to-Emacs-trunk-unfinished.patch

Re: gnus-summary-refer-parent-article bug

[Eric Abrahamsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Thu, 21 Jan 2016 08:04:35 +0900, Katsumi Yamaoka wrote:
>> The latest Gnus is in the emacs-25 branch of the Emacs git repo
>> now; it will be merged to the Emacs trunk sooner or later.
>
> FYI.  Things that have not yet been merged from the emacs-25
> branch to the trunk at this time are in:
>
> http://www.jpl.org/ftp/pub/tmp/MaGnus-to-Emacs-trunk-unfinished.patch

So git.gnus.org is already abandoned? It should probably be set
read-only, then -- I didn't realize we'd already made the shift...

Re: gnus-summary-refer-parent-article bug

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

On 2016-01-21 08:04, Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Wed, 20 Jan 2016 12:04:37 +0100, Alan Schmitt wrote:
>> Thanks a lot for this patch. Did you push the branch? I cannot see it
>> here http://git.gnus.org/cgit/gnus.git/log/, and I would like to use it.
>
> Sorry, I'll never modify the Gnus git repo any more (except for
> an irregular case) honoring Lars' message:
>
> <http://thread.gmane.org/gmane.emacs.devel/197168>
>
> The latest Gnus is in the emacs-25 branch of the Emacs git repo
> now; it will be merged to the Emacs trunk sooner or later.

Ah. Is it possible to upgrade gnus without waiting for emacs 25? The
only instructions I could find to use the latest gnus use the obsolete
repository.

Thanks,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 20, 2016, Mauna Loa Obs.): 402.30 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: Moving Gnus development to Emacs?

[Katsumi Yamaoka]

On Thu, 21 Jan 2016 11:21:06 +0100, Alan Schmitt wrote:
> Ah. Is it possible to upgrade gnus without waiting for emacs 25? The
> only instructions I could find to use the latest gnus use the obsolete
> repository.

Ok, for the moment I've made the Gnus git repo up-to-date except
for tls.el[1].  Could you test it?

Lars, I can synch the Gnus git repo and the Emacs git repo until
the next (the last?) Gnus release.  Is it ok?

[1] In Emacs, tls.el requires gnutls.el of the bleeding-edge.

Re: Moving Gnus development to Emacs?

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On 2016-01-22 11:37, Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Thu, 21 Jan 2016 11:21:06 +0100, Alan Schmitt wrote:
>> Ah. Is it possible to upgrade gnus without waiting for emacs 25? The
>> only instructions I could find to use the latest gnus use the obsolete
>> repository.
>
> Ok, for the moment I've made the Gnus git repo up-to-date except
> for tls.el[1].  Could you test it?

I could pull this version, and I confirm it fixes my problem. I guess
I should close the bug report I opened about this
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353). What is the
correct way to do it? Should I reference the commit hash?

Thanks,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 20, 2016, Mauna Loa Obs.): 402.30 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: Moving Gnus development to Emacs?

[Katsumi Yamaoka]

On Fri, 22 Jan 2016 08:53:15 +0100, Alan Schmitt wrote:
> I guess I should close the bug report I opened about this
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353). What is the
> correct way to do it? Should I reference the commit hash?

Send a mail to <22353-done@@debbugs.gnu.org> with a short comment.

BTW, why I'm unable to find the bug#22353 thread in the news group
gmane.emacs.bugs?

Re: Moving Gnus development to Emacs?

[Michael Albinus]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> BTW, why I'm unable to find the bug#22353 thread in the news group
> gmane.emacs.bugs?

Because it belongs to the package "gnus" instead of package "emacs".

Best regards, Michael.

Re: Moving Gnus development to Emacs?

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On 2016-01-22 18:45, Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Fri, 22 Jan 2016 08:53:15 +0100, Alan Schmitt wrote:
>> I guess I should close the bug report I opened about this
>> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353). What is the
>> correct way to do it? Should I reference the commit hash?
>
> Send a mail to <22353-done@@debbugs.gnu.org> with a short comment.

Thank you, I just did that.

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 20, 2016, Mauna Loa Obs.): 402.30 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: Moving Gnus development to Emacs?

[Katsumi Yamaoka]

On Fri, 22 Jan 2016 12:28:37 +0100, Michael Albinus wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> BTW, why I'm unable to find the bug#22353 thread in the news group
>> gmane.emacs.bugs?

> Because it belongs to the package "gnus" instead of package "emacs".

Ah, I see.  Thanks.  I found it in the page
<http://debbugs.gnu.org/db/si/donenormal.html>
and also:
<http://debbugs.gnu.org/db/si/pendingnormal.html>
<http://debbugs.gnu.org/db/si/forwardednormal.html>

But many of them will likely be left unseen, so a better way for
at least Gnus would be to post it here or as an Emacs bug, I think.

Re: Moving Gnus development to Emacs?

[Katsumi Yamaoka]

On Fri, 22 Jan 2016 11:37:04 +0900, Katsumi Yamaoka wrote:
> Lars, I can synch the Gnus git repo and the Emacs git repo until
> the next (the last?) Gnus release.  Is it ok?

On Wed, 30 Dec 2015 12:43:12 +0100, Lars Magne Ingebrigtsen wrote:
> Emacs has developed rapidly during the last few years,

It's not a matter for me who build Emacs as a daily routine.  It
takes only several minutes.  Though it sometimes stops my work
with a sudden bug.  But no matter what, the most troublesome for
me is to tweak Gnus so as to work with old Emacsen.

> and the
> interfaces between Emacs, older versions of Emacs, and XEmacs are
> growing more divergent.  This means that basically any change we do in
> Gnus fails to build on all build targets.  And this, in turn, means that
> any change we do in Gnus is 2x as much work as it should be, and this
> leaves the code looking like an exercise in obfuscated programming.
> Sometimes.  :-)

Keeping the backward compatibility of Gnus for old Emacsen is
not only troublesome but also it will lower the Gnus performance.
If you don't want to put up with bugs till the next Emacs release
what I do would be one of ways.

Regards,

Re: Moving Gnus development to Emacs?

[Mike Kupfer]

Katsumi Yamaoka wrote:

> But many of them will likely be left unseen, so a better way for
> at least Gnus would be to post it here or as an Emacs bug, I think.

Hmm, I used

  M-x gnus-bug

back in December to file #22157.  It went to debbugs.gnu.org under the
"gnus" package.  If bug reports should go somewhere else, gnus-bug
should be changed to do the right thing.

cheers,
mike

Re: Moving Gnus development to Emacs?

[Katsumi Yamaoka]

On Sun, 24 Jan 2016 17:58:11 -0800, Mike Kupfer wrote:
> Katsumi Yamaoka wrote:
>> But many of them will likely be left unseen, so a better way for
>> at least Gnus would be to post it here or as an Emacs bug, I think.

> Hmm, I used

>   M-x gnus-bug

> back in December to file #22157.  It went to debbugs.gnu.org under the
> "gnus" package.  If bug reports should go somewhere else, gnus-bug
> should be changed to do the right thing.

Otherwise, reports should appear in a gmane newsgroup (or a
mailing list).

Re: Moving Gnus development to Emacs?

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On 2016-01-24 17:58, Mike Kupfer <m.kupfer@acm.org> writes:

> Katsumi Yamaoka wrote:
>
>> But many of them will likely be left unseen, so a better way for
>> at least Gnus would be to post it here or as an Emacs bug, I think.
>
> Hmm, I used
>
>   M-x gnus-bug
>
> back in December to file #22157.  It went to debbugs.gnu.org under the
> "gnus" package.  If bug reports should go somewhere else, gnus-bug
> should be changed to do the right thing.

This is also what I did for this bug.

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 24, 2016, Mauna Loa Obs.): 402.49 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: Moving Gnus development to Emacs?

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Thu, 21 Jan 2016 11:21:06 +0100, Alan Schmitt wrote:
>> Ah. Is it possible to upgrade gnus without waiting for emacs 25? The
>> only instructions I could find to use the latest gnus use the obsolete
>> repository.
>
> Ok, for the moment I've made the Gnus git repo up-to-date except
> for tls.el[1].  Could you test it?
>
> Lars, I can synch the Gnus git repo and the Emacs git repo until
> the next (the last?) Gnus release.  Is it ok?

I forgot to answer, but yes please.  :-)  But now the last Gnus release
has been done, and I've made the repo read-only (I think).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Moving Gnus development to Emacs?

[Adam Sjøgren]

Lars writes:

> I forgot to answer, but yes please.  :-)  But now the last Gnus release
> has been done, and I've made the repo read-only (I think).

I think you may have made it a little too read-only:

  $ git pull --rebase
  fatal: unable to access 'https://git.gnus.org/gnus.git/': The requested URL returned error: 500
  $ 


  Best regards,

    Adam

-- 
 "I am still twitching at the idea that you need to           Adam Sjøgren
  load code into the kernel in order to re-map a         asjo@koldfront.dk
  mouse button."

Re: Moving Gnus development to Emacs?

[Adam Sjøgren]

Adam writes:

> I think you may have made it a little too read-only:

Never mind, just pull from http instead of https, and it's fine.


  Best regards,

    Adam

-- 
 "Eternal evil                                                Adam Sjøgren
  Yeah it stares behind the desk"                        asjo@koldfront.dk