Gnus development mailing list
 help / color / mirror / Atom feed
From: Dave Abrahams <dave@boostpro.com>
To: ding@gnus.org
Subject: warp-to-article refactoring
Date: Fri, 07 Oct 2011 05:43:56 -0400	[thread overview]
Message-ID: <m24nzlkug3.fsf@pluto.luannocracy.com> (raw)


I'm about to do a bit of copy/paste programming from
nnir-warp-to-article, and it bothers me.  It looks to me like almost all
of nnir-warp-to-article ought to be in gnus-warp-to-article, and in fact
the thing that ought to be a "group function" instead of warp-to-article
is something more like get-article-origin, returning a
group-id/article-id pair.

The question is what kind of patch to submit upstream.  Do we need to
preserve warp-to-article as a hook, or is it OK to break the (maybe) one
user-written backend out there that implements it?  If not, I can
preserve it for backward compatibility, but the refactoring is going to
be a lot messier.

TIA,

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com




                 reply	other threads:[~2011-10-07  9:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24nzlkug3.fsf@pluto.luannocracy.com \
    --to=dave@boostpro.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).