Gnus development mailing list
 help / color / mirror / Atom feed
From: Steven L Baur <steve@miranova.com>
Subject: Re: September Gnus 0.48 is released
Date: 29 Feb 1996 11:25:35 -0800	[thread overview]
Message-ID: <m268cqgci8.fsf@deanna.miranova.com> (raw)
In-Reply-To: Lars Magne Ingebrigtsen's message of 29 Feb 1996 05:35:02 -0800

There was an XEmacs compatibility problem introduced into v0.46.  The
utility function mail-strip-quoted-names accepts nil input on Emacs
19.30 and barfs and dies on nil input with XEmacs 19.13.  The
following patch works around this problem.  A 19.14 beta tester should
check to see if mail-strip-quoted-names (in utils/mail-utils.el) still
has the same bug.

The supplied patch does nothing on Emacs 19.30 and on XEmacs puts a
wrapper around mail-strip-quoted-names to correctly process a nil
parameter.

===================================================================
RCS file: RCS/ChangeLog,v
retrieving revision 1.51
diff -u -r1.51 ChangeLog
--- ChangeLog	1996/02/29 17:14:32	1.51
+++ ChangeLog	1996/02/29 19:02:39
@@ -1,3 +1,15 @@
+Thu Feb 29 10:50:02 1996  Steven L. Baur  <steve@miranova.com>
+
+	* gnus-xmas.el (gnus-xmas-redefine): Add wrapper to
+	mail-strip-quoted-names.
+	(gnus-xmas-mail-strip-quoted-names): New function.
+
+	* gnus-msg.el (gnus-mail-reply): Use it.
+
+	* gnus-soup.el (gnus-soup-store): Use it.
+
+	* gnus-ems.el: mail-strip-quoted-names -> gnus-mail-strip-quoted-names.
+
 Thu Feb 29 14:28:06 1996  Lars Magne Ingebrigtsen  <larsi@hler.ifi.uio.no>
 
 	* gnus.el (gnus-read-active-file): Wouldn't work on `some'.

===================================================================
RCS file: RCS/gnus-ems.el,v
retrieving revision 1.8
diff -u -r1.8 gnus-ems.el
--- gnus-ems.el	1996/02/19 23:48:29	1.8
+++ gnus-ems.el	1996/02/29 18:48:55
@@ -39,6 +39,7 @@
 (defalias 'gnus-extent-start-open 'ignore)
 (defalias 'gnus-set-text-properties 'set-text-properties)
 (defalias 'gnus-appt-select-lowest-window 'appt-select-lowest-window)
+(defalias 'gnus-mail-strip-quoted-names 'mail-strip-quoted-names)
 
 (eval-and-compile 
   (autoload 'gnus-xmas-define "gnus-xmas")

===================================================================
RCS file: RCS/gnus-xmas.el,v
retrieving revision 1.16
diff -u -r1.16 gnus-xmas.el
--- gnus-xmas.el	1996/02/19 23:48:29	1.16
+++ gnus-xmas.el	1996/02/29 18:54:07
@@ -397,6 +397,7 @@
   (fset 'gnus-tree-minimize 'gnus-xmas-tree-minimize)
   (fset 'gnus-appt-select-lowest-window 
 	'gnus-xmas-appt-select-lowest-window)
+  (fset 'gnus-mail-strip-quoted-names 'gnus-xmas-mail-strip-quoted-names)
 
   (add-hook 'gnus-group-mode-hook 'gnus-xmas-group-menu-add)
   (add-hook 'gnus-summary-mode-hook 'gnus-xmas-summary-menu-add)
@@ -710,5 +711,11 @@
 	    (after-find-file error (not nowarn)))))
       buf)))
 
+(defun gnus-xmas-mail-strip-quoted-names (address)
+  "Protect mail-strip-quoted-names from NIL input.
+XEmacs compatibility workaround."
+  (if (null address)
+      nil
+    (mail-strip-quoted-names address)))
 
 ;;; gnus-xmas.el ends here

===================================================================
RCS file: RCS/gnus-msg.el,v
retrieving revision 1.36
diff -u -r1.36 gnus-msg.el
--- gnus-msg.el	1996/02/29 17:12:15	1.36
+++ gnus-msg.el	1996/02/29 19:01:32
@@ -481,9 +481,9 @@
   (gnus-summary-select-article t)
   ;; Check whether the user owns the article that is to be superseded. 
   (unless (string-equal
-	   (downcase (mail-strip-quoted-names 
+	   (downcase (gnus-mail-strip-quoted-names 
 		      (mail-header-from gnus-current-headers)))
-	   (downcase (mail-strip-quoted-names (gnus-inews-user-name))))
+	   (downcase (gnus-mail-strip-quoted-names (gnus-inews-user-name))))
     (error "This article is not yours."))
   ;; Get a normal *Post News* buffer.
   (gnus-new-news gnus-newsgroup-name t)
@@ -1035,8 +1035,9 @@
 	  ;; user id with value of its From: field.
 	  (if (not
 	       (string-equal
-		(downcase (mail-strip-quoted-names from))
-		(downcase (mail-strip-quoted-names (gnus-inews-user-name)))))
+		(downcase (gnus-mail-strip-quoted-names from))
+		(downcase (gnus-mail-strip-quoted-names
+			   (gnus-inews-user-name)))))
 	      (progn
 		(ding) (gnus-message 3 "This article is not yours.")
 		nil)
@@ -1891,8 +1892,8 @@
 		      new-cc 
 		      (if (and mctdo
 			       (not (string= 
-				     (mail-strip-quoted-names mct)
-				     (mail-strip-quoted-names
+				     (gnus-mail-strip-quoted-names mct)
+				     (gnus-mail-strip-quoted-names
 				      (or to-address 
 					  (if (and follow-to 
 						   (not (stringp follow-to)))
@@ -1917,7 +1918,7 @@
 		  (setq ccalist
 			(mapcar
 			 (lambda (addr)
-			   (cons (mail-strip-quoted-names addr) addr))
+			   (cons (gnus-mail-strip-quoted-names addr) addr))
 			 (nreverse (gnus-mail-parse-comma-list))))
 		  (let ((s ccalist))
 		    (while s

===================================================================
RCS file: RCS/gnus-soup.el,v
retrieving revision 1.10
diff -u -r1.10 gnus-soup.el
--- gnus-soup.el	1996/02/29 05:45:56	1.10
+++ gnus-soup.el	1996/02/29 19:02:24
@@ -223,7 +223,7 @@
       ;; Find the "from".
       (goto-char (point-min))
       (setq from
-	    (mail-strip-quoted-names
+	    (gnus-mail-strip-quoted-names
 	     (or (mail-fetch-field "from")
 		 (mail-fetch-field "really-from")
 		 (mail-fetch-field "sender"))))

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.


  reply	other threads:[~1996-02-29 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-02-29 13:35 Lars Magne Ingebrigtsen
1996-02-29 19:25 ` Steven L Baur [this message]
1996-03-02  3:04   ` Mark Borges
1996-03-02 18:02   ` Mark Borges
1996-03-02 18:53     ` Steven L Baur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m268cqgci8.fsf@deanna.miranova.com \
    --to=steve@miranova.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).