Add message-id in message-citation-line-format

Add message-id in message-citation-line-format

[Leo]

Dear all,

There is one common citation line format that is not supported by
message-citation-line-format, for example:

,----
| In <mux3b1zx092.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:
`----

Can we add a letter for message-id?

Best,
-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Add message-id in message-citation-line-format

[Katsumi Yamaoka]

>>>>> In <m2tzskzc7g.fsf@cam.ac.uk> Leo wrote:

> There is one common citation line format that is not supported by
> message-citation-line-format, for example:

> ,----
>| In <mux3b1zx092.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:
> `----

> Can we add a letter for message-id?

I use the MU-CITE package[1], that is fully customizable.  Though
there is no manual, the comment at the beginning of the mu-cite.el
file describes briefly how to use it.  You can customize some
options including `mu-cite-top-format'.  The "In ID NAME wtote:"
form is the default but you are required to be skillful in ELisp
if you want to make it complicated (please don't ask me how to do
it ;-).

[1] http://www.jpl.org/elips/mu/

Re: Add message-id in message-citation-line-format

[Leo]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

In article <m2tzskzc7g.fsf@cam.ac.uk>, Leo wrote:
> Dear all,
>
> There is one common citation line format that is not supported by
> message-citation-line-format, for example:
>
> ,----
> | In <mux3b1zx092.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:
> `----
>
> Can we add a letter for message-id?
>
> Best,

Is the following patch correct?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: message.diff --]
[-- Type: text/x-patch, Size: 1161 bytes --]

Index: message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 7.218
diff -u -r7.218 message.el
--- message.el	22 Jun 2007 12:20:13 -0000	7.218
+++ message.el	4 Jul 2007 12:02:03 -0000
@@ -935,6 +935,7 @@
 constructs are replaced:
 
   %f   The full From, e.g. \"John Doe <john.doe@example.invalid>\".
+  %i   The message id, e.g. \"<m2tzskzc7g.fsf@example.invalid>\".
   %n   The mail address, e.g. \"john.doe@example.invalid\".
   %N   The real name if present, e.g.: \"John Doe\", else fall
        back to the mail address.
@@ -3691,6 +3692,7 @@
 	   (net (car (cdr data)))
 	   (name-or-net (or (car data)
 			    (car (cdr data)) from))
+	   (id (mail-header-message-id message-reply-headers))
 	   (replydate
 	    (or
 	     date
@@ -3727,7 +3729,7 @@
 	      (push ?P lst) (push "<P>" lst)
 	      (push ?Q lst) (push "<Q>" lst)
 	      (push ?f lst) (push from lst)
-	      (push ?i lst) (push "<i>" lst)
+	      (push ?i lst) (push id lst)
 	      (push ?n lst) (push net lst)
 	      (push ?o lst) (push "<o>" lst)
 	      (push ?q lst) (push "<q>" lst)

[-- Attachment #3: Type: text/plain, Size: 76 bytes --]


-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Add message-id in message-citation-line-format

[Leo]

In article <b4mtzskxv3c.fsf@jpl.org>, Katsumi Yamaoka wrote:
>>>>>> In <m2tzskzc7g.fsf@cam.ac.uk> Leo wrote:
>
>> There is one common citation line format that is not supported by
>> message-citation-line-format, for example:
>
>> ,----
>>| In <mux3b1zx092.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:
>> `----
>
>> Can we add a letter for message-id?
>
> I use the MU-CITE package[1], that is fully customizable.  Though
> there is no manual, the comment at the beginning of the mu-cite.el
> file describes briefly how to use it.  You can customize some
> options including `mu-cite-top-format'.  The "In ID NAME wtote:"
> form is the default but you are required to be skillful in ELisp
> if you want to make it complicated (please don't ask me how to do
> it ;-).
>
> [1] http://www.jpl.org/elips/mu/

Thanks for the info. But there are a few letters that are not yet been
assigned to useful info in message-citation-line-format. I was
suggesting improve them.

Best,
-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Add message-id in message-citation-line-format

[Reiner Steib]

On Wed, Jul 04 2007, Leo wrote:

>> There is one common citation line format that is not supported by
>> message-citation-line-format, for example:
>>
>> ,----
>> | In <mux3b1zx092.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:
>> `----

Personally, I think adding the MID in the citation line is completely
useless.  In contrast to name, mail address or date this information
_is_ already present in the reply/followup anyhow (References or
In-Reply-To header).

The only reason that it is common is that it's the stupid default of
Outlook Express making the citation line exceedingly wide or wrapped
in two lines ("citation novel" instead of citation _line_; In the de.*
hierarchy, you'll soon get flamed if you'd use of such citation novel).

>> Can we add a letter for message-id?

I'm not convinced yet that we should encourage adding the MID in the
citation line and waste a letter that might use for something better
in the future (e.g. a future use of %i in `format-time-string').

> Is the following patch correct?

The letter also has to be added here:

	     (when (string-match "%[^fnNFL]" message-citation-line-format)
	       (autoload 'gnus-date-get-time "gnus-util")
	       (gnus-date-get-time (mail-header-date message-reply-headers)))))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Add message-id in message-citation-line-format

[Leo]

On 04/07/2007, Reiner Steib wrote:
>>> Can we add a letter for message-id?
>
> I'm not convinced yet that we should encourage adding the MID in the
> citation line and waste a letter that might use for something better
> in the future (e.g. a future use of %i in `format-time-string').

I realized that it is not useful so I agree with you ;)

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)