Gnus development mailing list
 help / color / mirror / Atom feed
From: Sudish Joseph <sudish@mindspring.com>
Subject: Patch for async fetch munging articles bug
Date: 31 Jul 1996 03:44:36 -0400	[thread overview]
Message-ID: <m2afwgsw7v.fsf_-_@atreides.erehwon.org> (raw)
In-Reply-To: Sudish Joseph's message of 30 Jul 1996 23:35:48 -0400

Sudish Joseph <sudish@mindspring.com> writes:
> Update: the gnus-async stuff seems to get confused as to which o/p
> belongs to which command.  I'm getting articles containing NNTP o/p as
> well as empty article buffers.

Here's what I think is a fix for this.  I say "think" coz it's like
the 10th "fix" or so, each prior one having failed to me "thinking" it
was correct.  You have been warned.

The problem is basically in #'nntp-process-filter, which assumes that
by searching -backwards- from the end for the wait-for'ed string, it
won't skip over other instances of the same string.  However, multiple
replies can pour in by the time that filter kicks in.  (I'm not too
sure about that last statement, it only seems to happen for the very
first group you visit.)

Fixing this seemed too hard, since one would have to tag replies in
some fashion to ensure that they're handed over to the correct
callback function.  So I fixed it in gnus-async, where you generate
the callback.  (Very cool code, Lars.)

There's still some weirdness left here, I think.  My brain, uh, seat
cushion is fried, though, so I'm not digging further tonight.

This was a b*tch to debug -- edebug craps out on backquoted forms
inside of defuns and is a total lose for those cool callbacks you're
generating.

-Sudish

PS: For a gnus-reopen-all-connections command, does it suffice to
delete all process buffers in nntp-connection-alist?  I'd really like
to have this available since I use a demand dialer to manage my
connection.


Wed Jul 31 03:09:23 1996  Sudish Joseph  <sudish@mindspring.com>

	* gnus-async.el (gnus-async-prefetch-article): Search forward for
        end of article from saved marker; multiple articles (and even nntp
	reply codes) may be present in the async buffer.  Signal failures
        in filters via explicit 'message or they'll be trapped and lost.



--- gnus-async.el	Wed Jul 31 03:19:54 1996
+++ gnus-async.el	Wed Jul 31 03:19:54 1996
@@ -101,8 +101,12 @@
 		 `(lambda (arg)
 		    (save-excursion
 		      (gnus-async-set-prefetch-buffer)
+		      (goto-char ,mark)
+		      (unless (re-search-forward "\r\n\\.\r\n" nil t)
+			(message "bogon in gnus-async-prefetch-article!")
+			(ding))
 		      (push (list ',(intern (format "%s-%d" group article))
-				  ,mark (set-marker (make-marker) (point-max))
+				  ,mark (set-marker (make-marker) (point))
 				  ,group ,article)
 			    gnus-async-article-alist)
 		      (when (gnus-buffer-live-p ,summary)


  reply	other threads:[~1996-07-31  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-07-30 21:03 Red Gnus v0.1 is released Lars Magne Ingebrigtsen
1996-07-31  0:23 ` Steven L Baur
1996-07-31  0:25 ` Sudish Joseph
1996-07-31  1:36   ` Steven L Baur
1996-07-31  3:35     ` Sudish Joseph
1996-07-31  7:44       ` Sudish Joseph [this message]
1996-07-31 10:59         ` Patch for async fetch munging articles bug Lars Magne Ingebrigtsen
1996-07-31 11:17   ` Red Gnus v0.1 is released Lars Magne Ingebrigtsen
1996-07-31  1:16 ` Carsten Leonhardt
1996-07-31  3:40   ` Sudish Joseph
1996-07-31  7:48     ` Sudish Joseph
1996-07-31  8:56 ` Christian Viken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2afwgsw7v.fsf_-_@atreides.erehwon.org \
    --to=sudish@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).