From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/85134 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: [Patch] Signature for format=flowed Date: Wed, 15 Oct 2014 10:31:55 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: References: <87d29wq6gb.fsf@yale.edu> <87mw8yh1im.fsf@yale.edu> <87fveqgyxx.fsf@yale.edu> Reply-To: ding@gnus.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1413383544 15495 80.91.229.3 (15 Oct 2014 14:32:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Oct 2014 14:32:24 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M33378@lists.math.uh.edu Wed Oct 15 16:32:17 2014 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XePcd-00039t-Su for ding-account@gmane.org; Wed, 15 Oct 2014 16:32:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1XePcX-0005DI-JF; Wed, 15 Oct 2014 09:32:09 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1XePcV-0005Cs-W4 for ding@lists.math.uh.edu; Wed, 15 Oct 2014 09:32:07 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1XePcU-0004tu-O4 for ding@lists.math.uh.edu; Wed, 15 Oct 2014 09:32:07 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]) by quimby.gnus.org with esmtp (Exim 4.80) (envelope-from ) id 1XePcT-0007bh-Eo for ding@gnus.org; Wed, 15 Oct 2014 16:32:05 +0200 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XePcT-00031S-79 for ding@gnus.org; Wed, 15 Oct 2014 16:32:05 +0200 Original-Received: from 198.0.146.153 ([198.0.146.153]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Oct 2014 16:32:05 +0200 Original-Received: from tzz by 198.0.146.153 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Oct 2014 16:32:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 198.0.146.153 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (darwin) Cancel-Lock: sha1:e4GW6+YfeOGgFwK4/NjxXT8rlqM= X-Spam-Score: -1.7 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:85134 Archived-At: On Tue, 14 Oct 2014 16:48:26 -0400 jorge.alfaro-murillo@yale.edu (Jorge A. Alfaro-Murillo) wrote: JAA> Ted Zlatanov writes: >> All right, could you resubmit the patch with a proper ChangeLog >> entry? It looks OK otherwise. JAA> Sorry Ted, this is the first time that I send a patch to gnus. What do JAA> I have to do exactly? Is the description that I added to the patch not JAA> enough? I mean: JAA> * lisp/gnus/message.el (message-insert-signature): Change (insert JAA> "\n") for (newline) Look at the existing ChangeLog and add your entry there, then send the full diff. I'd also reword, for clarity: Use `newline' instead of inserting explicit "\n". ...but I don't feel strongly about it, so it's your call :) Ted