* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
[not found] <E1T6mSl-00057h-3s@quimby.gnus.org>
@ 2012-08-29 21:23 ` Julien Danjou
2012-08-31 4:38 ` Katsumi Yamaoka
0 siblings, 1 reply; 6+ messages in thread
From: Julien Danjou @ 2012-08-29 21:23 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Wed, Aug 29 2012, Dave Abrahams wrote:
> - Log -----------------------------------------------------------------
> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
> Author: Dave Abrahams <dave@boostpro.com>
> Date: Tue Aug 28 12:34:49 2012 -0700
>
> Revert "Add recent argument to nnimap-find-article-by-message-id"
>
> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>
> Conflicts:
>
> lisp/ChangeLog
> lisp/nnimap.el
I think you should at least modify the changelog file to add the fact
that you reverted something, and explain why you did it.
And all your others commits miss changelog entries too, as far as I can
see.
--
Julien Danjou
;; Free Software hacker & freelance
;; http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
2012-08-29 21:23 ` [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry Julien Danjou
@ 2012-08-31 4:38 ` Katsumi Yamaoka
2012-08-31 6:36 ` Dave Abrahams
0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2012-08-31 4:38 UTC (permalink / raw)
To: Dave Abrahams; +Cc: ding
Julien Danjou wrote:
> On Wed, Aug 29 2012, Dave Abrahams wrote:
>> - Log -----------------------------------------------------------------
>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
>> Author: Dave Abrahams <dave@boostpro.com>
>> Date: Tue Aug 28 12:34:49 2012 -0700
>>
>> Revert "Add recent argument to nnimap-find-article-by-message-id"
>>
>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>>
>> Conflicts:
>>
>> lisp/ChangeLog
>> lisp/nnimap.el
> I think you should at least modify the changelog file to add the fact
> that you reverted something, and explain why you did it.
> And all your others commits miss changelog entries too, as far as I can
> see.
Wasn't your change to nnimap.el incomplete? BTW, I've added change
log entries temporarily for the sake of synch'ng Emacs trunk with
Gnus master. Please fix wrong ones by yourself if any.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
2012-08-31 4:38 ` Katsumi Yamaoka
@ 2012-08-31 6:36 ` Dave Abrahams
2012-08-31 14:34 ` Michael Welsh Duggan
2012-09-01 5:08 ` Dave Abrahams
0 siblings, 2 replies; 6+ messages in thread
From: Dave Abrahams @ 2012-08-31 6:36 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: ding, Julien Danjou
on Thu Aug 30 2012, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:
> Julien Danjou wrote:
>> On Wed, Aug 29 2012, Dave Abrahams wrote:
>
>>> - Log -----------------------------------------------------------------
>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
>>> Author: Dave Abrahams <dave@boostpro.com>
>>> Date: Tue Aug 28 12:34:49 2012 -0700
>>>
>>> Revert "Add recent argument to nnimap-find-article-by-message-id"
>>>
>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>>>
>>> Conflicts:
>>>
>>> lisp/ChangeLog
>>> lisp/nnimap.el
>
>> I think you should at least modify the changelog file to add the fact
>> that you reverted something, and explain why you did it.
Yes, this was a mistake. I'm terribly sorry; by the time I realized
that I had pushed the change without a decent commit message, it was too
late. The reason for this
change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268
>> And all your others commits miss changelog entries too, as far as I can
>> see.
Oh! The Changelog file. I've never really maintained one in my own
projects, so I don't think of that automatically.
> Wasn't your change to nnimap.el incomplete?
Probably (see below)
Julien, before I go and add a note there about this revert, I think we
should discuss what should be done because evidently reverting your
change caused warnings in the build
(http://www.randomsample.de:4456/builders/emacs23-linux/builds/760), so
maybe things were already broken in some other way.
As for the other commits, sorry; I'll fix the Changelog in the morning.
> BTW, I've added change
> log entries temporarily for the sake of synch'ng Emacs trunk with
> Gnus master. Please fix wrong ones by yourself if any.
Thank you so much; I will.
--
Dave Abrahams
BoostPro Computing Software Development Training
http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
2012-08-31 6:36 ` Dave Abrahams
@ 2012-08-31 14:34 ` Michael Welsh Duggan
2012-09-01 5:08 ` Dave Abrahams
2012-09-01 5:08 ` Dave Abrahams
1 sibling, 1 reply; 6+ messages in thread
From: Michael Welsh Duggan @ 2012-08-31 14:34 UTC (permalink / raw)
To: Dave Abrahams; +Cc: Katsumi Yamaoka, ding, Julien Danjou
Dave Abrahams <dave@boostpro.com> writes:
> on Thu Aug 30 2012, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:
>
>> Julien Danjou wrote:
>>> On Wed, Aug 29 2012, Dave Abrahams wrote:
>>
>>>> - Log -----------------------------------------------------------------
>>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
>>>> Author: Dave Abrahams <dave@boostpro.com>
>>>> Date: Tue Aug 28 12:34:49 2012 -0700
>>>>
>>>> Revert "Add recent argument to nnimap-find-article-by-message-id"
>>>>
>>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>>>>
>>>> Conflicts:
>>>>
>>>> lisp/ChangeLog
>>>> lisp/nnimap.el
>>
>>> I think you should at least modify the changelog file to add the fact
>>> that you reverted something, and explain why you did it.
>
> Yes, this was a mistake. I'm terribly sorry; by the time I realized
> that I had pushed the change without a decent commit message, it was too
> late. The reason for this
> change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268
I really hope that the reverted commit can be fixed and re-added at some
point. It is an important speed-up (minutes to seconds!) on systems
that have miserable search by message-id times (stupid MS Exchange).
Only reverting this change means that the
nnimap-find-article-by-message-id call in nnimap-request-move-article
has too many arguments.
--
Michael Welsh Duggan
(mwd@cert.org)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
2012-08-31 6:36 ` Dave Abrahams
2012-08-31 14:34 ` Michael Welsh Duggan
@ 2012-09-01 5:08 ` Dave Abrahams
1 sibling, 0 replies; 6+ messages in thread
From: Dave Abrahams @ 2012-09-01 5:08 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: ding, Julien Danjou
on Thu Aug 30 2012, Dave Abrahams <dave-AT-boostpro.com> wrote:
> on Thu Aug 30 2012, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:
>
>> Julien Danjou wrote:
>>> On Wed, Aug 29 2012, Dave Abrahams wrote:
>>
>>>> - Log -----------------------------------------------------------------
>>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
>>>> Author: Dave Abrahams <dave@boostpro.com>
>>>> Date: Tue Aug 28 12:34:49 2012 -0700
>>>>
>>>> Revert "Add recent argument to nnimap-find-article-by-message-id"
>>>>
>>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>>>>
>>>> Conflicts:
>>>>
>>>> lisp/ChangeLog
>>>> lisp/nnimap.el
>>
>>> I think you should at least modify the changelog file to add the fact
>>> that you reverted something, and explain why you did it.
I un-reverted the change and added what I think was a fix for the problem
in the bug report below.
> Yes, this was a mistake. I'm terribly sorry; by the time I realized
> that I had pushed the change without a decent commit message, it was too
> late. The reason for this
> change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268
>
>>> And all your others commits miss changelog entries too, as far as I can
>>> see.
>
> Oh! The Changelog file. I've never really maintained one in my own
> projects, so I don't think of that automatically.
>
>> Wasn't your change to nnimap.el incomplete?
>
> Probably (see below)
>
> Julien, before I go and add a note there about this revert, I think we
> should discuss what should be done because evidently reverting your
> change caused warnings in the build
> (http://www.randomsample.de:4456/builders/emacs23-linux/builds/760), so
> maybe things were already broken in some other way.
I'd still like someone to look at
http://git.gnus.org/cgit/gnus.git/commit/?id=f36869c21744af08b25be653bdbaa81617f43ef8
and
http://git.gnus.org/cgit/gnus.git/commit/?id=2fb0b7ac1adacec45fd50f7aa7de5ea57fda4d19
to make sure they seem OK.
--
Dave Abrahams
BoostPro Computing Software Development Training
http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
2012-08-31 14:34 ` Michael Welsh Duggan
@ 2012-09-01 5:08 ` Dave Abrahams
0 siblings, 0 replies; 6+ messages in thread
From: Dave Abrahams @ 2012-09-01 5:08 UTC (permalink / raw)
To: Michael Welsh Duggan; +Cc: Katsumi Yamaoka, ding, Julien Danjou
on Fri Aug 31 2012, Michael Welsh Duggan <mwd-AT-cert.org> wrote:
> I really hope that the reverted commit can be fixed and re-added at some
> point. It is an important speed-up (minutes to seconds!) on systems
> that have miserable search by message-id times (stupid MS Exchange).
>
> Only reverting this change means that the
> nnimap-find-article-by-message-id call in nnimap-request-move-article
> has too many arguments.
Please pull again; it should be back now.
--
Dave Abrahams
BoostPro Computing Software Development Training
http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-01 5:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1T6mSl-00057h-3s@quimby.gnus.org>
2012-08-29 21:23 ` [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry Julien Danjou
2012-08-31 4:38 ` Katsumi Yamaoka
2012-08-31 6:36 ` Dave Abrahams
2012-08-31 14:34 ` Michael Welsh Duggan
2012-09-01 5:08 ` Dave Abrahams
2012-09-01 5:08 ` Dave Abrahams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).