From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/82189 Path: news.gmane.org!not-for-mail From: Dave Abrahams Newsgroups: gmane.emacs.gnus.general Subject: Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry Date: Fri, 31 Aug 2012 22:08:13 -0700 Message-ID: References: <87ehmpqto6.fsf@dex.adm.naquadah.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346476189 3987 80.91.229.3 (1 Sep 2012 05:09:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2012 05:09:49 +0000 (UTC) Cc: ding@gnus.org, Julien Danjou To: Katsumi Yamaoka Original-X-From: ding-owner+M30456@lists.math.uh.edu Sat Sep 01 07:09:47 2012 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7fxq-0007R9-TX for ding-account@gmane.org; Sat, 01 Sep 2012 07:09:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1T7fwg-0007uB-1C; Sat, 01 Sep 2012 00:08:34 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1T7fwe-0007u0-GP for ding@lists.math.uh.edu; Sat, 01 Sep 2012 00:08:32 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1T7fwa-0005Oc-32 for ding@lists.math.uh.edu; Sat, 01 Sep 2012 00:08:31 -0500 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1T7fwY-0002GK-6L for ding@gnus.org; Sat, 01 Sep 2012 07:08:26 +0200 Original-Received: by pbbrr4 with SMTP id rr4so6846138pbb.17 for ; Fri, 31 Aug 2012 22:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:x-gm-message-state; bh=UwJ4s8d9NOZhonJv3GRqNVnrcWGjECdy4Snf0tsdQG4=; b=K9PuE9GEJxvw77RvVR+t2gqsCGR13eu4rr6PEMNJjfYHdq1HA2qBQWCyz19wmzuBlw LrSJGx6rwpxhk9A+BYXSF/L0LDvyZ+GL3bGIfVU1A0v8jRt9gf1eXwNXTYBSJV31tZD3 ZXs4kkwAPPl7USx0a+wWTbcCXpbAPB2WvnuBL/GK25V6fWCIKudKVH2xhbakliYEwa40 bR7L0PD5Cb3UUvhnjT3I1h5tuG/GmHa+hqYPSlsUT+KziMNmwKwP4fpzZ6m32Ioj1xBf KtTG88EWcZU76zAo2FRC5CWwFPxXbMM1Pj+gzVDvnlVzhR3i06JlTuURyc47Yw3oWreo moUA== Original-Received: by 10.68.190.8 with SMTP id gm8mr22107213pbc.74.1346476099351; Fri, 31 Aug 2012 22:08:19 -0700 (PDT) Original-Received: from pluto.local (96-41-170-122.dhcp.mdfd.or.charter.com. [96.41.170.122]) by mx.google.com with ESMTPS id oc2sm4904383pbb.69.2012.08.31.22.08.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 31 Aug 2012 22:08:17 -0700 (PDT) Original-Received: by pluto.local (Postfix, from userid 501) id 9E1525FC257C; Fri, 31 Aug 2012 22:08:13 -0700 (PDT) In-Reply-To: (Dave Abrahams's message of "Thu, 30 Aug 2012 23:36:42 -0700") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin) X-Gm-Message-State: ALoCoQkafaXO8ftrluLHdfL6vjDPJtzGCAzMR7H18xTxNoknW1GQgii2whDzlNoAvmOOT2t+EZC7 X-Spam-Score: -2.9 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:82189 Archived-At: on Thu Aug 30 2012, Dave Abrahams wrote: > on Thu Aug 30 2012, Katsumi Yamaoka wrote: > >> Julien Danjou wrote: >>> On Wed, Aug 29 2012, Dave Abrahams wrote: >> >>>> - Log ----------------------------------------------------------------- >>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de >>>> Author: Dave Abrahams >>>> Date: Tue Aug 28 12:34:49 2012 -0700 >>>> >>>> Revert "Add recent argument to nnimap-find-article-by-message-id" >>>> >>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394. >>>> >>>> Conflicts: >>>> >>>> lisp/ChangeLog >>>> lisp/nnimap.el >> >>> I think you should at least modify the changelog file to add the fact >>> that you reverted something, and explain why you did it. I un-reverted the change and added what I think was a fix for the problem in the bug report below. > Yes, this was a mistake. I'm terribly sorry; by the time I realized > that I had pushed the change without a decent commit message, it was too > late. The reason for this > change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268 > >>> And all your others commits miss changelog entries too, as far as I can >>> see. > > Oh! The Changelog file. I've never really maintained one in my own > projects, so I don't think of that automatically. > >> Wasn't your change to nnimap.el incomplete? > > Probably (see below) > > Julien, before I go and add a note there about this revert, I think we > should discuss what should be done because evidently reverting your > change caused warnings in the build > (http://www.randomsample.de:4456/builders/emacs23-linux/builds/760), so > maybe things were already broken in some other way. I'd still like someone to look at http://git.gnus.org/cgit/gnus.git/commit/?id=f36869c21744af08b25be653bdbaa81617f43ef8 and http://git.gnus.org/cgit/gnus.git/commit/?id=2fb0b7ac1adacec45fd50f7aa7de5ea57fda4d19 to make sure they seem OK. -- Dave Abrahams BoostPro Computing Software Development Training http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost