September 0.18: gnus-summary-reply-with-original

September 0.18: gnus-summary-reply-with-original

[Sean Lynch]

I'm getting the following error when I attempt to reply when I already
have a *mail* buffer:

Signalling: (wrong-type-argument integer-or-marker-p nil)
  gnus-mail-reply((14))
  gnus-summary-reply(t (14))
  gnus-summary-reply-with-original(nil)
  call-interactively(gnus-summary-reply-with-original)

I'm running XEmacs 19.13.  If I knew what I was doing, I'd fix it
myself, but I don't.  It looks to me like gnus-mail-reply is expecting
an integer.  Should gnus-mail-reply be changed to take a list, or
should gnus-summary-reply be passing it an integer?

--Sean

Re: September 0.18: gnus-summary-reply-with-original

[Steven L. Baur]

>>>>> "Sean" == Sean Lynch <nc0273@office4.corp.netcom.com> writes:

    Sean> I'm getting the following error when I attempt to reply when
    Sean> I already have a *mail* buffer:

    Sean> Signalling: (wrong-type-argument integer-or-marker-p nil)
    Sean> gnus-mail-reply((14)) gnus-summary-reply(t (14))
    Sean> gnus-summary-reply-with-original(nil)
    Sean> call-interactively(gnus-summary-reply-with-original)

    Sean> I'm running XEmacs 19.13.  If I knew what I was doing, I'd
    Sean> fix it myself, but I don't.  It looks to me like
    Sean> gnus-mail-reply is expecting an integer.  Should
    Sean> gnus-mail-reply be changed to take a list, or should
    Sean> gnus-summary-reply be passing it an integer?

The problem is with zmacs regions being enabled, which they appear to
be by default in XEmacs.  The following patch fixes that.
===================================================================
RCS file: RCS/ChangeLog,v
retrieving revision 1.13
diff -u -r1.13 ChangeLog
--- 1.13	1995/12/06 05:58:39
+++ ChangeLog	1995/12/06 16:29:21
@@ -1,3 +1,8 @@
+Wed Dec  6 08:29:04 1995  Steven L. Baur  <steve@miranova.com>
+
+	* gnus-msg.el (gnus-mail-reply): Defend against zmacs regions being
+	enabled.
+
 Tue Dec  5 21:54:39 1995  Steven L. Baur  <steve@miranova.com>
 
 	* gnus-setup.el: Use default installation paths, misc. cleanup
===================================================================
RCS file: RCS/gnus-msg.el,v
retrieving revision 1.10
diff -u -r1.10 gnus-msg.el
--- 1.10	1995/12/06 16:28:29
+++ gnus-msg.el	1995/12/06 16:28:52
@@ -1735,7 +1735,7 @@
 		  (mail-yank-original nil)
 		  (save-restriction
 		    (narrow-to-region (point-min) (point))
-		    (goto-char (mark))
+		    (goto-char (mark t))
 		    (let ((news-reply-yank-from
 			   (save-excursion 
 			     (set-buffer gnus-article-buffer)

-- 
steve@miranova.com baur