From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63960 Path: news.gmane.org!not-for-mail From: Sascha Wilde Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Patch: Show signature state in encrypted messages using pgg Date: Sat, 11 Nov 2006 22:48:35 +0100 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1163281750 2925 80.91.229.2 (11 Nov 2006 21:49:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 11 Nov 2006 21:49:10 +0000 (UTC) Cc: ding , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 11 22:49:08 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gj0iq-0002yF-1e for ged-emacs-devel@m.gmane.org; Sat, 11 Nov 2006 22:49:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gj0ip-0004g7-HJ for ged-emacs-devel@m.gmane.org; Sat, 11 Nov 2006 16:49:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gj0iT-0004aY-8z for emacs-devel@gnu.org; Sat, 11 Nov 2006 16:48:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gj0iR-0004Zi-JC for emacs-devel@gnu.org; Sat, 11 Nov 2006 16:48:44 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gj0iR-0004Zc-Gt for emacs-devel@gnu.org; Sat, 11 Nov 2006 16:48:43 -0500 Original-Received: from [62.141.58.119] (helo=km1136.keymachine.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gj0iR-0004jw-A0 for emacs-devel@gnu.org; Sat, 11 Nov 2006 16:48:43 -0500 Original-Received: from kenny.sha-bang.de (xdslcv221.osnanet.de [89.166.149.221]) (authenticated bits=0) by km1136.keymachine.de (8.12.11.20060308/8.12.10) with ESMTP id kABLmXOH031999; Sat, 11 Nov 2006 22:48:34 +0100 Original-Received: from wilde by kenny.sha-bang.de with local (Kenny MUA v.0409034.42) ID 1Gj0iJ-0002iO-UK; Sat, 11 Nov 2006 22:48:35 +0100 Original-To: Daiki Ueno In-Reply-To: (Daiki Ueno's message of "Sat\, 11 Nov 2006 11\:19\:48 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.90 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62080 gmane.emacs.gnus.general:63960 Archived-At: Daiki Ueno wrote: >>>>>> In =20 >>>>>> Sascha Wilde wrote: >> [1 ] >> Sascha Wilde wrote: > >> > The attached patch extends the message a bit, so that it shows the >> > signature verification result in addition. With it a encrypted but >> > unsigned mail shows: >> > [[[PGP Encrypted Part:OK, Signer: From unknown user]] > > Is there still any chance for such a feature enhancement to get into the > release? Anyway, No, I don't think so, but I think that: 1. There is a chance to get it into gnus CVS 2. It is a good idea to make it public available, not at least as a reminder for after the release... ;-) >> +2006-11-10 Sascha Wilde >> + >> + * mml2015.el (mml2015-pgg-decrypt, mml2015-pgg-clear-decrypt):=20 >> + Show info on signature for decrypted parts. >> + >> + (mm-set-handle-multipart-parameter >> + mm-security-handle 'gnus-info (concat "OK, Signer: " sig)))) > > Did you really test it?=20 Yes, and I'm using a patched version for some days without problems, but: beware I've only tested this code, not proven it right. ;-) > mm-uu-pgp-encrypted-extract-1 checks the > verification result stored in gnus-info > > (progn > (mml2015-clean-buffer) > (funcall (mml2015-clear-decrypt-function)) > (equal (mm-handle-multipart-ctl-parameter mm-security-handle > 'gnus-info) > "OK")) Yes, this might be a problem indeed -- but as far as I can see from a quick glance over the source mm-uu-pgp-encrypted-extract-1 is only used for "application/x-gnus-pgp-encrypted" which seems quite non standard and which I haven't knowingly encountered in real live -- which would explains why I haven't noticed the glitch in my patch... Anyway how about something along the lines of=20 ;;; untested: (progn (mml2015-clean-buffer) (funcall (mml2015-clear-decrypt-function)) (eq t (compare-strings "OK" nil nil (mm-handle-multipart-ctl-parameter mm-security-handle 'gnus-info) nil 2))) this should fix it. cheers sascha --=20 Sascha Wilde Die Existenz von Spam hei=DFt, da=DF ein Medium noch lebt. Die Existenz von Pr0n hei=DFt, da=DF es Zukunft hat. -- Leitners Law (<40f7d168@fefe.de>, 16. Juli 2004)