From: Sascha Wilde <wilde@sha-bang.de>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Small patch to enable use of gpg-agent with pgg
Date: Sun, 19 Mar 2006 18:30:10 +0100 [thread overview]
Message-ID: <m2d5gijqal.fsf@kenny.sha-bang.de> (raw)
In-Reply-To: <m23bhe933c.fsf@kenny.sha-bang.de> (Sascha Wilde's message of "Sun, 19 Mar 2006 10:49:11 +0100")
[-- Attachment #1.1.1: Type: text/plain, Size: 869 bytes --]
Sascha Wilde <wilde@sha-bang.de> wrote:
> Daniel Pittman <daniel@rimspace.net> wrote:
>>> Sascha Wilde <wilde@sha-bang.de> writes:
>>
>>> I wrote a small patch, which makes it possible to use the GnuPG agent
>>> (which is part of gpg 1.9 and considered ready to use by Werner) with
>>> the GnuPG backend of pgg.
> [...]
>> I am not convinced that this is the best idea -- so far as I can see, if
>> I were to set `pgg-gpg-use-agent' to `t' then I *must* use the agent.
>>
>> Is it not possible to enable gpg to try the agent first, then to prompt
>> for a passphrase?
>
> Yes, that would be good. I'll try to implement it.
I attached a patch which performs a test if gpg-agent is really
available when pgg-gpg-use-agent is set to t.
Please note, this new patch also fixees a bug, which was introduced
by the original patch and broke non agent use...
cheers
sascha
[-- Attachment #1.1.2: pgg-gpg-agent.patch --]
[-- Type: text/x-patch, Size: 6832 bytes --]
*** pgg-gpg.el 11 Feb 2006 17:01:56 +0100 1.4
--- pgg-gpg.el 19 Mär 2006 17:05:38 +0100
***************
*** 4,10 ****
;; 2005, 2006 Free Software Foundation, Inc.
;; Author: Daiki Ueno <ueno@unixuser.org>
! ;; Symmetric encryption added by: Sascha Wilde <wilde@sha-bang.de>
;; Created: 1999/10/28
;; Keywords: PGP, OpenPGP, GnuPG
--- 4,11 ----
;; 2005, 2006 Free Software Foundation, Inc.
;; Author: Daiki Ueno <ueno@unixuser.org>
! ;; Symmetric encryption and gpg-agent support added by:
! ;; Sascha Wilde <wilde@sha-bang.de>
;; Created: 1999/10/28
;; Keywords: PGP, OpenPGP, GnuPG
***************
*** 51,64 ****
:type '(choice (const :tag "New `--recipient' option" "--recipient")
(const :tag "Old `--remote-user' option" "--remote-user")))
(defvar pgg-gpg-user-id nil
"GnuPG ID of your default identity.")
(defun pgg-gpg-process-region (start end passphrase program args)
! (let* ((output-file-name (pgg-make-temp-file "pgg-output"))
(args
`("--status-fd" "2"
! ,@(if passphrase '("--passphrase-fd" "0"))
"--yes" ; overwrite
"--output" ,output-file-name
,@pgg-gpg-extra-args ,@args))
--- 52,73 ----
:type '(choice (const :tag "New `--recipient' option" "--recipient")
(const :tag "Old `--remote-user' option" "--remote-user")))
+ (defcustom pgg-gpg-use-agent nil
+ "Whether to use gnupg agent for key caching."
+ :group 'pgg-gpg
+ :type 'boolean)
+
(defvar pgg-gpg-user-id nil
"GnuPG ID of your default identity.")
(defun pgg-gpg-process-region (start end passphrase program args)
! (let* ((use-agent (pgg-gpg-use-agent-p))
! (output-file-name (pgg-make-temp-file "pgg-output"))
(args
`("--status-fd" "2"
! ,@(if (and passphrase (not use-agent))
! '("--passphrase-fd" "0"))
! ,@(if use-agent '("--use-agent"))
"--yes" ; overwrite
"--output" ,output-file-name
,@pgg-gpg-extra-args ,@args))
***************
*** 77,83 ****
(input (buffer-substring-no-properties start end))
(default-enable-multibyte-characters nil))
(with-temp-buffer
! (when passphrase
(insert passphrase "\n"))
(insert input)
(setq exit-status
--- 86,92 ----
(input (buffer-substring-no-properties start end))
(default-enable-multibyte-characters nil))
(with-temp-buffer
! (when (and passphrase (not (pgg-gpg-use-agent-p)))
(insert passphrase "\n"))
(insert input)
(setq exit-status
***************
*** 181,187 ****
If optional PASSPHRASE is not specified, it will be obtained from the
passphrase cache or user."
(let* ((pgg-gpg-user-id (or pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or passphrase
(when sign
(pgg-read-passphrase
(format "GnuPG passphrase for %s: "
--- 190,197 ----
If optional PASSPHRASE is not specified, it will be obtained from the
passphrase cache or user."
(let* ((pgg-gpg-user-id (or pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or (pgg-gpg-use-agent-p)
! passphrase
(when sign
(pgg-read-passphrase
(format "GnuPG passphrase for %s: "
***************
*** 213,219 ****
If optional PASSPHRASE is not specified, it will be obtained from the
passphrase cache or user."
! (let* ((passphrase (or passphrase
(pgg-read-passphrase
"GnuPG passphrase for symmetric encryption: ")))
(args
--- 223,230 ----
If optional PASSPHRASE is not specified, it will be obtained from the
passphrase cache or user."
! (let* ((passphrase (or (pgg-gpg-use-agent-p)
! passphrase
(pgg-read-passphrase
"GnuPG passphrase for symmetric encryption: ")))
(args
***************
*** 241,247 ****
(key-id (pgg-gpg-key-id-from-key-owner key-owner))
(pgg-gpg-user-id (or key-id key
pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or passphrase
(pgg-read-passphrase
(format (if (pgg-gpg-symmetric-key-p message-keys)
"Passphrase for symmetric decryption: "
--- 252,259 ----
(key-id (pgg-gpg-key-id-from-key-owner key-owner))
(pgg-gpg-user-id (or key-id key
pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or (pgg-gpg-use-agent-p)
! passphrase
(pgg-read-passphrase
(format (if (pgg-gpg-symmetric-key-p message-keys)
"Passphrase for symmetric decryption: "
***************
*** 276,282 ****
(defun pgg-gpg-sign-region (start end &optional cleartext passphrase)
"Make detached signature from text between START and END."
(let* ((pgg-gpg-user-id (or pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or passphrase
(pgg-read-passphrase
(format "GnuPG passphrase for %s: " pgg-gpg-user-id)
pgg-gpg-user-id)))
--- 288,295 ----
(defun pgg-gpg-sign-region (start end &optional cleartext passphrase)
"Make detached signature from text between START and END."
(let* ((pgg-gpg-user-id (or pgg-gpg-user-id pgg-default-user-id))
! (passphrase (or (pgg-gpg-use-agent-p)
! passphrase
(pgg-read-passphrase
(format "GnuPG passphrase for %s: " pgg-gpg-user-id)
pgg-gpg-user-id)))
***************
*** 345,350 ****
--- 358,382 ----
(append-to-buffer pgg-output-buffer (point-min)(point-max))
(pgg-process-when-success)))
+ (defun pgg-gpg-update-agent ()
+ "Try to connet to gpg-agent and send UPDATESTARTUPTTY."
+ (let* ((agent-info (getenv "GPG_AGENT_INFO"))
+ (socket (and agent-info
+ (string-match "^\\([^:]*\\)" agent-info)
+ (match-string 1 agent-info)))
+ (conn (and socket
+ (make-network-process :name "gpg-agent-process"
+ :host 'local :family 'local
+ :service socket))))
+ (when (and conn (eq (process-status conn) 'open))
+ (process-send-string conn "UPDATESTARTUPTTY\n")
+ (delete-process conn)
+ t)))
+
+ (defun pgg-gpg-use-agent-p ()
+ "Return t if `pgg-gpg-use-agent' is t and gpg-agent is available."
+ (and pgg-gpg-use-agent (pgg-gpg-update-agent)))
+
(provide 'pgg-gpg)
;;; arch-tag: 2aa5d5d8-93a0-4865-9312-33e29830e000
[-- Attachment #1.1.3: Type: text/plain, Size: 174 bytes --]
--
Sascha Wilde : VI is to EMACS as masturbation is to making love:
: effective and always available but probably not your
: first choice...
[-- Attachment #1.2: Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-03-19 17:30 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2cd46e7f0510031250u66ea1349yb437d539ce4027ef@mail.gmail.com>
[not found] ` <2cd46e7f0510061541w73bb6a92wb6d22829b6e804ae@mail.gmail.com>
[not found] ` <20051007100014.GB4850@kenny.sha-bang.local>
[not found] ` <2cd46e7f0510071106k3d4d3e6agc36f16a37d8b6bc6@mail.gmail.com>
[not found] ` <20051007214952.GA30235@kenny.sha-bang.local>
[not found] ` <iluvf08mm1w.fsf@latte.josefsson.org>
[not found] ` <20051008103627.GA1218@kenny.sha-bang.local>
[not found] ` <2cd46e7f0510081131h14e2bbeaga7f1a33ebd6347c8@mail.gmail.com>
[not found] ` <2cd46e7f0510101415t76825ea7u9749fe23da54ce@mail.gmail.com>
[not found] ` <2cd46e7f0510121647x3c51fb65pc883ed61f4e864ab@mail.gmail.com>
[not found] ` <2cd46e7f0510200708x4640d1c2t50743cf439e52dd4@mail.gmail.com>
[not found] ` <ilur7ag8efp.fsf@latte.josefsson.org>
2006-03-18 21:17 ` Sascha Wilde
2006-03-18 23:30 ` Daniel Pittman
2006-03-19 0:46 ` Miles Bader
2006-03-19 3:45 ` Daniel Pittman
2006-03-19 18:28 ` Miles Bader
2006-03-19 9:49 ` Sascha Wilde
2006-03-19 17:30 ` Sascha Wilde [this message]
2006-03-21 14:32 ` Simon Josefsson
2006-03-21 21:29 ` Reiner Steib
2006-03-22 9:49 ` Simon Josefsson
2006-03-22 8:36 ` Sascha Wilde
2006-03-22 9:16 ` Daiki Ueno
2006-03-22 9:48 ` Simon Josefsson
2006-03-22 11:03 ` Sascha Wilde
2006-03-22 11:13 ` Simon Josefsson
2006-03-22 12:25 ` Daiki Ueno
2006-03-23 10:40 ` Daiki Ueno
2006-03-23 11:00 ` Simon Josefsson
2006-03-23 12:18 ` Daiki Ueno
2006-03-23 13:08 ` Simon Josefsson
2006-03-24 5:51 ` Daiki Ueno
2006-03-26 0:29 ` Daiki Ueno
2006-03-26 1:08 ` Simon Josefsson
2006-03-26 3:29 ` Miles Bader
2006-03-26 5:06 ` Daiki Ueno
2006-03-26 17:05 ` Simon Josefsson
2006-03-26 18:24 ` Sascha Wilde
2006-03-27 9:36 ` Simon Josefsson
2006-03-31 7:10 ` Romain Francoise
2006-04-01 9:06 ` Simon Josefsson
2006-04-01 9:23 ` Romain Francoise
2006-04-03 8:14 ` "[GNUPG:] TRUST_UNDEFINED" not indicated (was: Small patch to enable use of gpg-agent with pgg) Reiner Steib
2006-04-03 8:32 ` "[GNUPG:] TRUST_UNDEFINED" not indicated Daiki Ueno
2006-04-03 8:48 ` Romain Francoise
2006-04-03 9:00 ` Daiki Ueno
2006-04-03 9:28 ` Romain Francoise
2006-04-03 9:29 ` Simon Josefsson
2006-04-03 16:42 ` Adam Sjøgren
2006-04-03 17:00 ` Romain Francoise
2006-04-03 17:13 ` Adam Sjøgren
2006-04-04 2:39 ` Daiki Ueno
2006-04-04 7:18 ` Romain Francoise
2006-04-04 10:35 ` Simon Josefsson
2006-04-04 22:58 ` Reiner Steib
2006-04-04 23:30 ` Simon Josefsson
2006-04-03 8:49 ` "[GNUPG:] TRUST_UNDEFINED" not indicated (was: Small patch to Simon Josefsson
2006-04-05 1:52 ` pgg-gpg: BEGIN_SIGNING Daiki Ueno
2006-04-05 8:40 ` Simon Josefsson
2006-04-05 10:06 ` Daiki Ueno
2006-04-05 11:02 ` Simon Josefsson
2006-04-05 11:46 ` Daiki Ueno
2006-04-05 13:01 ` Simon Josefsson
2006-04-05 15:21 ` Please test current GPG features (was: pgg-gpg: BEGIN_SIGNING) Reiner Steib
2006-04-05 15:31 ` Please test current GPG features Simon Josefsson
2006-04-05 16:17 ` Reiner Steib
2006-04-18 8:56 ` Simon Josefsson
2006-04-19 10:03 ` Daiki Ueno
2006-04-19 10:39 ` Simon Josefsson
2006-04-06 10:40 ` Reiner Steib
2006-04-06 11:02 ` Simon Josefsson
2006-04-06 13:01 ` Reiner Steib
2006-04-06 13:41 ` Simon Josefsson
2006-04-06 16:20 ` Romain Francoise
2006-04-06 18:08 ` Romain Francoise
2006-04-06 18:27 ` Reiner Steib
2006-04-06 18:36 ` Romain Francoise
2006-03-23 12:52 ` Small patch to enable use of gpg-agent with pgg Sascha Wilde
2006-03-23 20:07 ` Daiki Ueno
2006-03-23 22:16 ` Sascha Wilde
2006-04-05 9:13 ` pgg-gpg broken? Sascha Wilde
2006-04-05 9:42 ` Daiki Ueno
2006-04-05 10:18 ` Sascha Wilde
2006-04-05 21:33 ` Daiki Ueno
2006-04-06 9:00 ` Sascha Wilde
2006-04-06 9:21 ` Daiki Ueno
2006-04-06 9:58 ` Sascha Wilde
2006-04-06 10:13 ` Daiki Ueno
2006-04-07 10:32 ` gpg-agent support removed?! (was: pgg-gpg broken?) Sascha Wilde
2006-04-07 12:11 ` Simon Josefsson
2006-04-07 12:14 ` gpg-agent support removed?! Romain Francoise
2006-04-07 13:00 ` Sascha Wilde
2006-04-07 13:30 ` Simon Josefsson
2006-04-07 20:59 ` Reiner Steib
2006-04-08 9:36 ` Romain Francoise
2006-04-08 10:05 ` Sascha Wilde
2006-04-07 12:35 ` Reiner Steib
2006-04-07 13:02 ` Daiki Ueno
2006-04-07 13:08 ` Sascha Wilde
2006-04-07 13:26 ` Daiki Ueno
2006-04-09 16:04 ` Sascha Wilde
2006-04-10 18:04 ` Reiner Steib
2006-04-07 13:40 ` Reiner Steib
2006-04-07 14:05 ` Thomas Baumann
2006-04-07 14:40 ` Daiki Ueno
2006-04-07 15:45 ` Reiner Steib
2006-04-07 20:55 ` Daiki Ueno
2006-04-07 21:22 ` Reiner Steib
2006-04-08 7:03 ` Thomas Baumann
2006-04-08 10:18 ` Daiki Ueno
[not found] ` <E1FRydQ-0007gN-9f@fencepost.gnu.org>
[not found] ` <873bgo4d0e.fsf@pacem.orebokech.com>
[not found] ` <d215ebff-cfee-4d23-852b-86f1f0d955b8@well-done.deisui.org>
[not found] ` <87r7482tjt.fsf@pacem.orebokech.com>
[not found] ` <fa2c4f80-3b38-4a6c-99ac-ff8dbd1c99f4@well-done.deisui.org>
2006-04-10 18:04 ` PGG maintainance (was: gpg-agent support removed?!) Reiner Steib
2006-04-05 16:14 ` pgg-gpg broken? Reiner Steib
2006-04-05 19:22 ` Sascha Wilde
2006-03-22 9:46 ` Small patch to enable use of gpg-agent with pgg Simon Josefsson
2006-03-22 16:13 ` Simon Josefsson
2006-03-22 23:01 ` Katsumi Yamaoka
2006-03-22 23:45 ` Simon Josefsson
2006-03-23 0:58 ` Katsumi Yamaoka
2006-03-23 9:12 ` Simon Josefsson
2006-03-23 10:26 ` Sascha Wilde
2006-03-23 10:54 ` Simon Josefsson
2006-03-23 11:12 ` Simon Josefsson
2006-03-23 11:16 ` Simon Josefsson
2006-03-23 12:51 ` Reiner Steib
2006-03-23 13:07 ` Sascha Wilde
2006-03-23 13:10 ` Simon Josefsson
2006-03-23 12:00 ` Sascha Wilde
2006-03-23 13:00 ` Simon Josefsson
2006-03-26 18:11 ` Sascha Wilde
[not found] ` <m2wtels74l.fsf@kenny.sha-bang .de>
2006-03-23 23:09 ` Miles Bader
2006-04-02 0:30 ` Ken Manheimer
2006-04-02 8:28 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d5gijqal.fsf@kenny.sha-bang.de \
--to=wilde@sha-bang.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).