From: David Engster <deng@randomsample.de>
To: ding@gnus.org
Subject: Re: commit email subject lines
Date: Thu, 24 Feb 2011 18:10:36 +0100 [thread overview]
Message-ID: <m2ei6x73zn.fsf@randomsample.de> (raw)
In-Reply-To: <87tyft1ivx.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 24 Feb 2011 10:45:22 -0600")
Ted Zlatanov writes:
> On Thu, 24 Feb 2011 09:46:14 +0100 David Engster <deng@randomsample.de> wrote:
>
> DE> Lars Ingebrigtsen writes:
>>> Ted Zlatanov <tzz@lifelogs.com> writes:
>>>
>>>> It started with the tags. Lars, did you change post-receive?
>>>
>>> Nope. Haven't changed anything.
>
> DE> This happens because post-receive uses the output from git-describe by
> DE> default:
>
> DE> describe=$(git describe $rev 2>/dev/null)
> DE> if [ -z "$describe" ]; then
> DE> describe=$( (git log --format="%s" $oldrev...$newrev | perl -e'@p = <>; chomp @p; print "=", scalar @p, "= ", join(" ; ", @p)') 2>/dev/null)
> DE> fi
>
> DE> I guess just using the git-log output should make things work again. I
> DE> don't understand the need for git-describe here anyway.
>
> Me neither. But it seems like it could be useful (according to the `git
> describe' docs it tells you how to reach the nearest tag). Maybe it
> should be in the subject anyhow?
Then append it, though I don't think that "n0-13-35-g4c0611b" is a
particular useful piece of information for a commit message ("this is
based on n0-13 but with 35 commits on top with the current being
4c0611b").
-David
next prev parent reply other threads:[~2011-02-24 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:10 Adam Sjøgren
2011-02-23 13:18 ` Julien Danjou
2011-02-23 14:31 ` Ted Zlatanov
2011-02-23 23:28 ` Lars Ingebrigtsen
2011-02-24 8:46 ` David Engster
2011-02-24 16:45 ` Ted Zlatanov
2011-02-24 17:10 ` David Engster [this message]
2011-02-24 17:48 ` Ted Zlatanov
2011-02-25 11:00 ` Ted Zlatanov
2011-02-24 18:51 ` James Cloos
2011-02-23 23:28 ` Lars Ingebrigtsen
2011-02-24 11:02 ` Julien Danjou
2011-02-24 12:30 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ei6x73zn.fsf@randomsample.de \
--to=deng@randomsample.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).