From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/69502 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Wrong coding system in mm-uu-pgp-signed-extract-1 Date: Thu, 01 Apr 2010 17:38:12 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270136322 4363 80.91.229.12 (1 Apr 2010 15:38:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 1 Apr 2010 15:38:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: ding@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 01 17:38:36 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NxMTW-0003ZT-6Y for ged-emacs-devel@m.gmane.org; Thu, 01 Apr 2010 17:38:31 +0200 Original-Received: from localhost ([127.0.0.1]:50672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxMTV-0004KS-Eq for ged-emacs-devel@m.gmane.org; Thu, 01 Apr 2010 11:38:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxMTQ-0004KI-SS for emacs-devel@gnu.org; Thu, 01 Apr 2010 11:38:24 -0400 Original-Received: from [140.186.70.92] (port=48029 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxMTO-0004Jo-4x for emacs-devel@gnu.org; Thu, 01 Apr 2010 11:38:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxMTM-0005AJ-Ew for emacs-devel@gnu.org; Thu, 01 Apr 2010 11:38:22 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:49572) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxMTM-00059i-9a for emacs-devel@gnu.org; Thu, 01 Apr 2010 11:38:20 -0400 Original-Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id B26941C15AC2; Thu, 1 Apr 2010 17:38:13 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 773AA90871; Thu, 1 Apr 2010 17:38:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan1.mnet-online.de [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id cSiImyzdy-Hr; Thu, 1 Apr 2010 17:38:12 +0200 (CEST) Original-Received: from igel.home (ppp-88-217-125-50.dynamic.mnet-online.de [88.217.125.50]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 1 Apr 2010 17:38:12 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 689E1CA29C; Thu, 1 Apr 2010 17:38:12 +0200 (CEST) X-Yow: I'm having a MID-WEEK CRISIS! User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.94 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123022 gmane.emacs.gnus.general:69502 Archived-At: When gnus verifies a pgp signed message it gets the coding system wrong. mm-uu-pgp-signed-extract-1 should use the coding system of the *mm-uu* buffer in preference (which is the coding system that mm-uu-copy-to-buffer has set from the original buffer), since that is what the signature was created against. I have installed this patch in the emacs-23 branch. Andreas. 2010-04-01 Andreas Schwab * mm-uu.el (mm-uu-pgp-signed-extract-1): Use buffer-file-coding-system if set. === modified file 'lisp/gnus/mm-uu.el' --- lisp/gnus/mm-uu.el 2010-01-13 08:35:10 +0000 +++ lisp/gnus/mm-uu.el 2010-04-01 15:08:50 +0000 @@ -486,9 +486,11 @@ apply the face `mm-uu-extract'." (if (mm-uu-pgp-signed-test) (progn (mml2015-clean-buffer) - (let ((coding-system-for-write (or gnus-newsgroup-charset + (let ((coding-system-for-write (or buffer-file-coding-system + gnus-newsgroup-charset 'iso-8859-1)) - (coding-system-for-read (or gnus-newsgroup-charset + (coding-system-for-read (or buffer-file-coding-system + gnus-newsgroup-charset 'iso-8859-1))) (funcall (mml2015-clear-verify-function)))) (when (and mml2015-use (null (mml2015-clear-verify-function))) -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."