From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78778
Path: news.gmane.org!not-for-mail
From: David Engster <deng@randomsample.de>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: [gnus git]  branch master updated: n0-17-27-g43f8466 =1= nntp.el (nntp-open-connection): Set TCP keepalive option.
Date: Tue, 10 May 2011 16:19:10 +0200
Message-ID: <m2fwom3ag1.fsf@randomsample.de>
References: <E1QJYrH-0001ys-1x@quimby.gnus.org>
	<m3ei47pju5.fsf@quimbies.gnus.org> <87ei473ywy.fsf@randomsample.de>
	<jwvaaeuacuu.fsf-monnier+INBOX@gnu.org>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: dough.gmane.org 1305037243 22514 80.91.229.12 (10 May 2011 14:20:43 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Tue, 10 May 2011 14:20:43 +0000 (UTC)
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,  ding@gnus.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: ding-owner+M27079@lists.math.uh.edu Tue May 10 16:20:36 2011
Return-path: <ding-owner+M27079@lists.math.uh.edu>
Envelope-to: ding-account@gmane.org
Original-Received: from util0.math.uh.edu ([129.7.128.18])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <ding-owner+M27079@lists.math.uh.edu>)
	id 1QJnnf-0002JQ-GN
	for ding-account@gmane.org; Tue, 10 May 2011 16:20:35 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by util0.math.uh.edu with smtp (Exim 4.63)
	(envelope-from <ding-owner+M27079@lists.math.uh.edu>)
	id 1QJnmT-0004JS-3t; Tue, 10 May 2011 09:19:21 -0500
Original-Received: from mx1.math.uh.edu ([129.7.128.32])
	by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.63)
	(envelope-from <deng@randomsample.de>)
	id 1QJnmS-0004JL-66
	for ding@lists.math.uh.edu; Tue, 10 May 2011 09:19:20 -0500
Original-Received: from quimby.gnus.org ([80.91.231.51])
	by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.72)
	(envelope-from <deng@randomsample.de>)
	id 1QJnmR-0005Iv-31
	for ding@lists.math.uh.edu; Tue, 10 May 2011 09:19:20 -0500
Original-Received: from v3-1008.vxen.de ([79.140.41.8])
	by quimby.gnus.org with esmtp (Exim 4.72)
	(envelope-from <deng@randomsample.de>)
	id 1QJnmP-0000Sx-Lx; Tue, 10 May 2011 16:19:17 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a;
	h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=Qv042jYfCYP4T5uBcf1bRy4aw983i1/ekeDcUWYg/fI=;
	b=Jbltq2zf0Gpp424krl0wHnHigU+RD9bK/HJaLVxi++l5cwIim8sDMHxk6fmwlyNrAN1DirnussXaSQhOcVn7kC9Vc6sfTFIwz/30FwQaZZX9vMTFyX9rnDwp6qxLF6L6;
Original-Received: from [134.76.4.230] (helo=imac.local)
	by v3-1008.vxen.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72)
	(envelope-from <deng@randomsample.de>)
	id 1QJnmO-0002At-F1; Tue, 10 May 2011 16:19:16 +0200
In-Reply-To: <jwvaaeuacuu.fsf-monnier+INBOX@gnu.org> (Stefan Monnier's message
	of "Tue, 10 May 2011 10:46:36 -0300")
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (darwin)
Mail-Followup-To: Stefan Monnier <monnier@iro.umontreal.ca>, Lars Magne
	Ingebrigtsen <larsi@gnus.org>, ding@gnus.org
X-Spam-Score: -2.0 (--)
List-ID: <ding.gnus.org>
Precedence: bulk
Xref: news.gmane.org gmane.emacs.gnus.general:78778
Archived-At: <http://permalink.gmane.org/gmane.emacs.gnus.general/78778>

Stefan Monnier writes:
>>> I don't necessarily disagree with this patch, but I'm wondering what the
>>> use case is.
>> In any case, the buildbot is now complaining that this (probably) won't
>> work on Emacs22 and XEmacs. :-)
>
> I must say I have no idea what makes it think so.  The `fboundp' check
> should avoid those problems.

You're checking for set-network-process-option, but not for
process-type. At least that will fix the warning for Emacs22.

Regarding XEmacs, I have no idea...

-David