[patch] spam.el revision 7.35 stopping exit from groups

[patch] spam.el revision 7.35 stopping exit from groups

[Nelson Ferreira]

After updating gnus with to the latest CVS, I started getting:


Signaling: (wrong-type-argument number-char-or-marker-p nil)
  spam-summary-prepare-exit()
  run-hooks(spam-summary-prepare-exit)
  apply(run-hooks spam-summary-prepare-exit)
  gnus-run-hooks(gnus-summary-prepare-exit-hook)
  #<compiled-function (&optional temporary leave-hidden) "...(434)" [gnus-article-buffer group gnus-buffers quit-config buffer buf gnus-set-global-variables gnus-buffer-live-p mm-destroy-parts nil gnus-kill-save-kill-buffer gnus-async-halt-prefetch gnus-group-quit-config t gnus-score-adaptive gnus-score-save gnus-run-hooks gnus-summary-prepare-exit-hook get-buffer buffer-name delete kill-buffer gnus-cache-possibly-remove-articles gnus-cache-save-buffers gnus-async-prefetch-remove-group gnus-dup-enter-articles gnus-tree-close gnus-cache-write-active nnmail-purge-split-history string-match "^[^:]+:" 0 gnus-exit-group-hook gnus-summary-update-info gnus-close-group gnus-group-jump-to-group gnus-summary-exit-hook gnus-group-group-name gnus-group-next-unread-group 1 gnus-deaden-summary gnus-summary-clear-local-variables bury-buffer gnus-summary-mode pop-to-buffer gnus-configure-windows force gnus-handle-ephemeral-exit gname gnus-group-buffer ...] 5 ("/usr/lib/xemacs/site-packages/lisp/gnus/gnus-sum.elc" . 188106) nil>()
  call-interactively(gnus-summary-exit)


This small patch fixed it for me, use it freely:


diff -u -u -b -r7.35 spam.el
--- lisp/spam.el        14 May 2004 19:41:07 -0000      7.35
+++ lisp/spam.el        15 May 2004 16:56:56 -0000
@@ -869,9 +869,9 @@

     ;; now we redo spam-mark-spam-as-expired-and-move-routine to only
     ;; expire spam, in case the above did not expire them
-    (when (< 0 (spam-list-articles
+    (when (< 0 (length (spam-list-articles
                gnus-newsgroup-articles
-               'spam))
+                       'spam)))
       (gnus-message 6 "Marking spam as expired without moving it")
       (spam-mark-spam-as-expired-and-move-routine nil))



-- 
Nelson Ferreira

Re: [patch] spam.el revision 7.35 stopping exit from groups

[Nevin Kapur]

Nelson Ferreira <nelson.ferreira@verizon.net> writes:

> After updating gnus with to the latest CVS, I started getting:
>
>
> Signaling: (wrong-type-argument number-char-or-marker-p nil)
>   spam-summary-prepare-exit()

The following patch fixes it for me.

-Nevin

Index: spam.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/spam.el,v
retrieving revision 7.35
diff -u -r7.35 spam.el
--- spam.el	14 May 2004 19:41:07 -0000	7.35
+++ spam.el	15 May 2004 17:34:53 -0000
@@ -869,9 +869,8 @@
 
     ;; now we redo spam-mark-spam-as-expired-and-move-routine to only
     ;; expire spam, in case the above did not expire them
-    (when (< 0 (spam-list-articles
-		gnus-newsgroup-articles
-		'spam))
+    (when (spam-list-articles gnus-newsgroup-articles
+			      'spam)
       (gnus-message 6 "Marking spam as expired without moving it")
       (spam-mark-spam-as-expired-and-move-routine nil))
 

Re: [patch] spam.el revision 7.35 stopping exit from groups

[Ted Zlatanov]

On Sat, 15 May 2004, nelson.ferreira@verizon.net wrote:


> After updating gnus with to the latest CVS, I started getting:
> 
> Signaling: (wrong-type-argument number-char-or-marker-p nil)

Sorry, I tested with (length) but somehow I didn't put it in the CVS
commit.  Fixed as suggested.

Ted