From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78380 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: no gnus registry new dependency on ert? Date: Wed, 06 Apr 2011 15:28:07 +0200 Message-ID: References: <8762qs3swu.fsf@ericabrahamsen.net> <87ipur8zny.fsf@lifelogs.com> <87aag38xah.fsf@lifelogs.com> <87vcyrr0ec.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1302096508 29024 80.91.229.12 (6 Apr 2011 13:28:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2011 13:28:28 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 15:28:24 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7SmW-0007Ax-6Z for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 15:28:24 +0200 Original-Received: from localhost ([127.0.0.1]:36685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7SmV-000894-Ow for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 09:28:23 -0400 Original-Received: from [140.186.70.92] (port=38565 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7SmR-00088z-B8 for emacs-devel@gnu.org; Wed, 06 Apr 2011 09:28:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7SmQ-0008Gz-7J for emacs-devel@gnu.org; Wed, 06 Apr 2011 09:28:19 -0400 Original-Received: from v3-1008.vxen.de ([79.140.41.8]:45635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7SmP-0008Ge-VB for emacs-devel@gnu.org; Wed, 06 Apr 2011 09:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=cAqoApCwXOblrlSj8LdyU2Ya632SfS1yTJ7GNormK9Q=; b=Ob4CK+fS596hYFtnAcBnoflR9TDOYZqIKDMFzX1tC3Tsrwwdjxu5fg/JuqWr8viYL/cGXXGDElaQAxWO9nhKJY3cS2VxqY3zjh66T0/8aWMig7S2R+dDnop2A8BdfTtm; Original-Received: from [134.76.4.230] (helo=imac.local) by v3-1008.vxen.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Q7SmL-0001h3-7i; Wed, 06 Apr 2011 15:28:13 +0200 In-Reply-To: <87vcyrr0ec.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 06 Apr 2011 08:10:19 -0500") User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (darwin) Mail-Followup-To: Ted Zlatanov , ding@gnus.org, emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 79.140.41.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138233 gmane.emacs.gnus.general:78380 Archived-At: Ted Zlatanov writes: > On Wed, 06 Apr 2011 05:54:46 -0500 Ted Zlatanov wrote: > > TZ> On Wed, 06 Apr 2011 12:10:26 +0200 David Engster wrote: > DE> Either that, or just do > > DE> (eval-when-compile > DE> (when (null (require 'ert nil t)) > DE> (defmacro* ert-deftest (name () &body docstring-keys-and-body)))) > > DE> to silence the byte-compiler. Your solution is less hacky, but then you > DE> have to always remember to wrap ert-deftest in those featurep clauses. > > TZ> Oh, I like your solution better since I don't have to reindent ;) > > TZ> I made the change in *registry.el, thanks. > > Interesting. When I byte-compile in Gnus (just "make" in the Lisp > directory), I get the attached backtrace. Sorry for the nasty backtrace > but I can't load the code AND exhibit the problem. > > If I load gnus-registry.el and do `M-x eval-buffer' then it works > properly. So something is off with the byte-compilation, at least the > compilation that Gnus does. It seems like putting (require 'ert) into an eval-when-compile is not sufficient. You have to require it unconditionally. So maybe your first idea was The Right Thing To Do, meaning to use (require 'ert nil t) and then test for feature 'ert. Alternatively, you could use the current hack and put this require in there, too. But this is getting increasingly ugly... -David