Re: latest imap changes break refiling

[Alan Schmitt <alan.schmitt@polytechnique.org>]

[-- Attachment #1: Type: text/plain, Size: 2485 bytes --]

On 2015-02-13 10:34, Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> On 2015-02-13 17:23, Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Alan Schmitt <alan.schmitt@polytechnique.org> writes:
>>
>>> I'm sorry, there is still a bug:
>>>
>>> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>>>   string-match("^[^:]+:" nil)
>>>   nnimap-retrieve-group-data-early("local" (nil))
>>
>> This should be fixed in git Gnus now.
>
> Unfortunately it still breaks here. Here is what I see:

I've dug a little in this, here are my findings. It seems the problems
only occur in the following setting:
- the target group is in a different server
- the target group is empty.

I'm able to reproduce this without the expiring process: if I move
a message (using "B m") to a group satisfying these conditions I get the
same error.

The problem happens in the last line of that snippet

#+begin_src emacs-lisp
(deffoo nnimap-request-group (group &optional server dont-check info)
  (setq group (nnimap-decode-gnus-group group))
  (let ((result (nnimap-change-group
      	   ;; Don't SELECT the group if we're going to select it
      	   ;; later, anyway.
      	   (if (and (not dont-check)
      		    (assoc group nnimap-current-infos))
      	       nil
      	     group)
      	   server))
        articles active marks high low)
    (with-current-buffer nntp-server-buffer
      (when result
        (when (or (not dont-check)
      	    (not (setq active
      		       (nth 2 (assoc group nnimap-current-infos)))))
          (let ((sequences (nnimap-retrieve-group-data-early
      		      server (list info))))
#+end_src

It happens if the function is called with info being nil, then
`nnimap-retrieve-group-data-early' is called with `(nil)' as second
argument (the singleton list containing the empty list).

Since `(nil)' is not nil, the guard of the `when' in the following
snippet does not prevent the code from being run

#+begin_src emacs-lisp
(deffoo nnimap-retrieve-group-data-early (server infos)
  (when (and (nnimap-change-group nil server)
             infos)
#+end_src

and the rest of the code breaks (when a `dolist' is done on the list
`(nil)').

Unfortunately I don't know what should be done in `nnimap-request-group'
if `info' is nil, so I cannot propose a patch.

I'll gladly take any suggestion as how to fix this.

Thanks,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 494 bytes --]