From: Nevin Kapur <kapur@mts.jhu.edu>
Subject: [PATCH] Re: Slow IMAP startup
Date: Sat, 12 Jul 2003 17:56:40 -0400 [thread overview]
Message-ID: <m2n0fjjtnr.fsf@nkpbook.mts.jhu.edu> (raw)
In-Reply-To: <84adbjzeki.fsf@lucy.is.informatik.uni-duisburg.de>
kai.grossjohann@gmx.net (Kai Großjohann) writes:
> Nevin Kapur <kapur@mts.jhu.edu> writes:
>
>> I've noticed that Gnus takes an inordinately long time to start up.
>> In the minibuffer I see the message "Listing subscribed groups on..."
>> and I have to wait for about 3 to 4 minutes.
>
> See variable nnimap-request-list-method. Does it help?
Not in any meaningful way. (But read on for the full story.)
I set about trying to identify the bottleneck. Using elp and edebug,
I think I identified a bug in nnimap-request-newgroups. While looping
over nnimap-list-pattern it ignores the pattern, resulting in each of
your subscribed mailboxes being accessed once for each pattern. The
following patch fixes this and has cut the startup time for me by
about a fourth. Would someone review it and commit it, please?
2003-07-12 Nevin Kapur <kapur@mts.jhu.edu>
* nnimap.el (nnimap-request-newgroups): Use the pattern in
nnimap-list-pattern instead of "*".
Index: lisp/nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 6.68
diff -u -r6.68 nnimap.el
--- lisp/nnimap.el 17 Jun 2003 22:32:02 -0000 6.68
+++ lisp/nnimap.el 12 Jul 2003 22:04:14 -0000
@@ -1326,7 +1326,7 @@
(nnimap-before-find-minmax-bugworkaround)
(dolist (pattern (nnimap-pattern-to-list-arguments
nnimap-list-pattern))
- (dolist (mbx (imap-mailbox-lsub "*" (car pattern) nil
+ (dolist (mbx (imap-mailbox-lsub (cdr pattern) (car pattern) nil
nnimap-server-buffer))
(or (catch 'found
(dolist (mailbox (imap-mailbox-get 'list-flags mbx
-Nevin
next prev parent reply other threads:[~2003-07-12 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-12 19:01 Nevin Kapur
2003-07-12 20:15 ` Kai Großjohann
2003-07-12 21:56 ` Nevin Kapur [this message]
2003-07-13 2:33 ` [PATCH] " Simon Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2n0fjjtnr.fsf@nkpbook.mts.jhu.edu \
--to=kapur@mts.jhu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).